You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@hamilton.apache.org by "officialasishkumar (via GitHub)" <gi...@apache.org> on 2026/05/24 21:46:26 UTC

[PR] Improve dynamic resolver power user mode error [hamilton]

officialasishkumar opened a new pull request, #1604:
URL: https://github.com/apache/hamilton/pull/1604

   Improves the error raised when dynamic resolver decorators are used without enabling power user mode, including the case where the config key is missing entirely.
   
   ## Changes
   
   - Replaced direct indexing of `hamilton.enable_power_user_mode` with a defaulted config lookup.
   - Updated the error text to point users at `.with_config({'hamilton.enable_power_user_mode': True})`.
   - Added regression coverage for both explicit `False` and missing power-user-mode config.
   
   ## How I tested this
   
   - `uv run --with pytest pytest tests/function_modifiers/test_delayed.py::test_delayed_without_power_mode_fails tests/function_modifiers/test_delayed.py::test_delayed_without_power_mode_config_fails_with_helpful_error`
   - `uv run ruff format --check hamilton/function_modifiers/delayed.py tests/function_modifiers/test_delayed.py`
   - `uv run ruff check hamilton/function_modifiers/delayed.py tests/function_modifiers/test_delayed.py`
   
   ## Notes
   
   Fixes #1135.
   
   ## Checklist
   
   - [x] PR has an informative and human-readable title (this will be pulled into the release notes)
   - [x] Changes are limited to a single goal (no scope creep)
   - [x] Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
   - [x] Any _change_ in functionality is tested
   - [x] New functions are documented (with a description, list of inputs, and expected output)
   - [x] Placeholder code is flagged / future TODOs are captured in comments
   - [x] Project documentation has been updated if adding/changing functionality.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@hamilton.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Improve dynamic resolver power user mode error [hamilton]

Posted by "jernejfrank (via GitHub)" <gi...@apache.org>.
jernejfrank merged PR #1604:
URL: https://github.com/apache/hamilton/pull/1604


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@hamilton.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org