You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/03/20 07:38:46 UTC

[GitHub] [kafka] showuon commented on a change in pull request #10367: KAFKA-12495: allow consecutive revoke in incremental cooperative assignor in connector

showuon commented on a change in pull request #10367:
URL: https://github.com/apache/kafka/pull/10367#discussion_r598077882



##########
File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignor.java
##########
@@ -60,8 +60,6 @@
     private final Time time;
     private final int maxDelay;
     private ConnectorsAndTasks previousAssignment;
-    private ConnectorsAndTasks previousRevocation;
-    private boolean canRevoke;

Review comment:
       change (1): remove unused `previousRevocation` and `canRevoke` 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org