[jira] [Commented] (FLINK-7772) Test instability in BlobCacheDeleteTest

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-7772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16194488#comment-16194488 ] 

ASF GitHub Bot commented on FLINK-7772:
---------------------------------------

GitHub user NicoK opened a pull request:

    https://github.com/apache/flink/pull/4782

    [FLINK-7772][blob] fix test instability in BlobCacheDeleteTest

    ## What is the purpose of the change
    
    `BlobCacheDeleteTest` did not account for the server executing the delete call of a transient BLOB after acknowledging the request. This resulted in the `testDeleteTransientLocalFails*` tests failing.
    
    ## Brief change log
    
    - use `verifyDeletedEventually` instead due to the asynchronous delete call
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/NicoK/flink flink-7772

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4782.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4782
    
----
commit 6992d4447cb7d2d2a4bf1260152a5c682fa04c4c
Author: Nico Kruber <ni...@data-artisans.com>
Date:   2017-10-06T10:34:40Z

    [FLINK-7772][blob] fix test instability in BlobCacheDeleteTest
    
    BlobCacheDeleteTest did not account for the server executing the delete call of
    a transient BLOB after acknowledging the request. This resulted in the
    testDeleteTransientLocalFails* tests failing.

----


> Test instability in BlobCacheDeleteTest
> ---------------------------------------
>
>                 Key: FLINK-7772
>                 URL: https://issues.apache.org/jira/browse/FLINK-7772
>             Project: Flink
>          Issue Type: Bug
>          Components: Network
>    Affects Versions: 1.4.0
>            Reporter: Nico Kruber
>            Assignee: Nico Kruber
>
> {{BlobCacheDeleteTest}} did not account for the server executing the delete call of a transient BLOB after acknowledging the request. This resulted in the {{testDeleteTransientLocalFails*}} tests failing.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)