You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/09/16 10:08:26 UTC
[GitHub] [shardingsphere] jian365066744 opened a new pull request #7485: Add more test cases for ShardingSphere-Proxy #7321
jian365066744 opened a new pull request #7485:
URL: https://github.com/apache/shardingsphere/pull/7485
Fixes #7321.
Changes proposed in this pull request:
-add test FrontendChannelInboundHandler
-add test ServerHandlerInitializer
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on pull request #7485: Add more test cases for ShardingSphere-Proxy #7321
Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #7485:
URL: https://github.com/apache/shardingsphere/pull/7485#issuecomment-695786601
@jian365066744 Hi, you mean the following error log is irrelated to your PR, don't you? I triggered the CI Test to rerun with your PR. Let us wait for the test result this time.
```
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.3:testCompile (default-testCompile) on project shardingsphere-proxy-frontend-core: Compilation failure: Compilation failure:
18313[ERROR] /home/travis/build/apache/shardingsphere/shardingsphere-proxy/shardingsphere-proxy-frontend/shardingsphere-proxy-frontend-core/src/test/java/org/apache/shardingsphere/proxy/frontend/netty/FrontendChannelInboundHandlerTest.java:[28,77] cannot find symbol
18314[ERROR] symbol: class ResourceSynchronizer
18315[ERROR] location: package org.apache.shardingsphere.proxy.backend.communication.jdbc.connection
18316[ERROR] /home/travis/build/apache/shardingsphere/shardingsphere-proxy/shardingsphere-proxy-frontend/shardingsphere-proxy-frontend-core/src/test/java/org/apache/shardingsphere/proxy/frontend/netty/FrontendChannelInboundHandlerTest.java:[76,13] cannot find symbol
18317[ERROR] symbol: class ResourceSynchronizer
18318[ERROR] location: class org.apache.shardingsphere.proxy.frontend.netty.FrontendChannelInboundHandlerTest
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] jian365066744 commented on pull request #7485: Add more test cases for ShardingSphere-Proxy #7321
Posted by GitBox <gi...@apache.org>.
jian365066744 commented on pull request #7485:
URL: https://github.com/apache/shardingsphere/pull/7485#issuecomment-698719449
juan:
thanks your details reply.The code is run correctly in location(mvn clean install -DskipTests -Dmaven.javadoc.skip=true) ,all test case also can pass.I don't konw why the CI test run failed ,and the logs show that cannot find symbol: class ResourceSynchronizer.can you give some suggestions or thoughts?
------------------ 原始邮件 ------------------
发件人: "apache/shardingsphere" <notifications@github.com>;
发送时间: 2020年9月21日(星期一) 上午10:53
收件人: "apache/shardingsphere"<shardingsphere@noreply.github.com>;
抄送: "123"<365066744@qq.com>;"Mention"<mention@noreply.github.com>;
主题: Re: [apache/shardingsphere] Add more test cases for ShardingSphere-Proxy #7321 (#7485)
@jian365066744 Hi, the latest CI test result failed also. Since other PR could pass the CI test, I suppose you need to give the CI test a look. Have you built the master branch successfully with your changes locally?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on pull request #7485: Add more test cases for ShardingSphere-Proxy #7321
Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #7485:
URL: https://github.com/apache/shardingsphere/pull/7485#issuecomment-698740770
Maybe a new PR for your changes can be raised. BTW, did you pull upstream from the master branch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] jian365066744 closed pull request #7485: Add more test cases for ShardingSphere-Proxy #7321
Posted by GitBox <gi...@apache.org>.
jian365066744 closed pull request #7485:
URL: https://github.com/apache/shardingsphere/pull/7485
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] jian365066744 closed pull request #7485: Add more test cases for ShardingSphere-Proxy #7321
Posted by GitBox <gi...@apache.org>.
jian365066744 closed pull request #7485:
URL: https://github.com/apache/shardingsphere/pull/7485
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on pull request #7485: Add more test cases for ShardingSphere-Proxy #7321
Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #7485:
URL: https://github.com/apache/shardingsphere/pull/7485#issuecomment-695879273
@jian365066744 Hi, the latest CI test result failed also. Since other PR could pass the CI test, I suppose you need to give the CI test a look. Have you built the master branch successfully with your changes locally?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] jian365066744 commented on pull request #7485: Add more test cases for ShardingSphere-Proxy #7321
Posted by GitBox <gi...@apache.org>.
jian365066744 commented on pull request #7485:
URL: https://github.com/apache/shardingsphere/pull/7485#issuecomment-694736931
I don't know why I get the error in build with maven compile .it show that lack of org.apache.shardingsphere.proxy.backend.communication.jdbc.connection.ResourceSynchronizer.but it run correctly in local.The detail like this.
------------------ 原始邮件 ------------------
发件人: "apache/shardingsphere" <notifications@github.com>;
发送时间: 2020年9月17日(星期四) 上午10:32
收件人: "apache/shardingsphere"<shardingsphere@noreply.github.com>;
抄送: "123"<365066744@qq.com>;"Author"<author@noreply.github.com>;
主题: Re: [apache/shardingsphere] Add more test cases for ShardingSphere-Proxy #7321 (#7485)
@tristaZero requested changes on this pull request.
Thanks@jian365066744.
Glad to see your PR here, but I supposed fixing the CI test issue is expected.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on pull request #7485: Add more test cases for ShardingSphere-Proxy #7321
Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #7485:
URL: https://github.com/apache/shardingsphere/pull/7485#issuecomment-698740770
Maybe a new PR for your changes can be raised. BTW, did you pull upstream from the master branch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on pull request #7485: Add more test cases for ShardingSphere-Proxy #7321
Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #7485:
URL: https://github.com/apache/shardingsphere/pull/7485#issuecomment-695786601
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] jian365066744 commented on pull request #7485: Add more test cases for ShardingSphere-Proxy #7321
Posted by GitBox <gi...@apache.org>.
jian365066744 commented on pull request #7485:
URL: https://github.com/apache/shardingsphere/pull/7485#issuecomment-698719449
juan:
thanks your details reply.The code is run correctly in location(mvn clean install -DskipTests -Dmaven.javadoc.skip=true) ,all test case also can pass.I don't konw why the CI test run failed ,and the logs show that cannot find symbol: class ResourceSynchronizer.can you give some suggestions or thoughts?
------------------ 原始邮件 ------------------
发件人: "apache/shardingsphere" <notifications@github.com>;
发送时间: 2020年9月21日(星期一) 上午10:53
收件人: "apache/shardingsphere"<shardingsphere@noreply.github.com>;
抄送: "123"<365066744@qq.com>;"Mention"<mention@noreply.github.com>;
主题: Re: [apache/shardingsphere] Add more test cases for ShardingSphere-Proxy #7321 (#7485)
@jian365066744 Hi, the latest CI test result failed also. Since other PR could pass the CI test, I suppose you need to give the CI test a look. Have you built the master branch successfully with your changes locally?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org