You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "rouault (via GitHub)" <gi...@apache.org> on 2025/06/19 17:21:27 UTC

[PR] [C++][Parquet] arrow/reader.y: remove prototypes of GetRecordBatchReader() [arrow]

rouault opened a new pull request, #46867:
URL: https://github.com/apache/arrow/pull/46867

   … variants whose implementation has been removed
   
   ### Rationale for this change
   
   Consistency between headers and implementations
   
   ### What changes are included in this PR?
   
   Commit f7bc27132ea84c4639528d73a9c289c7a1db154f removed implementation of those 3 methods. Technically they were not formally deprecated in 19.0.0, although I suspect this was an oversight as the virtual method they rely on was deprecated.
   
   ### Are these changes tested?
   
   N/A
   
   ### Are there any user-facing changes?
   
   Yes
   
   **This PR includes breaking changes to public APIs.** 
   
   CC @AlenkaF 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [C++][Parquet] arrow/reader.y: remove prototypes of GetRecordBatchReader() [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #46867:
URL: https://github.com/apache/arrow/pull/46867#issuecomment-2988758270

   <!--
     Licensed to the Apache Software Foundation (ASF) under one
     or more contributor license agreements.  See the NOTICE file
     distributed with this work for additional information
     regarding copyright ownership.  The ASF licenses this file
     to you under the Apache License, Version 2.0 (the
     "License"); you may not use this file except in compliance
     with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
     Unless required by applicable law or agreed to in writing,
     software distributed under the License is distributed on an
     "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
     KIND, either express or implied.  See the License for the
     specific language governing permissions and limitations
     under the License.
   -->
   
   Thanks for opening a pull request!
   
   If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
   
   Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
   
   Then could you also rename the pull request title in the following format?
   
       GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
   
   or
   
       MINOR: [${COMPONENT}] ${SUMMARY}
   
   See also:
   
     * [Other pull requests](https://github.com/apache/arrow/pulls/)
     * [Contribution Guidelines - Contributing Overview](https://arrow.apache.org/docs/developers/overview.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [C++][Parquet] Remove prototypes of removed parquet:arrow::FileReader::GetRecordBatchReader() [arrow]

Posted by "rouault (via GitHub)" <gi...@apache.org>.
rouault commented on PR #46867:
URL: https://github.com/apache/arrow/pull/46867#issuecomment-2989194098

   > I think that we should restore the implementations instead of removing prototypes.
   
   done in https://github.com/apache/arrow/pull/46868
   
   > We need to add Result + shared_ptr versions of them to deprecated Status + shared_ptr versions. Could you open an issue for this and work on this?
   
   Sorry, I don't have availability for that


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [C++][Parquet] Remove prototypes of removed parquet:arrow::FileReader::GetRecordBatchReader() [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #46867:
URL: https://github.com/apache/arrow/pull/46867#issuecomment-2989160864

   Hmm. They (`shared_ptr` versions) weren't deprecated. I think that we should restore the implementations instead of removing prototypes.
   
   We need to add `Result` + `shared_ptr` versions of them to deprecated `Status` + `shared_ptr` versions. Could you open an issue for this and work on this?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [C++][Parquet] Remove prototypes of removed parquet:arrow::FileReader::GetRecordBatchReader() [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #46867:
URL: https://github.com/apache/arrow/pull/46867#issuecomment-2989565465

   No problem. I've opened #46869 for it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [C++][Parquet] Remove prototypes of removed parquet:arrow::FileReader::GetRecordBatchReader() [arrow]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou closed pull request #46867: [C++][Parquet] Remove prototypes of removed parquet:arrow::FileReader::GetRecordBatchReader()
URL: https://github.com/apache/arrow/pull/46867


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org