You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/08/20 16:34:48 UTC

[GitHub] [spark] srowen commented on issue #25510: [SPARK-28780][ML] Delete the incorrect setWeightCol method in LinearSVCModel

srowen commented on issue #25510: [SPARK-28780][ML] Delete the incorrect setWeightCol method in LinearSVCModel
URL: https://github.com/apache/spark/pull/25510#issuecomment-523094402
 
 
   That wouldn't hurt to 'back port' a different change that deprecates it and makes it emit a warning only. We can get it into 2.4.4, 2.3.4 indeed. I'm not super concerned about it because a call to `setWeightCol("myCol")` would not even compile right now. I can't see that anyone would ever have used it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org