You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ratis.apache.org by GitBox <gi...@apache.org> on 2020/08/06 07:05:59 UTC

[GitHub] [incubator-ratis] amaliujia opened a new pull request #169: RATIS-1024.Unit Tests for MemoryRaftLog entry truncation

amaliujia opened a new pull request #169:
URL: https://github.com/apache/incubator-ratis/pull/169


   ## What changes were proposed in this pull request?
   Add unit tests to test MemoryReftLog log truncation
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/RATIS-1024
   
   Please replace this section with the link to the Apache JIRA)
   
   ## How was this patch tested?
   
   unit tests
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ratis] szetszwo merged pull request #169: RATIS-1024.Unit Tests for MemoryRaftLog entry truncation

Posted by GitBox <gi...@apache.org>.
szetszwo merged pull request #169:
URL: https://github.com/apache/incubator-ratis/pull/169


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ratis] szetszwo commented on pull request #169: RATIS-1024.Unit Tests for MemoryRaftLog entry truncation

Posted by GitBox <gi...@apache.org>.
szetszwo commented on pull request #169:
URL: https://github.com/apache/incubator-ratis/pull/169#issuecomment-670805865


   @amaliujia , could you see if the failed unit test is related?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ratis] szetszwo commented on pull request #169: RATIS-1024.Unit Tests for MemoryRaftLog entry truncation

Posted by GitBox <gi...@apache.org>.
szetszwo commented on pull request #169:
URL: https://github.com/apache/incubator-ratis/pull/169#issuecomment-671475188


   Thanks, @amaliujia .  I just have merged this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ratis] amaliujia commented on pull request #169: RATIS-1024.Unit Tests for MemoryRaftLog entry truncation

Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #169:
URL: https://github.com/apache/incubator-ratis/pull/169#issuecomment-670645467


   @szetszwo 
   
   Per file history I am guessing you are the right person to review this PR. Can you take a look?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ratis] amaliujia commented on pull request #169: RATIS-1024.Unit Tests for MemoryRaftLog entry truncation

Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #169:
URL: https://github.com/apache/incubator-ratis/pull/169#issuecomment-670816629


   @szetszwo
   
   The failed UT is not related. `org.apache.ratis.TestMultiRaftGroup` has failed and I created https://issues.apache.org/jira/browse/RATIS-1026 to track it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-ratis] amaliujia commented on pull request #169: RATIS-1024.Unit Tests for MemoryRaftLog entry truncation

Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #169:
URL: https://github.com/apache/incubator-ratis/pull/169#issuecomment-671539223


   Thank you!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org