You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/01/17 18:20:41 UTC
[GitHub] [druid] maytasm3 opened a new pull request #9210: [Backport] Fix
LATEST / EARLIEST Buffer Aggregator does not work on String column
maytasm3 opened a new pull request #9210: [Backport] Fix LATEST / EARLIEST Buffer Aggregator does not work on String column
URL: https://github.com/apache/druid/pull/9210
[Backport] Fix LATEST / EARLIEST Buffer Aggregator does not work on String column
### Description
The LATEST / EARLIEST Buffer Aggregator was not working on String column because of incorrectly set limit on the buffer when storing the string. The limit did not take into account the offset position of the start of position to write the string.
This PR has:
- [x] been self-reviewed.
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/licenses.yaml)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [x] added unit tests or modified existing tests to cover new code paths.
- [ ] added integration tests.
- [x] been tested in a test Druid cluster.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] maytasm3 commented on issue #9210: [Backport] Fix LATEST /
EARLIEST Buffer Aggregator does not work on String column
Posted by GitBox <gi...@apache.org>.
maytasm3 commented on issue #9210: [Backport] Fix LATEST / EARLIEST Buffer Aggregator does not work on String column
URL: https://github.com/apache/druid/pull/9210#issuecomment-575739100
Note that there is conflict in sql/src/test/java/org/apache/druid/sql/calcite/CalciteQueryTest.java
and I have to move tests around to fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis merged pull request #9210: [Backport] Fix
LATEST / EARLIEST Buffer Aggregator does not work on String column
Posted by GitBox <gi...@apache.org>.
clintropolis merged pull request #9210: [Backport] Fix LATEST / EARLIEST Buffer Aggregator does not work on String column
URL: https://github.com/apache/druid/pull/9210
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org