You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@livy.apache.org by GitBox <gi...@apache.org> on 2019/09/05 13:50:31 UTC

[GitHub] [incubator-livy] mgaido91 edited a comment on issue #195: [LIVY-634] To support reuse hive PasswdAuthenticationProvider implementation in ThriftServer

mgaido91 edited a comment on issue #195: [LIVY-634] To support reuse hive PasswdAuthenticationProvider implementation in ThriftServer
URL: https://github.com/apache/incubator-livy/pull/195#issuecomment-528373150
 
 
   > However, if we do it, it also means livy-server module will have a dependency on hive-server.jar, not sure if it's acceptable.
   
   Yes, right this is the point: it is not acceptable. The reason why we are not leveraging Hive's one is exactly this one. Also the dependency on hive.common is very dangerous and it brings in a lot of dependency. We should avoid that,
   
   > I would suggest to reuse Hive's implementation instead of rewriting by ourselves,
   
   @jerryshao please see the answer above.
   
   More discussion and details are available at https://github.com/apache/incubator-livy/pull/117.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services