You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "pandaapo (via GitHub)" <gi...@apache.org> on 2023/05/02 15:35:44 UTC
[GitHub] [eventmesh] pandaapo opened a new pull request, #3859: [ISSUE #3858]The interface RegistryService can design some default methods.
pandaapo opened a new pull request, #3859:
URL: https://github.com/apache/eventmesh/pull/3859
Fixes #3858.
### Motivation
See `Enhancement Request` in issue for detail.
### Modifications
See `Describe the solution you'd like` in issue for detail.
### Documentation
- Does this pull request introduce a new feature? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] xwm1992 merged pull request #3859: [ISSUE #3858]The interface RegistryService can design some default methods.
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 merged PR #3859:
URL: https://github.com/apache/eventmesh/pull/3859
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] codecov[bot] commented on pull request #3859: [ISSUE #3858]The interface RegistryService can design some default methods.
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3859:
URL: https://github.com/apache/eventmesh/pull/3859#issuecomment-1532475745
## [Codecov](https://app.codecov.io/gh/apache/eventmesh/pull/3859?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3859](https://app.codecov.io/gh/apache/eventmesh/pull/3859?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c53c1dd) into [master](https://app.codecov.io/gh/apache/eventmesh/commit/91aab4d4ec18b7644c45e745fc85aafd053d8fd8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (91aab4d) will **increase** coverage by `0.00%`.
> The diff coverage is `41.53%`.
> :exclamation: Current head c53c1dd differs from pull request most recent head 98510ff. Consider uploading reports for the commit 98510ff to get more accurate results
```diff
@@ Coverage Diff @@
## master #3859 +/- ##
=========================================
Coverage 13.77% 13.77%
Complexity 1290 1290
=========================================
Files 571 571
Lines 29129 29106 -23
Branches 2837 2848 +11
=========================================
- Hits 4012 4009 -3
+ Misses 24745 24719 -26
- Partials 372 378 +6
```
| [Impacted Files](https://app.codecov.io/gh/apache/eventmesh/pull/3859?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...tmesh/registry/etcd/service/EtcdCustomService.java](https://app.codecov.io/gh/apache/eventmesh/pull/3859?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJlZ2lzdHJ5LXBsdWdpbi9ldmVudG1lc2gtcmVnaXN0cnktZXRjZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL3JlZ2lzdHJ5L2V0Y2Qvc2VydmljZS9FdGNkQ3VzdG9tU2VydmljZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...registry/consul/service/ConsulRegistryService.java](https://app.codecov.io/gh/apache/eventmesh/pull/3859?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJlZ2lzdHJ5LXBsdWdpbi9ldmVudG1lc2gtcmVnaXN0cnktY29uc3VsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvcmVnaXN0cnkvY29uc3VsL3NlcnZpY2UvQ29uc3VsUmVnaXN0cnlTZXJ2aWNlLmphdmE=) | `41.79% <25.00%> (+0.61%)` | :arrow_up: |
| [...esh/registry/etcd/service/EtcdRegistryService.java](https://app.codecov.io/gh/apache/eventmesh/pull/3859?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJlZ2lzdHJ5LXBsdWdpbi9ldmVudG1lc2gtcmVnaXN0cnktZXRjZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL3JlZ2lzdHJ5L2V0Y2Qvc2VydmljZS9FdGNkUmVnaXN0cnlTZXJ2aWNlLmphdmE=) | `20.00% <30.76%> (+0.15%)` | :arrow_up: |
| [...h/registry/nacos/service/NacosRegistryService.java](https://app.codecov.io/gh/apache/eventmesh/pull/3859?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJlZ2lzdHJ5LXBsdWdpbi9ldmVudG1lc2gtcmVnaXN0cnktbmFjb3Mvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9yZWdpc3RyeS9uYWNvcy9zZXJ2aWNlL05hY29zUmVnaXN0cnlTZXJ2aWNlLmphdmE=) | `43.75% <38.09%> (+7.18%)` | :arrow_up: |
| [...ry/zookeeper/service/ZookeeperRegistryService.java](https://app.codecov.io/gh/apache/eventmesh/pull/3859?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJlZ2lzdHJ5LXBsdWdpbi9ldmVudG1lc2gtcmVnaXN0cnktem9va2VlcGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9ldmVudG1lc2gvcmVnaXN0cnkvem9va2VlcGVyL3NlcnZpY2UvWm9va2VlcGVyUmVnaXN0cnlTZXJ2aWNlLmphdmE=) | `76.15% <82.35%> (+0.34%)` | :arrow_up: |
... and [13 files with indirect coverage changes](https://app.codecov.io/gh/apache/eventmesh/pull/3859/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] pandaapo commented on pull request #3859: [ISSUE #3858]The interface RegistryService can design some default methods.
Posted by "pandaapo (via GitHub)" <gi...@apache.org>.
pandaapo commented on PR #3859:
URL: https://github.com/apache/eventmesh/pull/3859#issuecomment-1531712559
I should but do not yet delete the method `findEventMeshClientDistributionData()` and `findEventMeshServicePubTopicInfos()` in `EtcdRegistryService`. Because there has been an issue #3505 to modify these places, and its pr is still waiting for merging for 3 weeks. If I delete these two methods before, it maybe results in conflict.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] pandaapo commented on pull request #3859: [ISSUE #3858]The interface RegistryService can design some default methods.
Posted by "pandaapo (via GitHub)" <gi...@apache.org>.
pandaapo commented on PR #3859:
URL: https://github.com/apache/eventmesh/pull/3859#issuecomment-1531751194
Although issue #3833 wants to modify(not delete) `findEventMeshClientDistributionData()` and `findEventMeshServicePubTopicInfos()` in `ZookeeperRegistryService`, I delete them immediately here to satisfy issue #3858 since there is no pr linked to #3833 yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org