[GitHub] [superset] villebro commented on a change in pull request #13484: feat(native-filters): add timegrain and column filter

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #13484:
URL: https://github.com/apache/superset/pull/13484#discussion_r590133248



##########
File path: superset-frontend/spec/javascripts/filters/utils_spec.ts
##########
@@ -107,9 +107,13 @@ describe('Filter utils', () => {
       expect(getSelectExtraFormData('testCol', ['value'], true, false)).toEqual(
         {
           append_form_data: {
-            extras: {
-              where: '1 = 0',
-            },
+            adhoc_filters: [
+              {
+                clause: 'WHERE',
+                expressionType: 'SQL',
+                sqlExpression: '1 = 0',
+              },
+            ],

Review comment:
       We've now disabled appending to `extras.where` - any free text where clauses should be added as `adhoc_filters`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org