You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ambari.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2018/09/03 10:25:00 UTC

[jira] [Commented] (AMBARI-24343) [LogSearch] Wrong (error) response format

    [ https://issues.apache.org/jira/browse/AMBARI-24343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16601992#comment-16601992 ] 

Hudson commented on AMBARI-24343:
---------------------------------

SUCCESS: Integrated in Jenkins build Ambari-trunk-Commit #9910 (See [https://builds.apache.org/job/Ambari-trunk-Commit/9910/])
AMBARI-24343 - [LogSearch] Wrong (error) response format (#1962) (github: [https://gitbox.apache.org/repos/asf?p=ambari.git&a=commit&h=8ae34e9af9c3abbc311660c2ec391aa6614d4044])
* (edit) ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/LogSearchJerseyResourceConfig.java
* (delete) ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/filters/LogSearchLogLevelFilterManagerFilter.java
* (delete) ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/filters/LogsearchServiceLogsStateFilter.java
* (add) ambari-logsearch/ambari-logsearch-server/src/test/java/org/apache/ambari/logsearch/rest/error/GeneralExceptionMapperTest.java
* (edit) ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/dao/UserDao.java
* (edit) ambari-logsearch/ambari-logsearch-it/src/test/resources/stories/backend/log_search_cofig_api_tests.story
* (delete) ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/util/RESTErrorUtil.java
* (add) ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/UnsupportedFormatException.java
* (add) ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/filters/ConfigStateProvider.java
* (edit) ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchAuthenticationProvider.java
* (add) ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/filters/LogsearchFilter.java
* (edit) ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/util/DateUtil.java
* (edit) ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/dao/SolrDaoBase.java
* (add) ambari-logsearch/ambari-logsearch-server/src/test/java/org/apache/ambari/logsearch/web/filters/LogsearchFilterTest.java
* (add) ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/filters/GlobalStateProvider.java
* (add) ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/AlreadyExistsException.java
* (add) ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/rest/error/GeneralExceptionMapper.java
* (edit) ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/dao/EventHistorySolrDao.java
* (delete) ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/filters/LogsearchAuditLogsStateFilter.java
* (delete) ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/filters/LogSearchConfigStateFilter.java
* (edit) ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/util/JSONUtil.java
* (add) ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/filters/StatusProvider.java
* (add) ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/NotFoundException.java
* (add) ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/rest/error/SolrExceptionMapper.java
* (add) ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/MalformedInputException.java
* (edit) ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/EventHistoryManager.java
* (edit) ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/rest/ShipperConfigResource.java
* (edit) ambari-logsearch/ambari-logsearch-it/src/test/java/org/apache/ambari/logsearch/steps/LogSearchConfigApiSteps.java
* (add) ambari-logsearch/ambari-logsearch-server/src/test/java/org/apache/ambari/logsearch/web/filters/GlobalStateTest.java
* (delete) ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/filters/LogsearchEventHistoryStateFilter.java
* (edit) ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/AuditLogsManager.java
* (edit) ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/StatusMessage.java
* (delete) ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/common/VResponse.java
* (edit) ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/conf/SecurityConfig.java
* (delete) ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/web/filters/AbstractLogsearchGlobalStateFilter.java
* (edit) ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/ServiceLogsManager.java


> [LogSearch] Wrong (error) response format
> -----------------------------------------
>
>                 Key: AMBARI-24343
>                 URL: https://issues.apache.org/jira/browse/AMBARI-24343
>             Project: Ambari
>          Issue Type: Bug
>          Components: ambari-logsearch
>    Affects Versions: 2.7.1
>            Reporter: Krisztian Kasa
>            Assignee: Krisztian Kasa
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 2.7.2
>
>          Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> When I call the 
> {noformat}
> /shipper/input/\{clusterName}/services/\{serviceName}
> {noformat}
>  api endpoint with wrong json schema the backend responses with plain text body instead of json or empty body.
> For example:
> {code:json}
> {
>  "input": [
>  {
>  "type": "zookeeper",
>  "rowtype": "service",
>  "path": "/var/log/zookeeper/zookeeper*.log"
>  }
>  ],
>  "filter": [
>  {
>  "filter": "grok",
>  "conditions": {
>  "fieldss": {
>  "type": [
>  "zookeeper"
>  ]
>  }
>  },
>  "skipOnError": false,
>  "deepExtract": false,
>  "post_map_values": {
>  "logtime": [
>  {
>  "map_date": {
>  "target_date_pattern": "yyyy-MM-dd HH:mm:ss,SSS"
>  }
>  }
>  ]
>  },
>  "log4j_format": "%d\{ISO8601} - %-5p [%t:%C\{1}@%L] - %m%n",
>  "multiline_pattern": "^(%\{TIMESTAMP_ISO8601:logtime})",
>  "message_pattern": "(?m)^%\{TIMESTAMP_ISO8601:logtime}%\{SPACE}-%\{SPACE}%\{LOGLEVEL:level}%\{SPACE}\\[%\{DATA:thread_name}\\@%\{INT:line_number}\\]%\{SPACE}-%\{SPACE}%\{GREEDYDATA:log_message}"
>  }
>  ]
> }
> {code}
> Where the `fieldss` is not a valid JSON key.
> The response plain text body:
> {code:javascript}
> Unrecognized field "fieldss" (class org.apache.ambari.logsearch.model.common.LSServerConditions), not marked as ignorable (one known property: "fields"])
>  at [Source: UNKNOWN; line: -1, column: -1] (through reference chain: org.apache.ambari.logsearch.model.common.LSServerInputConfig["filter"]->org.apache.ambari.logsearch.model.common.LSServerFilterGrok["conditions"]->org.apache.ambari.logsearch.model.common.LSServerConditions["fieldss"])
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)