You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@geode.apache.org by Darrel Schneider <ds...@pivotal.io> on 2015/09/01 00:04:27 UTC

Re: Review Request 37765: Fix for GEODE-278

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37765/#review97162
-----------------------------------------------------------



gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/TXCommitMessage.java (line 740)
<https://reviews.apache.org/r/37765/#comment152942>

    minor optimization: new ArrayList<>(this.farSideEntryOps.size())
    
    to presize the pendingCallbacks array.


- Darrel Schneider


On Aug. 31, 2015, 2:26 p.m., Swapnil Bawaskar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37765/
> -----------------------------------------------------------
> 
> (Updated Aug. 31, 2015, 2:26 p.m.)
> 
> 
> Review request for geode and Darrel Schneider.
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> While applying changes to the Region, pass in List for gathering pendingCallbacks
> rather than a null on the remote members to get the same behavior as transaction host.
> 
> 
> Diffs
> -----
> 
>   gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/TXCommitMessage.java f091570674f874539599b669af5d87290b329b18 
>   gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/RemoteTransactionDUnitTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/37765/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Swapnil Bawaskar
> 
>