You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2021/02/08 03:59:54 UTC
[kudu-CR] [util] remove AutoReleasePool and cleanup related code
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17036
Change subject: [util] remove AutoReleasePool and cleanup related code
......................................................................
[util] remove AutoReleasePool and cleanup related code
This patch removes AuthReleasePool class and changes just two places
where it was used to store heap-allocated objects. With this patch,
objects of appropriate type are wrapped into std::unique_ptr and
stored in std::deque container. Along the way, I did other minor
code cleanup.
The motivation for this change is reducing number of memory allocations
and removing unneeded complexity in the code.
Change-Id: I8adb5d08ec37e716baf524cb6c5f52366553883c
---
M src/kudu/client/client.cc
M src/kudu/client/scan_configuration.cc
M src/kudu/client/scan_configuration.h
M src/kudu/tablet/ops/alter_schema_op.cc
M src/kudu/tablet/ops/alter_schema_op.h
M src/kudu/tablet/ops/op.cc
M src/kudu/tablet/ops/op.h
D src/kudu/util/auto_release_pool.h
8 files changed, 49 insertions(+), 146 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/36/17036/1
--
To view, visit http://gerrit.cloudera.org:8080/17036
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8adb5d08ec37e716baf524cb6c5f52366553883c
Gerrit-Change-Number: 17036
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [util] remove AutoReleasePool and cleanup related code
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17036 )
Change subject: [util] remove AutoReleasePool and cleanup related code
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17036/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/17036/1//COMMIT_MSG@9
PS1, Line 9: AuthReleasePool
nit: AutoReleasePool
--
To view, visit http://gerrit.cloudera.org:8080/17036
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8adb5d08ec37e716baf524cb6c5f52366553883c
Gerrit-Change-Number: 17036
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 08 Feb 2021 22:54:28 +0000
Gerrit-HasComments: Yes
[kudu-CR] [util] remove AutoReleasePool and cleanup related code
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17036 )
Change subject: [util] remove AutoReleasePool and cleanup related code
......................................................................
[util] remove AutoReleasePool and cleanup related code
This patch removes AutoReleasePool class and changes just two places
where it was used to store heap-allocated objects. With this patch,
objects of appropriate type are wrapped into std::unique_ptr and
stored in std::deque container. Along the way, I did other minor
code cleanup.
The motivation for this change is reducing number of memory allocations
and removing unneeded complexity in the code.
Change-Id: I8adb5d08ec37e716baf524cb6c5f52366553883c
Reviewed-on: http://gerrit.cloudera.org:8080/17036
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Hao Hao <ha...@cloudera.com>
---
M src/kudu/client/client.cc
M src/kudu/client/scan_configuration.cc
M src/kudu/client/scan_configuration.h
M src/kudu/tablet/ops/alter_schema_op.cc
M src/kudu/tablet/ops/alter_schema_op.h
M src/kudu/tablet/ops/op.cc
M src/kudu/tablet/ops/op.h
D src/kudu/util/auto_release_pool.h
8 files changed, 49 insertions(+), 146 deletions(-)
Approvals:
Alexey Serbin: Verified
Hao Hao: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/17036
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I8adb5d08ec37e716baf524cb6c5f52366553883c
Gerrit-Change-Number: 17036
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [util] remove AutoReleasePool and cleanup related code
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17036 )
Change subject: [util] remove AutoReleasePool and cleanup related code
......................................................................
Patch Set 2:
> Patch Set 2: Code-Review+2
Thank you for the review!
--
To view, visit http://gerrit.cloudera.org:8080/17036
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8adb5d08ec37e716baf524cb6c5f52366553883c
Gerrit-Change-Number: 17036
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 09 Feb 2021 05:01:35 +0000
Gerrit-HasComments: No
[kudu-CR] [util] remove AutoReleasePool and cleanup related code
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [util] remove AutoReleasePool and cleanup related code
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/17036
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I8adb5d08ec37e716baf524cb6c5f52366553883c
Gerrit-Change-Number: 17036
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [util] remove AutoReleasePool and cleanup related code
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong, Hao Hao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17036
to look at the new patch set (#2).
Change subject: [util] remove AutoReleasePool and cleanup related code
......................................................................
[util] remove AutoReleasePool and cleanup related code
This patch removes AutoReleasePool class and changes just two places
where it was used to store heap-allocated objects. With this patch,
objects of appropriate type are wrapped into std::unique_ptr and
stored in std::deque container. Along the way, I did other minor
code cleanup.
The motivation for this change is reducing number of memory allocations
and removing unneeded complexity in the code.
Change-Id: I8adb5d08ec37e716baf524cb6c5f52366553883c
---
M src/kudu/client/client.cc
M src/kudu/client/scan_configuration.cc
M src/kudu/client/scan_configuration.h
M src/kudu/tablet/ops/alter_schema_op.cc
M src/kudu/tablet/ops/alter_schema_op.h
M src/kudu/tablet/ops/op.cc
M src/kudu/tablet/ops/op.h
D src/kudu/util/auto_release_pool.h
8 files changed, 49 insertions(+), 146 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/36/17036/2
--
To view, visit http://gerrit.cloudera.org:8080/17036
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8adb5d08ec37e716baf524cb6c5f52366553883c
Gerrit-Change-Number: 17036
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [util] remove AutoReleasePool and cleanup related code
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17036 )
Change subject: [util] remove AutoReleasePool and cleanup related code
......................................................................
Patch Set 2: Verified+1
unrelated test failure in org.apache.kudu.client.TestMultipleLeaderFailover
--
To view, visit http://gerrit.cloudera.org:8080/17036
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8adb5d08ec37e716baf524cb6c5f52366553883c
Gerrit-Change-Number: 17036
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 09 Feb 2021 00:58:07 +0000
Gerrit-HasComments: No
[kudu-CR] [util] remove AutoReleasePool and cleanup related code
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17036 )
Change subject: [util] remove AutoReleasePool and cleanup related code
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17036
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8adb5d08ec37e716baf524cb6c5f52366553883c
Gerrit-Change-Number: 17036
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 09 Feb 2021 04:38:18 +0000
Gerrit-HasComments: No
[kudu-CR] [util] remove AutoReleasePool and cleanup related code
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17036 )
Change subject: [util] remove AutoReleasePool and cleanup related code
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17036/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/17036/1//COMMIT_MSG@9
PS1, Line 9: AuthReleasePool
> nit: AutoReleasePool
Done
--
To view, visit http://gerrit.cloudera.org:8080/17036
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8adb5d08ec37e716baf524cb6c5f52366553883c
Gerrit-Change-Number: 17036
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 09 Feb 2021 00:01:10 +0000
Gerrit-HasComments: Yes