You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/03/05 22:09:46 UTC
[GitHub] [spark] vanzin commented on a change in pull request #23939:
[SPARK-27019] [SQL][WEBUI]onJobStart happens after onExecutionEnd shouldn't
overwrite kvstore
vanzin commented on a change in pull request #23939: [SPARK-27019] [SQL][WEBUI]onJobStart happens after onExecutionEnd shouldn't overwrite kvstore
URL: https://github.com/apache/spark/pull/23939#discussion_r262712214
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SQLAppStatusListener.scala
##########
@@ -311,6 +336,8 @@ class SQLAppStatusListener(
val now = System.nanoTime()
if (exec.endEvents >= exec.jobs.size + 1) {
exec.write(kvstore, now)
+ // remove live data corresponding to the exec, once all the events finished.
Review comment:
Redundant comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org