You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by su...@apache.org on 2021/05/11 18:40:08 UTC
[superset] branch master updated: fix: Menu does not appear on
scroll in Dashboard (#14566)
This is an automated email from the ASF dual-hosted git repository.
suddjian pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new b960843 fix: Menu does not appear on scroll in Dashboard (#14566)
b960843 is described below
commit b960843015096ada1527fcea3dfeaf337907363e
Author: Geido <60...@users.noreply.github.com>
AuthorDate: Tue May 11 21:38:58 2021 +0300
fix: Menu does not appear on scroll in Dashboard (#14566)
* Fix menu
* Fix test
---
.../Header/HeaderActionsDropdown/HeaderActionsDropdown.test.tsx | 2 +-
.../src/dashboard/components/Header/HeaderActionsDropdown/index.jsx | 2 +-
superset-frontend/stylesheets/superset.less | 4 ----
3 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/superset-frontend/src/dashboard/components/Header/HeaderActionsDropdown/HeaderActionsDropdown.test.tsx b/superset-frontend/src/dashboard/components/Header/HeaderActionsDropdown/HeaderActionsDropdown.test.tsx
index 039c1ef..a5f7bab 100644
--- a/superset-frontend/src/dashboard/components/Header/HeaderActionsDropdown/HeaderActionsDropdown.test.tsx
+++ b/superset-frontend/src/dashboard/components/Header/HeaderActionsDropdown/HeaderActionsDropdown.test.tsx
@@ -65,7 +65,7 @@ const editModeOnProps = {
function setup(props: HeaderDropdownProps) {
return (
- <div className="dashboard">
+ <div className="dashboard-header">
<HeaderActionsDropdown {...props} />
</div>
);
diff --git a/superset-frontend/src/dashboard/components/Header/HeaderActionsDropdown/index.jsx b/superset-frontend/src/dashboard/components/Header/HeaderActionsDropdown/index.jsx
index 607fcdf..9b9aefe 100644
--- a/superset-frontend/src/dashboard/components/Header/HeaderActionsDropdown/index.jsx
+++ b/superset-frontend/src/dashboard/components/Header/HeaderActionsDropdown/index.jsx
@@ -317,7 +317,7 @@ class HeaderActionsDropdown extends React.PureComponent {
overlay={menu}
trigger={['click']}
getPopupContainer={triggerNode =>
- triggerNode.closest(SCREENSHOT_NODE_SELECTOR)
+ triggerNode.closest('.dashboard-header')
}
>
<DropdownButton id="save-dash-split-button" role="button">
diff --git a/superset-frontend/stylesheets/superset.less b/superset-frontend/stylesheets/superset.less
index 4c5cc22..477b8c1 100644
--- a/superset-frontend/stylesheets/superset.less
+++ b/superset-frontend/stylesheets/superset.less
@@ -603,7 +603,3 @@ hr {
top: 269px !important;
}
}
-
-.ant-dropdown.ant-dropdown-placement-bottomRight {
- top: 133px !important;
-}