You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2020/09/15 08:41:10 UTC

[GitHub] [zeppelin] Reamer opened a new pull request #3909: [ZEPPELIN-4612] Refactoring some viewed classes

Reamer opened a new pull request #3909:
URL: https://github.com/apache/zeppelin/pull/3909


   ### What is this PR for?
   During development, I came across code that did not conform to current best practices.
   For example:
     - Logging 
       - [Anti-Pattern-1](https://rolf-engelhard.de/2013/03/logging-anti-patterns-part-i/), [Anti-Pattern-2](https://rolf-engelhard.de/2013/04/logging-anti-patterns-part-ii/), [Anti-Pattern-3](https://rolf-engelhard.de/2013/10/logging-anti-patterns-part-iii/)
     - [try-with-resources](https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html)
   
   ### What type of PR is it?
   Refactoring
   
   ### What is the Jira issue?
   * https://issues.apache.org/jira/browse/ZEPPELIN-4612
   
   ### How should this be tested?
   * Travis CI: https://travis-ci.org/github/Reamer/zeppelin/builds/727295209
   
   ### Questions:
   * Does the licenses files need update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] asfgit closed pull request #3909: [ZEPPELIN-5044] Refactoring some viewed classes

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3909:
URL: https://github.com/apache/zeppelin/pull/3909


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] zjffdu commented on pull request #3909: [ZEPPELIN-4612] Refactoring some viewed classes

Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #3909:
URL: https://github.com/apache/zeppelin/pull/3909#issuecomment-692751387


   @Reamer The jira is not correct: ZEPPELIN-4612


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] Reamer commented on pull request #3909: [ZEPPELIN-4612] Refactoring some viewed classes

Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #3909:
URL: https://github.com/apache/zeppelin/pull/3909#issuecomment-692767439


   > @Reamer The jira is not correct: [ZEPPELIN-4612](https://issues.apache.org/jira/browse/ZEPPELIN-4612)
   
   Thanks, I have corrected to the correct Jira ticket. [ZEPPELIN-5044](https://issues.apache.org/jira/browse/ZEPPELIN-5044)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] zjffdu commented on pull request #3909: [ZEPPELIN-4612] Refactoring some viewed classes

Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #3909:
URL: https://github.com/apache/zeppelin/pull/3909#issuecomment-692748443


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] Reamer commented on pull request #3909: [ZEPPELIN-4612] Refactoring some viewed classes

Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #3909:
URL: https://github.com/apache/zeppelin/pull/3909#issuecomment-692741093


   I will merge this on Thursday into master and branch-0.9, if there are no further comments.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org