You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by ye...@apache.org on 2009/04/11 16:15:32 UTC
svn commit: r764203 - in /poi/trunk/src:
contrib/src/org/apache/poi/hssf/contrib/view/ java/org/apache/poi/hssf/
java/org/apache/poi/hssf/dev/ java/org/apache/poi/hssf/extractor/
java/org/apache/poi/hssf/model/ java/org/apache/poi/hssf/record/ java/org...
Author: yegor
Date: Sat Apr 11 14:15:27 2009
New Revision: 764203
URL: http://svn.apache.org/viewvc?rev=764203&view=rev
Log:
removed unused imports of deprecated classes, fixed javadoc errors
Modified:
poi/trunk/src/contrib/src/org/apache/poi/hssf/contrib/view/SVTableModel.java
poi/trunk/src/java/org/apache/poi/hssf/dev/HSSF.java
poi/trunk/src/java/org/apache/poi/hssf/extractor/EventBasedExcelExtractor.java
poi/trunk/src/java/org/apache/poi/hssf/extractor/ExcelExtractor.java
poi/trunk/src/java/org/apache/poi/hssf/model/Workbook.java
poi/trunk/src/java/org/apache/poi/hssf/package.html
poi/trunk/src/java/org/apache/poi/hssf/record/CFRuleRecord.java
poi/trunk/src/java/org/apache/poi/hssf/record/DVALRecord.java
poi/trunk/src/java/org/apache/poi/hssf/record/ExtSSTRecord.java
poi/trunk/src/java/org/apache/poi/hssf/record/RecordBase.java
poi/trunk/src/java/org/apache/poi/hssf/record/StandardRecord.java
poi/trunk/src/java/org/apache/poi/ss/formula/eval/forked/ForkedEvaluator.java
poi/trunk/src/ooxml/java/org/apache/poi/POIXMLDocument.java
poi/trunk/src/ooxml/java/org/apache/poi/POIXMLDocumentPart.java
poi/trunk/src/ooxml/java/org/apache/poi/openxml4j/opc/Package.java
poi/trunk/src/ooxml/java/org/apache/poi/xwpf/usermodel/XWPFParagraph.java
poi/trunk/src/ooxml/java/org/apache/poi/xwpf/usermodel/XWPFRun.java
poi/trunk/src/scratchpad/src/org/apache/poi/hslf/model/Shape.java
poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/model/PicturesTable.java
poi/trunk/src/scratchpad/testcases/org/apache/poi/hslf/model/TestOleEmbedding.java
poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestFormulas.java
poi/trunk/src/testcases/org/apache/poi/hssf/util/TestAreaReference.java
poi/trunk/src/testcases/org/apache/poi/ss/formula/FormulaParserTestHelper.java
Modified: poi/trunk/src/contrib/src/org/apache/poi/hssf/contrib/view/SVTableModel.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/contrib/src/org/apache/poi/hssf/contrib/view/SVTableModel.java?rev=764203&r1=764202&r2=764203&view=diff
==============================================================================
--- poi/trunk/src/contrib/src/org/apache/poi/hssf/contrib/view/SVTableModel.java (original)
+++ poi/trunk/src/contrib/src/org/apache/poi/hssf/contrib/view/SVTableModel.java Sat Apr 11 14:15:27 2009
@@ -61,7 +61,7 @@
HSSFRow r = st.getRow(row);
HSSFCell c = null;
if (r != null) {
- c = r.getCell((short)col);
+ c = r.getCell(col);
}
return c;
}
Modified: poi/trunk/src/java/org/apache/poi/hssf/dev/HSSF.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/hssf/dev/HSSF.java?rev=764203&r1=764202&r2=764203&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/hssf/dev/HSSF.java (original)
+++ poi/trunk/src/java/org/apache/poi/hssf/dev/HSSF.java Sat Apr 11 14:15:27 2009
@@ -31,7 +31,6 @@
import org.apache.poi.hssf.usermodel.HSSFWorkbook;
import org.apache.poi.ss.util.CellRangeAddress;
import org.apache.poi.poifs.filesystem.POIFSFileSystem;
-import org.apache.poi.ss.util.Region;
/**
* File for HSSF testing/examples
Modified: poi/trunk/src/java/org/apache/poi/hssf/extractor/EventBasedExcelExtractor.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/hssf/extractor/EventBasedExcelExtractor.java?rev=764203&r1=764202&r2=764203&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/hssf/extractor/EventBasedExcelExtractor.java (original)
+++ poi/trunk/src/java/org/apache/poi/hssf/extractor/EventBasedExcelExtractor.java Sat Apr 11 14:15:27 2009
@@ -57,9 +57,12 @@
* Returns the textual content of the file, suitable for
* indexing by something like Lucene, but not really
* intended for display to the user.
+ * <p>
* To turn an excel file into a CSV or similar, then see
* the XLS2CSVmra example
- * @see org.apache.poi.hssf.eventusermodel.examples.XLS2CSVmra
+ * </p>
+ * <link href="http://svn.apache.org/repos/asf/poi/trunk/src/examples/src/org/apache/poi/hssf/eventusermodel/examples/XLS2CSVmra.java">
+ * http://svn.apache.org/repos/asf/poi/trunk/src/examples/src/org/apache/poi/hssf/eventusermodel/examples/XLS2CSVmra.java</link>
*/
public class EventBasedExcelExtractor extends POIOLE2TextExtractor {
private POIFSFileSystem fs;
Modified: poi/trunk/src/java/org/apache/poi/hssf/extractor/ExcelExtractor.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/hssf/extractor/ExcelExtractor.java?rev=764203&r1=764202&r2=764203&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/hssf/extractor/ExcelExtractor.java (original)
+++ poi/trunk/src/java/org/apache/poi/hssf/extractor/ExcelExtractor.java Sat Apr 11 14:15:27 2009
@@ -37,12 +37,17 @@
/**
* A text extractor for Excel files.
+ * <p>
* Returns the textual content of the file, suitable for
* indexing by something like Lucene, but not really
* intended for display to the user.
+ * </p>
+ * <p>
* To turn an excel file into a CSV or similar, then see
* the XLS2CSVmra example
- * @see org.apache.poi.hssf.eventusermodel.examples.XLS2CSVmra
+ * </p>
+ * <link href="http://svn.apache.org/repos/asf/poi/trunk/src/examples/src/org/apache/poi/hssf/eventusermodel/examples/XLS2CSVmra.java">
+ * http://svn.apache.org/repos/asf/poi/trunk/src/examples/src/org/apache/poi/hssf/eventusermodel/examples/XLS2CSVmra.java</link>
*/
public class ExcelExtractor extends POIOLE2TextExtractor implements org.apache.poi.ss.extractor.ExcelExtractor {
private HSSFWorkbook _wb;
Modified: poi/trunk/src/java/org/apache/poi/hssf/model/Workbook.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/hssf/model/Workbook.java?rev=764203&r1=764202&r2=764203&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/hssf/model/Workbook.java (original)
+++ poi/trunk/src/java/org/apache/poi/hssf/model/Workbook.java Sat Apr 11 14:15:27 2009
@@ -912,7 +912,7 @@
/**
* use this function to add a Shared String Table to an existing sheet (say
* generated by a different java api) without an sst....
- * @see #createSST()
+ * @see #createExtendedSST()
* @see org.apache.poi.hssf.record.SSTRecord
*/
Modified: poi/trunk/src/java/org/apache/poi/hssf/package.html
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/hssf/package.html?rev=764203&r1=764202&r2=764203&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/hssf/package.html (original)
+++ poi/trunk/src/java/org/apache/poi/hssf/package.html Sat Apr 11 14:15:27 2009
@@ -31,8 +31,5 @@
<li><a href="http://poi.apache.org">Apache POI Project</a>
</ul>
-<!-- Put @see and @since tags down here. -->
-@see org.apache.poi.poifs
-@see org.apache.poi.hpsf
</body>
</html>
Modified: poi/trunk/src/java/org/apache/poi/hssf/record/CFRuleRecord.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/hssf/record/CFRuleRecord.java?rev=764203&r1=764202&r2=764203&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/hssf/record/CFRuleRecord.java (original)
+++ poi/trunk/src/java/org/apache/poi/hssf/record/CFRuleRecord.java Sat Apr 11 14:15:27 2009
@@ -438,9 +438,7 @@
* Subclasses should implement this so that their data is passed back in a
* byte array.
*
- * @param pOffset to begin writing at
- * @param data byte array containing instance data
- * @return number of bytes written
+ * @param out the stream to write to
*/
public void serialize(LittleEndianOutput out) {
Modified: poi/trunk/src/java/org/apache/poi/hssf/record/DVALRecord.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/hssf/record/DVALRecord.java?rev=764203&r1=764202&r2=764203&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/hssf/record/DVALRecord.java (original)
+++ poi/trunk/src/java/org/apache/poi/hssf/record/DVALRecord.java Sat Apr 11 14:15:27 2009
@@ -57,21 +57,21 @@
}
/**
- * @param field_1_options the options of the dialog
+ * @param options the options of the dialog
*/
public void setOptions(short options) {
field_1_options = options;
}
/**
- * @param field_2_horiz_pos the Horizontal position of the dialog
+ * @param horiz_pos the Horizontal position of the dialog
*/
public void setHorizontalPos(int horiz_pos) {
field_2_horiz_pos = horiz_pos;
}
/**
- * @param field_3_vert_pos the Vertical position of the dialog
+ * @param vert_pos the Vertical position of the dialog
*/
public void setVerticalPos(int vert_pos) {
field_3_vert_pos = vert_pos;
Modified: poi/trunk/src/java/org/apache/poi/hssf/record/ExtSSTRecord.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/hssf/record/ExtSSTRecord.java?rev=764203&r1=764202&r2=764203&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/hssf/record/ExtSSTRecord.java (original)
+++ poi/trunk/src/java/org/apache/poi/hssf/record/ExtSSTRecord.java Sat Apr 11 14:15:27 2009
@@ -28,8 +28,6 @@
* REFERENCE: PG 313 Microsoft Excel 97 Developer's Kit (ISBN: 1-57231-498-2)<P>
* @author Andrew C. Oliver (acoliver at apache dot org)
* @author Jason Height (jheight at apache dot org)
- *
- * @see org.apache.poi.hssf.record.ExtSSTInfoSubRecord
*/
public final class ExtSSTRecord extends StandardRecord {
public final static short sid = 0x00FF;
Modified: poi/trunk/src/java/org/apache/poi/hssf/record/RecordBase.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/hssf/record/RecordBase.java?rev=764203&r1=764202&r2=764203&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/hssf/record/RecordBase.java (original)
+++ poi/trunk/src/java/org/apache/poi/hssf/record/RecordBase.java Sat Apr 11 14:15:27 2009
@@ -18,7 +18,7 @@
package org.apache.poi.hssf.record;
/**
- * Common base class of {@link Record} and {@link RecordAggregate}
+ * Common base class of {@link Record} and {@link org.apache.poi.hssf.record.aggregates.RecordAggregate}
*
* @author Josh Micich
*/
Modified: poi/trunk/src/java/org/apache/poi/hssf/record/StandardRecord.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/hssf/record/StandardRecord.java?rev=764203&r1=764202&r2=764203&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/hssf/record/StandardRecord.java (original)
+++ poi/trunk/src/java/org/apache/poi/hssf/record/StandardRecord.java Sat Apr 11 14:15:27 2009
@@ -51,7 +51,7 @@
* Write the data content of this BIFF record. The 'ushort sid' and 'ushort size' header fields
* have already been written by the superclass.<br/>
*
- * The subclass must write the exact number of bytes as reported by {@link Record#getDataSize()}
+ * The subclass must write the exact number of bytes as reported by {@link org.apache.poi.hssf.record.Record#getRecordSize()}}
*/
protected abstract void serialize(LittleEndianOutput out);
}
Modified: poi/trunk/src/java/org/apache/poi/ss/formula/eval/forked/ForkedEvaluator.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/java/org/apache/poi/ss/formula/eval/forked/ForkedEvaluator.java?rev=764203&r1=764202&r2=764203&view=diff
==============================================================================
--- poi/trunk/src/java/org/apache/poi/ss/formula/eval/forked/ForkedEvaluator.java (original)
+++ poi/trunk/src/java/org/apache/poi/ss/formula/eval/forked/ForkedEvaluator.java Sat Apr 11 14:15:27 2009
@@ -35,7 +35,7 @@
/**
* An alternative workbook evaluator that saves memory in situations where a single workbook is
* concurrently and independently evaluated many times. With standard formula evaluation, around
- * 90% of memory consumption is due to loading of the {@link HSSFWorkbook} or {@link XSSFWorkbook}.
+ * 90% of memory consumption is due to loading of the {@link HSSFWorkbook} or {@link org.apache.poi.xssf.usermodel.XSSFWorkbook}.
* This class enables a 'master workbook' to be loaded just once and shared between many evaluation
* clients. Each evaluation client creates its own {@link ForkedEvaluator} and can set cell values
* that will be used for local evaluations (and don't disturb evaluations on other evaluators).
Modified: poi/trunk/src/ooxml/java/org/apache/poi/POIXMLDocument.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/POIXMLDocument.java?rev=764203&r1=764202&r2=764203&view=diff
==============================================================================
--- poi/trunk/src/ooxml/java/org/apache/poi/POIXMLDocument.java (original)
+++ poi/trunk/src/ooxml/java/org/apache/poi/POIXMLDocument.java Sat Apr 11 14:15:27 2009
@@ -26,7 +26,6 @@
import org.apache.poi.openxml4j.exceptions.InvalidFormatException;
import org.apache.poi.openxml4j.exceptions.OpenXML4JException;
import org.apache.poi.openxml4j.opc.*;
-import org.apache.poi.openxml4j.opc.Package;
public abstract class POIXMLDocument extends POIXMLDocumentPart{
Modified: poi/trunk/src/ooxml/java/org/apache/poi/POIXMLDocumentPart.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/POIXMLDocumentPart.java?rev=764203&r1=764202&r2=764203&view=diff
==============================================================================
--- poi/trunk/src/ooxml/java/org/apache/poi/POIXMLDocumentPart.java (original)
+++ poi/trunk/src/ooxml/java/org/apache/poi/POIXMLDocumentPart.java Sat Apr 11 14:15:27 2009
@@ -25,7 +25,6 @@
import org.apache.poi.util.POILogFactory;
import org.apache.poi.openxml4j.exceptions.OpenXML4JException;
import org.apache.poi.openxml4j.opc.*;
-import org.apache.poi.openxml4j.opc.Package;
/**
* Represents an entry of a OOXML package.
Modified: poi/trunk/src/ooxml/java/org/apache/poi/openxml4j/opc/Package.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/openxml4j/opc/Package.java?rev=764203&r1=764202&r2=764203&view=diff
==============================================================================
--- poi/trunk/src/ooxml/java/org/apache/poi/openxml4j/opc/Package.java (original)
+++ poi/trunk/src/ooxml/java/org/apache/poi/openxml4j/opc/Package.java Sat Apr 11 14:15:27 2009
@@ -90,7 +90,7 @@
}
/**
- * @deprecated use {@link OPCPackage#open(File)}
+ * @deprecated use {@link OPCPackage#openOrCreate(java.io.File)}
*/
public static Package openOrCreate(File file) throws InvalidFormatException {
Package retPackage = null;
Modified: poi/trunk/src/ooxml/java/org/apache/poi/xwpf/usermodel/XWPFParagraph.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xwpf/usermodel/XWPFParagraph.java?rev=764203&r1=764202&r2=764203&view=diff
==============================================================================
--- poi/trunk/src/ooxml/java/org/apache/poi/xwpf/usermodel/XWPFParagraph.java (original)
+++ poi/trunk/src/ooxml/java/org/apache/poi/xwpf/usermodel/XWPFParagraph.java Sat Apr 11 14:15:27 2009
@@ -640,7 +640,7 @@
* paragraph in the document in absolute units.
*
* @return bigInteger - value representing the spacing after the paragraph
- * @see #setSpacingAfterLines(BigInteger)
+ * @see #setSpacingAfterLines(int)
*/
public int getSpacingAfterLines() {
CTSpacing spacing = getCTSpacing(false);
@@ -669,7 +669,7 @@
* paragraph in the document in absolute units.
*
* @return the spacing that should be added above the first line
- * @see #setSpacingBefore(BigInteger)
+ * @see #setSpacingBefore(int)
*/
public int getSpacingBefore() {
CTSpacing spacing = getCTSpacing(false);
@@ -700,7 +700,7 @@
* The value of this attribute is specified in one hundredths of a line.
*
* @return the spacing that should be added before the first line in this paragraph
- * @see #setSpacingBeforeLines(BigInteger)
+ * @see #setSpacingBeforeLines(int)
*/
public int getSpacingBeforeLines() {
CTSpacing spacing = getCTSpacing(false);
Modified: poi/trunk/src/ooxml/java/org/apache/poi/xwpf/usermodel/XWPFRun.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xwpf/usermodel/XWPFRun.java?rev=764203&r1=764202&r2=764203&view=diff
==============================================================================
--- poi/trunk/src/ooxml/java/org/apache/poi/xwpf/usermodel/XWPFRun.java (original)
+++ poi/trunk/src/ooxml/java/org/apache/poi/xwpf/usermodel/XWPFRun.java Sat Apr 11 14:15:27 2009
@@ -407,7 +407,7 @@
* A break is a special character which is used to override the
* normal line breaking that would be performed based on the normal layout
* of the document's contents.
- * @see addCarriageReturn()
+ * @see #addCarriageReturn()
*/
public void addBreak() {
run.addNewBr();
Modified: poi/trunk/src/scratchpad/src/org/apache/poi/hslf/model/Shape.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/src/org/apache/poi/hslf/model/Shape.java?rev=764203&r1=764202&r2=764203&view=diff
==============================================================================
--- poi/trunk/src/scratchpad/src/org/apache/poi/hslf/model/Shape.java (original)
+++ poi/trunk/src/scratchpad/src/org/apache/poi/hslf/model/Shape.java Sat Apr 11 14:15:27 2009
@@ -34,7 +34,7 @@
* </p>
* <p>
* When you add a shape, you usually specify the dimensions of the shape and the position
- * of the upper�left corner of the bounding box for the shape relative to the upper�left
+ * of the upper'left corner of the bounding box for the shape relative to the upper'left
* corner of the page, worksheet, or slide. Distances in the drawing layer are measured
* in points (72 points = 1 inch).
* </p>
Modified: poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/model/PicturesTable.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/model/PicturesTable.java?rev=764203&r1=764202&r2=764203&view=diff
==============================================================================
--- poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/model/PicturesTable.java (original)
+++ poi/trunk/src/scratchpad/src/org/apache/poi/hwpf/model/PicturesTable.java Sat Apr 11 14:15:27 2009
@@ -35,8 +35,8 @@
/**
* Holds information about all pictures embedded in Word Document either via "Insert -> Picture -> From File" or via
- * clipboard. Responsible for images extraction and determining whether some document�s piece contains embedded image.
- * Analyzes raw data bytestream �Data� (where Word stores all embedded objects) provided by HWPFDocument.
+ * clipboard. Responsible for images extraction and determining whether some document's piece contains embedded image.
+ * Analyzes raw data bytestream 'Data' (where Word stores all embedded objects) provided by HWPFDocument.
*
* Word stores images as is within so called "Data stream" - the stream within a Word docfile containing various data
* that hang off of characters in the main stream. For example, binary data describing in-line pictures and/or
Modified: poi/trunk/src/scratchpad/testcases/org/apache/poi/hslf/model/TestOleEmbedding.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/scratchpad/testcases/org/apache/poi/hslf/model/TestOleEmbedding.java?rev=764203&r1=764202&r2=764203&view=diff
==============================================================================
--- poi/trunk/src/scratchpad/testcases/org/apache/poi/hslf/model/TestOleEmbedding.java (original)
+++ poi/trunk/src/scratchpad/testcases/org/apache/poi/hslf/model/TestOleEmbedding.java Sat Apr 11 14:15:27 2009
@@ -73,11 +73,11 @@
HSSFWorkbook wb = new HSSFWorkbook(data.getData());
HSSFSheet sheet = wb.getSheetAt(0);
//verify we can access the xls data
- assertEquals(1, sheet.getRow(0).getCell((short)0).getNumericCellValue(), 0);
- assertEquals(1, sheet.getRow(1).getCell((short)0).getNumericCellValue(), 0);
- assertEquals(2, sheet.getRow(2).getCell((short)0).getNumericCellValue(), 0);
- assertEquals(3, sheet.getRow(3).getCell((short)0).getNumericCellValue(), 0);
- assertEquals(8, sheet.getRow(5).getCell((short)0).getNumericCellValue(), 0);
+ assertEquals(1, sheet.getRow(0).getCell(0).getNumericCellValue(), 0);
+ assertEquals(1, sheet.getRow(1).getCell(0).getNumericCellValue(), 0);
+ assertEquals(2, sheet.getRow(2).getCell(0).getNumericCellValue(), 0);
+ assertEquals(3, sheet.getRow(3).getCell(0).getNumericCellValue(), 0);
+ assertEquals(8, sheet.getRow(5).getCell(0).getNumericCellValue(), 0);
} else if ("Document".equals(ole.getInstanceName())){
//creating a HWPF document
HWPFDocument doc = new HWPFDocument(data.getData());
Modified: poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestFormulas.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestFormulas.java?rev=764203&r1=764202&r2=764203&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestFormulas.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/usermodel/TestFormulas.java Sat Apr 11 14:15:27 2009
@@ -859,7 +859,7 @@
public void test27272_1() throws Exception {
HSSFWorkbook wb = openSample("27272_1.xls");
wb.getSheetAt(0);
- assertEquals("Reference for named range ", "Compliance!#REF!",wb.getNameAt(0).getReference());
+ assertEquals("Reference for named range ", "Compliance!#REF!",wb.getNameAt(0).getRefersToFormula());
File outF = File.createTempFile("bug27272_1",".xls");
wb.write(new FileOutputStream(outF));
System.out.println("Open "+outF.getAbsolutePath()+" in Excel");
@@ -867,7 +867,7 @@
/** Unknown Ptg 3D*/
public void test27272_2() throws Exception {
HSSFWorkbook wb = openSample("27272_2.xls");
- assertEquals("Reference for named range ", "LOAD.POD_HISTORIES!#REF!",wb.getNameAt(0).getReference());
+ assertEquals("Reference for named range ", "LOAD.POD_HISTORIES!#REF!",wb.getNameAt(0).getRefersToFormula());
File outF = File.createTempFile("bug27272_2",".xls");
wb.write(new FileOutputStream(outF));
System.out.println("Open "+outF.getAbsolutePath()+" in Excel");
Modified: poi/trunk/src/testcases/org/apache/poi/hssf/util/TestAreaReference.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/hssf/util/TestAreaReference.java?rev=764203&r1=764202&r2=764203&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/hssf/util/TestAreaReference.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/hssf/util/TestAreaReference.java Sat Apr 11 14:15:27 2009
@@ -230,11 +230,11 @@
HSSFName aNamedCell = wb.getNameAt(idx);
// Should have 2 references
- assertEquals(ref, aNamedCell.getReference());
+ assertEquals(ref, aNamedCell.getRefersToFormula());
// Check the parsing of the reference into cells
- assertFalse(AreaReference.isContiguous(aNamedCell.getReference()));
- AreaReference[] arefs = AreaReference.generateContiguous(aNamedCell.getReference());
+ assertFalse(AreaReference.isContiguous(aNamedCell.getRefersToFormula()));
+ AreaReference[] arefs = AreaReference.generateContiguous(aNamedCell.getRefersToFormula());
assertEquals(2, arefs.length);
assertEquals(refA, arefs[0].formatAsString());
assertEquals(refB, arefs[1].formatAsString());
Modified: poi/trunk/src/testcases/org/apache/poi/ss/formula/FormulaParserTestHelper.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/testcases/org/apache/poi/ss/formula/FormulaParserTestHelper.java?rev=764203&r1=764202&r2=764203&view=diff
==============================================================================
--- poi/trunk/src/testcases/org/apache/poi/ss/formula/FormulaParserTestHelper.java (original)
+++ poi/trunk/src/testcases/org/apache/poi/ss/formula/FormulaParserTestHelper.java Sat Apr 11 14:15:27 2009
@@ -23,7 +23,7 @@
import org.apache.poi.ss.formula.FormulaParser;
import org.apache.poi.ss.formula.FormulaParser.FormulaParseException;
/**
- * Avoids making {@link FormulaParser#FormulaParseException} public
+ * Avoids making {@link FormulaParseException} public
*
* @author Josh Micich
*/
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org