You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/07/27 14:41:09 UTC
[GitHub] [incubator-kyuubi] turboFei commented on a change in pull request #857: Support init SQL for each session
turboFei commented on a change in pull request #857:
URL: https://github.com/apache/incubator-kyuubi/pull/857#discussion_r677518258
##########
File path: kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala
##########
@@ -608,11 +608,21 @@ object KyuubiConf {
val ENGINE_INITIALIZE_SQL: ConfigEntry[String] = buildConf("engine.initialize.sql")
.doc("SemiColon-separated list of SQL statements to be initialized in the newly created " +
- "engine before queries.")
+ "engine before queries. This configuration can not be used in JDBC url due to " +
+ "the limitation of Beeline/JDBC driver.")
.version("1.2.0")
.stringConf
.createWithDefault("SHOW DATABASES")
+ val ENGINE_SESSION_INITIALIZE_SQL: ConfigEntry[String] =
+ buildConf("engine.session.initialize.sql")
+ .doc("SemiColon-separated list of SQL statements to be initialized in the newly created " +
+ "engine session before queries. This configuration can not be used in JDBC url due to " +
+ "the limitation of Beeline/JDBC driver.")
+ .version("1.3.0")
+ .stringConf
+ .createWithDefault("SHOW DATABASES")
Review comment:
should we use `.fallbackConf(ENGINE_INITIALIZE_SQL)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org