You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/04/09 01:45:12 UTC
[GitHub] [incubator-tvm] anijain2305 opened a new pull request #5286:
[Requantize] Cleanup and Optimize Lowering
anijain2305 opened a new pull request #5286: [Requantize] Cleanup and Optimize Lowering
URL: https://github.com/apache/incubator-tvm/pull/5286
TBD
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] anijain2305 commented on issue #5286: [Requantize]
Cleanup and Optimize Lowering
Posted by GitBox <gi...@apache.org>.
anijain2305 commented on issue #5286: [Requantize] Cleanup and Optimize Lowering
URL: https://github.com/apache/incubator-tvm/pull/5286#issuecomment-612106078
@yzhliu @vinx13 Please review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] yzhliu commented on issue #5286: [Requantize]
Cleanup and Optimize Lowering
Posted by GitBox <gi...@apache.org>.
yzhliu commented on issue #5286: [Requantize] Cleanup and Optimize Lowering
URL: https://github.com/apache/incubator-tvm/pull/5286#issuecomment-612569687
Thanks @anijain2305
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] anijain2305 commented on a change in pull request
#5286: [Requantize] Cleanup and Optimize Lowering
Posted by GitBox <gi...@apache.org>.
anijain2305 commented on a change in pull request #5286: [Requantize] Cleanup and Optimize Lowering
URL: https://github.com/apache/incubator-tvm/pull/5286#discussion_r405910530
##########
File path: src/relay/qnn/op/requantize.cc
##########
@@ -132,36 +132,29 @@ Expr RequantizeLower(const Expr& input_tensor, const Expr& input_scale,
const Expr& input_zero_point, const Expr& output_scale,
const Expr& output_zero_point, const RequantizeAttrs* param,
const Array<IndexExpr>& input_shape, const DataType& out_dtype) {
- DataType hp_dtype = DataType::Int(64);
- auto tensor = Cast(input_tensor, hp_dtype);
+ auto tensor = Cast(input_tensor, DataType::Int(32));
Review comment:
Might not be required.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] yzhliu merged pull request #5286: [Requantize]
Cleanup and Optimize Lowering
Posted by GitBox <gi...@apache.org>.
yzhliu merged pull request #5286: [Requantize] Cleanup and Optimize Lowering
URL: https://github.com/apache/incubator-tvm/pull/5286
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services