[GitHub] [hbase] Apache9 commented on a change in pull request #2412: HBASE-25054 Do not add non shaded protobuf as dependency in TableMapR…

[GitBox <gi...@apache.org>]

Apache9 commented on a change in pull request #2412:
URL: https://github.com/apache/hbase/pull/2412#discussion_r490001906



##########
File path: hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/TableMapReduceUtil.java
##########
@@ -819,7 +819,6 @@ public static void addHBaseDependencyJars(Configuration conf) throws IOException
       org.apache.hbase.thirdparty.com.google.protobuf.UnsafeByteOperations.class, // hb-sh-protobuf
       org.apache.hbase.thirdparty.io.netty.channel.Channel.class,    // hbase-shaded-netty
       org.apache.zookeeper.ZooKeeper.class,                          // zookeeper
-      com.google.protobuf.Message.class,                             // protobuf

Review comment:
       You can see the comment on jira. The maven shade plugin will also relocate this line and then cause class not found error. I tried to not relocated protobuf, but then it leads to other problems when building hbase-shaded-client. So I suppose there are still other problems. But anyway, for master, we do not depend on protobuf any more, in hbase we all use our thirdparty protobuf, so here we could just remove it. And removing it can fix the class not found problem.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org