You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by GitBox <gi...@apache.org> on 2020/12/03 15:15:15 UTC

[GitHub] [tomcat] ChristopherSchultz commented on a change in pull request #380: Fix BZ 64110 - request attr for requested ciphers and protocols

ChristopherSchultz commented on a change in pull request #380:
URL: https://github.com/apache/tomcat/pull/380#discussion_r535319757



##########
File path: java/org/apache/tomcat/util/net/TLSClientHelloExtractor.java
##########
@@ -193,6 +214,15 @@ public String getSNIValue() {
     }
 
 
+    public List<String> getClientRequestedCipherNames() {
+        if (result == ExtractorResult.COMPLETE || result == ExtractorResult.NOT_PRESENT) {
+            return clientRequestedCipherNames;
+        } else {
+            throw new IllegalStateException();

Review comment:
       -1 to having no message




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org