You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@groovy.apache.org by GitBox <gi...@apache.org> on 2022/03/01 14:29:51 UTC

[GitHub] [groovy] aulea commented on a change in pull request #1691: Issue GROOVY-10505 trait composer methods as generated

aulea commented on a change in pull request #1691:
URL: https://github.com/apache/groovy/pull/1691#discussion_r816819050



##########
File path: src/main/java/org/codehaus/groovy/transform/trait/TraitASTTransformation.java
##########
@@ -498,7 +500,7 @@ private void processField(final FieldNode field, final MethodNode initializer, f
                         ClassNode.EMPTY_ARRAY,
                         returnS(initCode.getExpression())
                 );
-                helper.addMethod(fieldInitializer);
+                ClassNodeUtils.addGeneratedMethod(helper, fieldInitializer);

Review comment:
       You are right, whole helper class is marked as generated and this is unnecessary. Reverted it with new commit.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org