You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2015/06/19 00:12:48 UTC
Review Request 35613: Fixing broken gradle dependency scanner.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35613/
-----------------------------------------------------------
Review request for Aurora and Bill Farner.
Repository: aurora
Description
-------
Our current scanner plugin version does not work with gradle 2.4.
Upgrading plugin version and a few other deps (those that did not conflict with a mighty twitter.commons package):
- junit: https://github.com/junit-team/junit/blob/master/doc/ReleaseNotes4.12.md
- gson: https://sites.google.com/site/gson/gson-roadmap
- slf4j: http://www.slf4j.org/news.html
- mybatis: https://github.com/mybatis/mybatis-3/releases
Diffs
-----
build.gradle 700e1ade1470b99e9be390db150cf73aa06f17bc
Diff: https://reviews.apache.org/r/35613/diff/
Testing
-------
./build-support/jenkins/build.sh
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Thanks,
Maxim Khutornenko
Re: Review Request 35613: Fixing broken gradle dependency scanner.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35613/#review88447
-----------------------------------------------------------
Master (e271634) is red with this patch.
./build-support/jenkins/build.sh
:compileJava
Download https://repo1.maven.org/maven2/org/mybatis/mybatis/3.3.0/mybatis-3.3.0.pom
Download https://repo1.maven.org/maven2/org/mybatis/mybatis-parent/24/mybatis-parent-24.pom
Download https://repo1.maven.org/maven2/org/slf4j/slf4j-jdk14/1.7.12/slf4j-jdk14-1.7.12.pom
Download https://repo1.maven.org/maven2/org/mybatis/mybatis/3.3.0/mybatis-3.3.0.jar
Download https://repo1.maven.org/maven2/org/slf4j/slf4j-jdk14/1.7.12/slf4j-jdk14-1.7.12.jar
Note: Writing file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.txt.2
:processResources
:classes
:jar
:startScripts
:distTar
:distZip
:assemble
:compileJmhJavaNote: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
:processJmhResources UP-TO-DATE
:jmhClasses
:checkstyleJmh
:jsHint
:checkstyleMain[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/auth/UnsecureAuthModule.java:40: Line is longer than 100 characters (found 118).
[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/auth/UnsecureAuthModule.java:41: Line is longer than 100 characters (found 119).
[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/auth/UnsecureAuthModule.java:42: Line is longer than 100 characters (found 119).
[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/auth/UnsecureAuthModule.java:43: Line is longer than 100 characters (found 110).
[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/auth/UnsecureSessionContext.java:25: 'org.apache.shiro.subject.Subject' should be separated from previous imports.
FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':checkstyleMain'.
> Checkstyle rule violations were found. See the report at: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/main.xml
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
BUILD FAILED
Total time: 2 mins 37.77 secs
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On June 18, 2015, 10:12 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35613/
> -----------------------------------------------------------
>
> (Updated June 18, 2015, 10:12 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Our current scanner plugin version does not work with gradle 2.4.
>
> Upgrading plugin version and a few other deps (those that did not conflict with a mighty twitter.commons package):
> - junit: https://github.com/junit-team/junit/blob/master/doc/ReleaseNotes4.12.md
> - gson: https://sites.google.com/site/gson/gson-roadmap
> - slf4j: http://www.slf4j.org/news.html
> - mybatis: https://github.com/mybatis/mybatis-3/releases
>
>
> Diffs
> -----
>
> build.gradle 700e1ade1470b99e9be390db150cf73aa06f17bc
>
> Diff: https://reviews.apache.org/r/35613/diff/
>
>
> Testing
> -------
>
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 35613: Fixing broken gradle dependency scanner.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35613/#review88460
-----------------------------------------------------------
Ship it!
LGTM once the bot is happy.
- Bill Farner
On June 18, 2015, 10:12 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35613/
> -----------------------------------------------------------
>
> (Updated June 18, 2015, 10:12 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Our current scanner plugin version does not work with gradle 2.4.
>
> Upgrading plugin version and a few other deps (those that did not conflict with a mighty twitter.commons package):
> - junit: https://github.com/junit-team/junit/blob/master/doc/ReleaseNotes4.12.md
> - gson: https://sites.google.com/site/gson/gson-roadmap
> - slf4j: http://www.slf4j.org/news.html
> - mybatis: https://github.com/mybatis/mybatis-3/releases
>
>
> Diffs
> -----
>
> build.gradle 700e1ade1470b99e9be390db150cf73aa06f17bc
>
> Diff: https://reviews.apache.org/r/35613/diff/
>
>
> Testing
> -------
>
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 35613: Fixing broken gradle dependency scanner.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35613/#review88464
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Sweeney
On June 18, 2015, 3:12 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35613/
> -----------------------------------------------------------
>
> (Updated June 18, 2015, 3:12 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Our current scanner plugin version does not work with gradle 2.4.
>
> Upgrading plugin version and a few other deps (those that did not conflict with a mighty twitter.commons package):
> - junit: https://github.com/junit-team/junit/blob/master/doc/ReleaseNotes4.12.md
> - gson: https://sites.google.com/site/gson/gson-roadmap
> - slf4j: http://www.slf4j.org/news.html
> - mybatis: https://github.com/mybatis/mybatis-3/releases
>
>
> Diffs
> -----
>
> build.gradle 700e1ade1470b99e9be390db150cf73aa06f17bc
>
> Diff: https://reviews.apache.org/r/35613/diff/
>
>
> Testing
> -------
>
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 35613: Fixing broken gradle dependency scanner.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35613/#review88550
-----------------------------------------------------------
@ReviewBot retry
- Maxim Khutornenko
On June 18, 2015, 10:12 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35613/
> -----------------------------------------------------------
>
> (Updated June 18, 2015, 10:12 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Our current scanner plugin version does not work with gradle 2.4.
>
> Upgrading plugin version and a few other deps (those that did not conflict with a mighty twitter.commons package):
> - junit: https://github.com/junit-team/junit/blob/master/doc/ReleaseNotes4.12.md
> - gson: https://sites.google.com/site/gson/gson-roadmap
> - slf4j: http://www.slf4j.org/news.html
> - mybatis: https://github.com/mybatis/mybatis-3/releases
>
>
> Diffs
> -----
>
> build.gradle 700e1ade1470b99e9be390db150cf73aa06f17bc
>
> Diff: https://reviews.apache.org/r/35613/diff/
>
>
> Testing
> -------
>
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 35613: Fixing broken gradle dependency scanner.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35613/#review88458
-----------------------------------------------------------
@ReviewBot retry
- Maxim Khutornenko
On June 18, 2015, 10:12 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35613/
> -----------------------------------------------------------
>
> (Updated June 18, 2015, 10:12 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Our current scanner plugin version does not work with gradle 2.4.
>
> Upgrading plugin version and a few other deps (those that did not conflict with a mighty twitter.commons package):
> - junit: https://github.com/junit-team/junit/blob/master/doc/ReleaseNotes4.12.md
> - gson: https://sites.google.com/site/gson/gson-roadmap
> - slf4j: http://www.slf4j.org/news.html
> - mybatis: https://github.com/mybatis/mybatis-3/releases
>
>
> Diffs
> -----
>
> build.gradle 700e1ade1470b99e9be390db150cf73aa06f17bc
>
> Diff: https://reviews.apache.org/r/35613/diff/
>
>
> Testing
> -------
>
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 35613: Fixing broken gradle dependency scanner.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35613/#review88565
-----------------------------------------------------------
Ship it!
Master (589d901) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On June 18, 2015, 10:12 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35613/
> -----------------------------------------------------------
>
> (Updated June 18, 2015, 10:12 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Our current scanner plugin version does not work with gradle 2.4.
>
> Upgrading plugin version and a few other deps (those that did not conflict with a mighty twitter.commons package):
> - junit: https://github.com/junit-team/junit/blob/master/doc/ReleaseNotes4.12.md
> - gson: https://sites.google.com/site/gson/gson-roadmap
> - slf4j: http://www.slf4j.org/news.html
> - mybatis: https://github.com/mybatis/mybatis-3/releases
>
>
> Diffs
> -----
>
> build.gradle 700e1ade1470b99e9be390db150cf73aa06f17bc
>
> Diff: https://reviews.apache.org/r/35613/diff/
>
>
> Testing
> -------
>
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
>
>
> Thanks,
>
> Maxim Khutornenko
>
>