[GitHub] [arrow-rs] tustvold commented on a diff in pull request #1822: Change to use `resolver v2`, test more feature flag combinations in CI, fix errors (#1630)

[GitBox <gi...@apache.org>]

tustvold commented on code in PR #1822:
URL: https://github.com/apache/arrow-rs/pull/1822#discussion_r893597651


##########
.github/workflows/rust.yml:
##########
@@ -108,31 +108,39 @@ jobs:
 
           # run tests on all workspace members with default feature list
           cargo test
-
-          # Switch to arrow crate
-          cd arrow
-          # re-run tests on arrow crate to ensure
-          # all arrays are created correctly
-          cargo test --features=force_validate
-          cargo test --features=prettyprint
-          # run test on arrow crate with minimal set of features
-          cargo test --no-default-features
+          
+          # re-run tests on arrow crate with all supported features
+          cargo test -p arrow --features=force_validate,prettyprint
+          
+          # Test arrow examples
           cargo run --example builders
           cargo run --example dynamic_types
           cargo run --example read_csv
           cargo run --example read_csv_infer_schema
-          cargo check --no-default-features
+          

Review Comment:
   Working on this, running into nonsense with environment variables and caching



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org