You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/10/07 02:31:37 UTC
[GitHub] [pulsar] dave2wave opened a new pull request, #17956: [Doc][bugfixx] Example broke Ensemble>=WriteQuorum>=AckQuorum Rule
dave2wave opened a new pull request, #17956:
URL: https://github.com/apache/pulsar/pull/17956
### Motivation
Our admin examples must not show users incorrect information.
### Modifications
Changed Bookkeeper persistence example.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] Anything that affects deployment
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [X] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Huanli-Meng commented on pull request #17956: [Doc][bugfix] Example broke Ensemble>=WriteQuorum>=AckQuorum Rule
Posted by GitBox <gi...@apache.org>.
Huanli-Meng commented on PR #17956:
URL: https://github.com/apache/pulsar/pull/17956#issuecomment-1274044320
> @Huanli-Meng this change and #17955 need to be propagated to prior branches. Thank you.
@dave2wave thanks for your confirmation. BTW, would you like to help update these updates to prior branches? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] dave2wave closed pull request #17956: [Doc][bugfix] Example broke Ensemble>=WriteQuorum>=AckQuorum Rule
Posted by GitBox <gi...@apache.org>.
dave2wave closed pull request #17956: [Doc][bugfix] Example broke Ensemble>=WriteQuorum>=AckQuorum Rule
URL: https://github.com/apache/pulsar/pull/17956
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] dave2wave merged pull request #17956: [Doc][bugfix] Example broke Ensemble>=WriteQuorum>=AckQuorum Rule
Posted by GitBox <gi...@apache.org>.
dave2wave merged PR #17956:
URL: https://github.com/apache/pulsar/pull/17956
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] dave2wave commented on pull request #17956: [Doc][bugfix] Example broke Ensemble>=WriteQuorum>=AckQuorum Rule
Posted by GitBox <gi...@apache.org>.
dave2wave commented on PR #17956:
URL: https://github.com/apache/pulsar/pull/17956#issuecomment-1272220349
> We should add a check that rejects the invalid configuration
There is a checkArgument if we set the policy through an admin call. Are you suggesting that we also test validity when a policy is created? This can be incomplete since the full check includes knowing the broker configuration to handle the currently allowed maximums for the ensemble size. I don't think testing without the max part is wrong, I'm just looking for clarification. In any case I think that check is a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Huanli-Meng commented on pull request #17956: [Doc][bugfix] Example broke Ensemble>=WriteQuorum>=AckQuorum Rule
Posted by GitBox <gi...@apache.org>.
Huanli-Meng commented on PR #17956:
URL: https://github.com/apache/pulsar/pull/17956#issuecomment-1272308419
@dave2wave could you please help confirm whether docs in other releases also need to be updated? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] dave2wave commented on pull request #17956: [Doc][bugfix] Example broke Ensemble>=WriteQuorum>=AckQuorum Rule
Posted by GitBox <gi...@apache.org>.
dave2wave commented on PR #17956:
URL: https://github.com/apache/pulsar/pull/17956#issuecomment-1273802673
@Huanli-Meng this change and #17955 need to be propagated to prior branches. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org