You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/06 09:16:45 UTC

[GitHub] [flink] matriv opened a new pull request #17418: [FLINK-24421][table-runtime] Fix conversion of strings to TIME

matriv opened a new pull request #17418:
URL: https://github.com/apache/flink/pull/17418


   ## What is the purpose of the change
   
   Following calcite-avatica behaviour, fix the behaviour of parsing
   string into unix time when the string is incomplete, missing 1 or
   both `:` time units separator. Previously, minutes and seconds where
   set to default value `1` instead of `0` when missing from the parsed
   string. Issue was fixed in avatica with: https://github.com/apache/calcite-avatica/commit/cac2ffaaf97572d21cba195d7590d9ab0d32382e
   
   
   ## Brief change log
   
     - Apply the fix for parsing strings into time as in calcite-avatica
   
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
     - Changed tests for CASTing string to TIME() which uses the method in question
     - Added more tests to demonstrate better the behaviour for such edge cases
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #17418: [FLINK-24421][table-runtime] Fix conversion of strings to TIME

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17418:
URL: https://github.com/apache/flink/pull/17418#issuecomment-935901331


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e024d45525bab4b921aab787984f0f2a0654b1ed",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "e024d45525bab4b921aab787984f0f2a0654b1ed",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e024d45525bab4b921aab787984f0f2a0654b1ed UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #17418: [FLINK-24421][table-runtime] Fix conversion of strings to TIME

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17418:
URL: https://github.com/apache/flink/pull/17418#issuecomment-935857450


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit e024d45525bab4b921aab787984f0f2a0654b1ed (Wed Oct 06 09:42:56 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] twalthr closed pull request #17418: [FLINK-24421][table-runtime] Fix conversion of strings to TIME

Posted by GitBox <gi...@apache.org>.
twalthr closed pull request #17418:
URL: https://github.com/apache/flink/pull/17418


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] twalthr closed pull request #17418: [FLINK-24421][table-runtime] Fix conversion of strings to TIME

Posted by GitBox <gi...@apache.org>.
twalthr closed pull request #17418:
URL: https://github.com/apache/flink/pull/17418


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17418: [FLINK-24421][table-runtime] Fix conversion of strings to TIME

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17418:
URL: https://github.com/apache/flink/pull/17418#issuecomment-935901331


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e024d45525bab4b921aab787984f0f2a0654b1ed",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24798",
       "triggerID" : "e024d45525bab4b921aab787984f0f2a0654b1ed",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e024d45525bab4b921aab787984f0f2a0654b1ed Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24798) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #17418: [FLINK-24421][table-runtime] Fix conversion of strings to TIME

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17418:
URL: https://github.com/apache/flink/pull/17418#issuecomment-935901331


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e024d45525bab4b921aab787984f0f2a0654b1ed",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24798",
       "triggerID" : "e024d45525bab4b921aab787984f0f2a0654b1ed",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e024d45525bab4b921aab787984f0f2a0654b1ed Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24798) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org