You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "kevinjqliu (via GitHub)" <gi...@apache.org> on 2024/09/12 22:02:00 UTC
[I] [feature request] Support Time64Type[ns] [iceberg-python]
kevinjqliu opened a new issue, #1169:
URL: https://github.com/apache/iceberg-python/issues/1169
### Feature Request / Improvement
Currently `Time64Type[ns]` (`Time64Type` with nanosecond precision) is not supported. Only `Time64Type[ms]` (`Time64Type` with microsecond precision) is supported.
https://github.com/apache/iceberg-python/blob/d8d509ff1bc33040b9f6c90c28ee47ac7437945d/pyiceberg/io/pyarrow.py#L1071-L1072
Also add the ability to downcast, similar to the `pa.types.is_timestamp(primitive):` branch.
Interestingly `Time64Type[ns]` is `False` when evaluating `pa.types.is_timestamp(primitive)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] [feature request] Support Time64Type[ns] [iceberg-python]
Posted by "romanzdk (via GitHub)" <gi...@apache.org>.
romanzdk commented on issue #1169:
URL: https://github.com/apache/iceberg-python/issues/1169#issuecomment-4127007918
We would love to have this feature!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] [feature request] Support Time64Type[ns] [iceberg-python]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on issue #1169:
URL: https://github.com/apache/iceberg-python/issues/1169#issuecomment-2361808032
assigned to you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] [feature request] Support Time64Type[ns] [iceberg-python]
Posted by "jaimeferj (via GitHub)" <gi...@apache.org>.
jaimeferj commented on issue #1169:
URL: https://github.com/apache/iceberg-python/issues/1169#issuecomment-3363327816
Hi, I see there’s an existing PR [#1252](https://github.com/apache/iceberg-python/pull/1215) for this issue but it looks stale.
If there’s no objection, I can pick this up and open a new PR to move it forward, referencing the original work.
Please let me know if that’s okay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] [feature request] Support Time64Type[ns] [iceberg-python]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #1169:
URL: https://github.com/apache/iceberg-python/issues/1169#issuecomment-5769536480
This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. To permanently prevent this issue from being considered stale, add the label 'not-stale', but commenting on the issue is preferred when possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] [feature request] Support Time64Type[ns] [iceberg-python]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on issue #1169:
URL: https://github.com/apache/iceberg-python/issues/1169#issuecomment-2767704299
This issue has been automatically marked as stale because it has been open for 180 days with no activity. It will be closed in next 14 days if no further activity occurs. To permanently prevent this issue from being considered stale, add the label 'not-stale', but commenting on the issue is preferred when possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] [feature request] Support Time64Type[ns] [iceberg-python]
Posted by "zaryab-ali (via GitHub)" <gi...@apache.org>.
zaryab-ali commented on issue #1169:
URL: https://github.com/apache/iceberg-python/issues/1169#issuecomment-2364188341
@kevinjqliu can you please review my PR and let me know if i made a mistake (please check with extra caution as it is my first contribution to any open source project)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] [feature request] Support Time64Type[ns] [iceberg-python]
Posted by "hafezbahrasemani (via GitHub)" <gi...@apache.org>.
hafezbahrasemani commented on issue #1169:
URL: https://github.com/apache/iceberg-python/issues/1169#issuecomment-6262026148
@kevinjqliu Hey, if the issue is still available can you assign it to me?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] [feature request] Support Time64Type[ns] [iceberg-python]
Posted by "zaryab-ali (via GitHub)" <gi...@apache.org>.
zaryab-ali commented on issue #1169:
URL: https://github.com/apache/iceberg-python/issues/1169#issuecomment-2361803646
@kevinjqliu if the issue is still available can you assign it to me please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] [feature request] Support Time64Type[ns] [iceberg-python]
Posted by "0x26res (via GitHub)" <gi...@apache.org>.
0x26res commented on issue #1169:
URL: https://github.com/apache/iceberg-python/issues/1169#issuecomment-2801964810
| Interestingly Time64Type[ns] is False when evaluating pa.types.is_timestamp(primitive).
I think this is expected, time64/32 is not a timestamp but a time.
```
>>> import pyarrow as pa
>>> pa.types.is_timestamp(pa.time64("ns"))
False
>>> pa.types.is_time(pa.time64("ns"))
True
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] [feature request] Support Time64Type[ns] [iceberg-python]
Posted by "romanzdk (via GitHub)" <gi...@apache.org>.
romanzdk commented on issue #1169:
URL: https://github.com/apache/iceberg-python/issues/1169#issuecomment-5914552416
Bumping
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org