[GitHub] [tinkerpop] simonz-bq commented on a diff in pull request #1743: Cast Times serialization to int in Gremlin-Go

[GitBox <gi...@apache.org>]

simonz-bq commented on code in PR #1743:
URL: https://github.com/apache/tinkerpop/pull/1743#discussion_r914200413


##########
gremlin-go/driver/graphTraversal.go:
##########
@@ -587,7 +587,8 @@ func (g *GraphTraversal) TimeLimit(args ...interface{}) *GraphTraversal {
 
 // Times adds the times step to the GraphTraversal.
 func (g *GraphTraversal) Times(args ...interface{}) *GraphTraversal {
-	g.Bytecode.AddStep("times", args...)
+	// Gremlin server only accepts times step with integer argument values
+	g.Bytecode.AddStep("times", int32Args(args)...)

Review Comment:
   I don't think this matters too much. Passing in a int32 cast is still a valid input, and the cucumber tests are meant to test input-output, not the semantics of how it's entered into gremlin-go. There are other examples of inputs not being exactly as you'd expect a real user to pass things in.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org