[GitHub] [incubator-seatunnel] harveyyue commented on a diff in pull request #3146: [Improve][Connector-V2][ElasticSearch] Add index_id option to specify the primary keys for index

[GitBox <gi...@apache.org>]

harveyyue commented on code in PR #3146:
URL: https://github.com/apache/incubator-seatunnel/pull/3146#discussion_r1001642878


##########
seatunnel-connectors-v2/connector-elasticsearch/src/main/java/org/apache/seatunnel/connectors/seatunnel/elasticsearch/dto/IndexInfo.java:
##########
@@ -19,19 +19,25 @@
 
 import org.apache.seatunnel.connectors.seatunnel.elasticsearch.config.SinkConfig;
 
+import java.util.List;
+
 /**
  * index config by seatunnel
  */
 public class IndexInfo {
 
     private String index;
     private String type;
+    private List<String> ids;

Review Comment:
   It should be a null value if not setting index_id.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org