[GitHub] [incubator-superset] betodealmeida commented on issue #7358: limit tables/views returned if schema is not provided

[GitBox <gi...@apache.org>]

betodealmeida commented on issue #7358: limit tables/views returned if schema is not provided
URL: https://github.com/apache/incubator-superset/pull/7358#issuecomment-485953579
 
 
   I was looking at the code, and we **do** limit the objects returned, but only if a substring is passed: https://github.com/apache/incubator-superset/pull/7358/files#diff-ac978615a4f22c4fad4d01f39e1d4595R1539
   
   I wonder if we should also limit it when no substring is passed? Your approach is nice because it's more usable: if we're going to limit the number of tables we might as well limit to the most important schemas, instead of returning a random subset. But some schemas (like `default`) could still return thousands of tables, making the payload too big, and it might be interesting to apply the `MAX_TABLE_NAMES` limit even if we're only returning from selected schemas.
   
   @mistercrunch any thoughts here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org