[jira] [Commented] (DATASKETCHES-5) Buffer over-read in MurmurHash3_x64_128

["Jon Malkin (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DATASKETCHES-5?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17118157#comment-17118157 ] 

Jon Malkin commented on DATASKETCHES-5:
---------------------------------------

I verified that this is a bug, in particular vs the java code.

On the positive side, things should at least match for keys up to 32 bytes/256 bits, which more than includes things like standard UUID formats. We'll be scrubbing the vote on the current release candidate and creating an RC3 in order to get this fix in to the 2.0.0 release.

> Buffer over-read in MurmurHash3_x64_128
> ---------------------------------------
>
>                 Key: DATASKETCHES-5
>                 URL: https://issues.apache.org/jira/browse/DATASKETCHES-5
>             Project: Apache Datasketches
>          Issue Type: Bug
>            Reporter: Csaba Ringhofer
>            Priority: Critical
>
> MurmurHash3_x64_128 seems to contain a half-commented-out change that leads to adding the offset to the key 2 times:
> 'blocks ' is increased:
> https://github.com/apache/incubator-datasketches-cpp/blob/2941841dda921026a5dc2052388461d9295dc0b0/common/include/MurmurHash3.h#L128
> but the following lines assume that 'blocks ' still points to the start of the key:
> https://github.com/apache/incubator-datasketches-cpp/blob/2941841dda921026a5dc2052388461d9295dc0b0/common/include/MurmurHash3.h#L115
> https://github.com/apache/incubator-datasketches-cpp/blob/2941841dda921026a5dc2052388461d9295dc0b0/common/include/MurmurHash3.h#L133



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org