swig-pl make target tries to link identical files

[pe...@bigfoot.com]

The swig-pl make target (from the top-level subversion Makefile) has an if statement that compares ${SWIG_PL_DIR} to ${SWIG_PL_SRC_DIR} and if they're different tries to create symlinks from one path to the other.

The problem is, if the path contains a directory symlink, then these 2 variables may be different even though the paths themselves point to the same directory.

The problem is actually because of the $abs_builddir and $abs_srcdir variables.

For example, assume the directory containing the subversion source is "/build/svn" and "/build" is a symlink to "/data/build".  Given this, the generated Makefile will have "$abs_builddir" set to "/build/svn" and "$abs_srcdir" set to "/data/build/svn".

The $SWIG_PL_DIR and $SWIG_PL_SRC_DIR variables will be set based on $abs_builddir and $abs_srcdir and since the variables contain different values the test in the swig-pl target will think the paths are different and try to create symlinks.  The ln command will fail because it detects the paths are actually the same and this in turn causes the swig-pl target to fail.

I'm not sure if the problem only occurs on certain platforms, but I know it fails on Mac 10.5.

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1201413