You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by pm...@apache.org on 2016/12/27 14:16:19 UTC

svn commit: r1776136 - /jmeter/trunk/src/core/org/apache/jmeter/save/SaveGraphicsService.java

Author: pmouawad
Date: Tue Dec 27 14:16:19 2016
New Revision: 1776136

URL: http://svn.apache.org/viewvc?rev=1776136&view=rev
Log:
Sonar : Fix false-positive

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/save/SaveGraphicsService.java

Modified: jmeter/trunk/src/core/org/apache/jmeter/save/SaveGraphicsService.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/save/SaveGraphicsService.java?rev=1776136&r1=1776135&r2=1776136&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/save/SaveGraphicsService.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/save/SaveGraphicsService.java Tue Dec 27 14:16:19 2016
@@ -28,12 +28,12 @@ import java.io.OutputStream;
 
 import javax.swing.JComponent;
 
+import org.apache.jmeter.util.JMeterUtils;
+import org.apache.jorphan.util.JOrphanUtils;
 import org.apache.xmlgraphics.image.codec.png.PNGEncodeParam;
 import org.apache.xmlgraphics.image.codec.png.PNGImageEncoder;
 import org.apache.xmlgraphics.image.codec.tiff.TIFFEncodeParam;
 import org.apache.xmlgraphics.image.codec.tiff.TIFFImageEncoder;
-import org.apache.jmeter.util.JMeterUtils;
-import org.apache.jorphan.util.JOrphanUtils;
 
 /**
  * Class is responsible for taking a component and saving it as a JPEG, PNG or
@@ -169,10 +169,9 @@ public class SaveGraphicsService {
             encoder.encode(image);
         } catch (IOException e) {
             JMeterUtils.reportErrorToUser("TIFFImageEncoder reported: "+e.getMessage(), "Problem creating image file");
-        // Yuck: TIFFImageEncoder uses Error to report runtime problems
-        } catch (Error e) {
+        } catch (Error e) { // NOSONAR TIFFImageEncoder uses Error to report runtime problems
             JMeterUtils.reportErrorToUser("TIFFImageEncoder reported: "+e.getMessage(), "Problem creating image file");
-            if (e.getClass() != Error.class){// rethrow other errors
+            if (e.getClass() != Error.class){// NOSONAR rethrow other errors
                 throw e;
             }
         } finally {