[GitHub] [arrow] wgtmac commented on a diff in pull request #14964: GH-33596: [C++][Parquet] Parquet page index read support

["wgtmac (via GitHub)" <gi...@apache.org>]

wgtmac commented on code in PR #14964:
URL: https://github.com/apache/arrow/pull/14964#discussion_r1094659377


##########
cpp/src/parquet/page_index.cc:
##########
@@ -441,8 +442,11 @@ RowGroupIndexReadRange PageIndexReader::DeterminePageIndexRangesInRowGroup(
         throw ParquetException("Invalid index location: offset ", index_location->offset,
                                " length ", index_location->length);
       }
+      int64_t index_end = 0;
+      ::arrow::internal::AddWithOverflow(index_location->offset, index_location->length,

Review Comment:
   > Hmm, ok, but you should check the return value, which is the whole point.
   
   My bad! Sorry about that



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org