You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by ra0077 <gi...@git.apache.org> on 2016/04/09 08:56:40 UTC
[GitHub] jmeter pull request: Bug59294_BetterPercentileLabelv3
GitHub user ra0077 opened a pull request:
https://github.com/apache/jmeter/pull/187
Bug59294_BetterPercentileLabelv3
Hi,
I propose better percentile label :
new and better label
same in Response Time Per Sample and Dashboard statistics
New release with the right properties files
Antonio
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ra0077/jmeter Bug59294_BetterPercentileLabelv3
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jmeter/pull/187.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #187
----
commit 0165352fa09a2771b19290c72f5425a875cf1513
Author: ra0077 <ra...@gmail.com>
Date: 2016-04-09T06:55:50Z
Bug59294_BetterPercentileLabelv3
Hi,
I propose better percentile label :
new and better label
same in Response Time Per Sample and Dashboard statistics
New release with the right properties files
Antonio
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request: Bug59294_BetterPercentileLabelv3
Posted by ra0077 <gi...@git.apache.org>.
Github user ra0077 commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/187#discussion_r59141868
--- Diff: src/core/org/apache/jmeter/resources/messages_fr.properties ---
@@ -853,7 +853,7 @@ reportgenerator_summary_statistics_kbytes=Ko/sec
reportgenerator_summary_statistics_label=Libell\u00E9
reportgenerator_summary_statistics_max=Max
reportgenerator_summary_statistics_min=Min
-reportgenerator_summary_statistics_percentile_fmt=%d%% Ligne
+reportgenerator_summary_statistics_percentile_fmt=%de percentile
--- End diff --
Hi Milamber,
I have compare HTML report with other listener and find another difference (in % error)
I have commit it in https://github.com/apache/jmeter/pull/190 because percentil PR (PR 187) modify also a java file and not only properties files
Antonio
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request: Bug59294_BetterPercentileLabelv3
Posted by ra0077 <gi...@git.apache.org>.
Github user ra0077 commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/187#discussion_r59132248
--- Diff: src/core/org/apache/jmeter/resources/messages_fr.properties ---
@@ -853,7 +853,7 @@ reportgenerator_summary_statistics_kbytes=Ko/sec
reportgenerator_summary_statistics_label=Libell\u00E9
reportgenerator_summary_statistics_max=Max
reportgenerator_summary_statistics_min=Min
-reportgenerator_summary_statistics_percentile_fmt=%d%% Ligne
+reportgenerator_summary_statistics_percentile_fmt=%de percentile
--- End diff --
Ok no problem
I will compare aggregate graph/aggregate report with HTML to use the same words
Antonio
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request: Bug59294_BetterPercentileLabelv3
Posted by milamberspace <gi...@git.apache.org>.
Github user milamberspace commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/187#discussion_r59113426
--- Diff: src/core/org/apache/jmeter/resources/messages_fr.properties ---
@@ -853,7 +853,7 @@ reportgenerator_summary_statistics_kbytes=Ko/sec
reportgenerator_summary_statistics_label=Libell\u00E9
reportgenerator_summary_statistics_max=Max
reportgenerator_summary_statistics_min=Min
-reportgenerator_summary_statistics_percentile_fmt=%d%% Ligne
+reportgenerator_summary_statistics_percentile_fmt=%de percentile
--- End diff --
In JMeter (aggregate graph, aggregate report), we use "centile", so it's will better to continue to use the word.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request: Bug59294_BetterPercentileLabelv3
Posted by ra0077 <gi...@git.apache.org>.
Github user ra0077 commented on the pull request:
https://github.com/apache/jmeter/pull/187#issuecomment-207734589
Hi Vladimir,
Thanks to your tips and advices
I have juste make a rebase to have "clean properties files" and I have
modify again the 2 files
Antonio
<https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail&utm_term=oa-2200-c>
Garanti
sans virus. www.avast.com
<https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail&utm_term=oa-2200-c>
<#DDB4FAA8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
2016-04-09 9:32 GMT+02:00 Vladimir Sitnikov <no...@github.com>:
> @ra0077 <https://github.com/ra0077>, thanks for the PRs, however could
> you please try reusing the PRs next time?
>
> Regarding "the right properties files", can you please clarify if you have
> to perform additional steps to make properties file "sane"?
>
> Regarding reuse:
>
> You could force push new commit to your Bug59294_BetterPercentileLabel
> branch, that would update #186 <https://github.com/apache/jmeter/pull/186>
> .
>
> In simple case (like #186 <https://github.com/apache/jmeter/pull/186>)
> "close PR + send new PR" does little difference from "update PR with new
> contents", however keeping the same URL, comment thread, conversation, etc,
> helps.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/jmeter/pull/187#issuecomment-207733923>
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request: Bug59294_BetterPercentileLabelv3
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/jmeter/pull/187
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request: Bug59294_BetterPercentileLabelv3
Posted by vlsi <gi...@git.apache.org>.
Github user vlsi commented on the pull request:
https://github.com/apache/jmeter/pull/187#issuecomment-207733923
@ra0077, thanks for the PRs, however could you please try reusing the PRs next time?
Regarding "the right properties files", can you please clarify if you have to perform additional steps to make properties file "sane"?
Regarding reuse:
You could force push new commit to your `Bug59294_BetterPercentileLabel` branch, that would update #186.
In simple case (like #186) "close PR + send new PR" does little difference from "update PR with new contents", however keeping the same URL, comment thread, conversation, etc, helps.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request: Bug59294_BetterPercentileLabelv3
Posted by ra0077 <gi...@git.apache.org>.
Github user ra0077 commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/187#discussion_r59111828
--- Diff: src/core/org/apache/jmeter/resources/messages_fr.properties ---
@@ -853,7 +853,7 @@ reportgenerator_summary_statistics_kbytes=Ko/sec
reportgenerator_summary_statistics_label=Libell\u00E9
reportgenerator_summary_statistics_max=Max
reportgenerator_summary_statistics_min=Min
-reportgenerator_summary_statistics_percentile_fmt=%d%% Ligne
+reportgenerator_summary_statistics_percentile_fmt=%de percentile
--- End diff --
Hi Milamber,
I am ok with your but in wikipedia (https://fr.wikipedia.org/wiki/Centile)
I have seen that percentile is also accepted
I quoted wikipedia:
"En statistique descriptive
<https://fr.wikipedia.org/wiki/Statistique_descriptive>, un *centile* est
chacune des 99 valeurs qui divisent les données triées en 100 parts égales,
de sorte que chaque partie représente 1/100 de l'échantillon de population.
(La dénomination anglaise <https://fr.wikipedia.org/wiki/Anglais> —
*percentile*, avec une prononciation francisée, est parfois utilisée)."
It's why I have prefered percentile instead of centile
But if you prefer centile, it's ok for me too
Antonio
<https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail&utm_term=oa-2200-c>
Garanti
sans virus. www.avast.com
<https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail&utm_term=oa-2200-c>
<#DDB4FAA8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
2016-04-09 9:23 GMT+02:00 Milamber <no...@github.com>:
> In src/core/org/apache/jmeter/resources/messages_fr.properties
> <https://github.com/apache/jmeter/pull/187#discussion_r59111727>:
>
> > @@ -853,7 +853,7 @@ reportgenerator_summary_statistics_kbytes=Ko/sec
> > reportgenerator_summary_statistics_label=Libell\u00E9
> > reportgenerator_summary_statistics_max=Max
> > reportgenerator_summary_statistics_min=Min
> > -reportgenerator_summary_statistics_percentile_fmt=%d%% Ligne
> > +reportgenerator_summary_statistics_percentile_fmt=%de percentile
>
> In French, percentile is translate by the word "centile"
> https://fr.wikipedia.org/wiki/Centile
>
> For example : "99e centile"
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/jmeter/pull/187/files/0165352fa09a2771b19290c72f5425a875cf1513#r59111727>
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jmeter pull request: Bug59294_BetterPercentileLabelv3
Posted by milamberspace <gi...@git.apache.org>.
Github user milamberspace commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/187#discussion_r59111727
--- Diff: src/core/org/apache/jmeter/resources/messages_fr.properties ---
@@ -853,7 +853,7 @@ reportgenerator_summary_statistics_kbytes=Ko/sec
reportgenerator_summary_statistics_label=Libell\u00E9
reportgenerator_summary_statistics_max=Max
reportgenerator_summary_statistics_min=Min
-reportgenerator_summary_statistics_percentile_fmt=%d%% Ligne
+reportgenerator_summary_statistics_percentile_fmt=%de percentile
--- End diff --
In French, percentile is translate by the word "centile"
https://fr.wikipedia.org/wiki/Centile
For example : "99e centile"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---