[jira] [Commented] (CASSANDRA-16109) Don't adjust nodeCount when setting node id topology in in-jvm dtests

["Alex Petrov (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-16109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17191679#comment-17191679 ] 

Alex Petrov commented on CASSANDRA-16109:
-----------------------------------------

+1, this looks good to me, assuming it doesn't break any tests. 

That said, should we change the name of {{nodeCount}}, or at least document somewhere that {{nodeCount}}, in combination with {{topology}}, will have a meaning of "start X nodes" only, and the rest of the nodes should be started manually, or something like that.

> Don't adjust nodeCount when setting node id topology in in-jvm dtests
> ---------------------------------------------------------------------
>
>                 Key: CASSANDRA-16109
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16109
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Test/dtest/java
>            Reporter: Marcus Eriksson
>            Assignee: Marcus Eriksson
>            Priority: Low
>
> We update the node count when setting the node id topology in in-jvm dtests, this should only happen if node count is smaller than the node id topology, otherwise bootstrap tests error out.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org