[jira] [Commented] (AIRFLOW-2224) Add support for CSV file exports in mysql_to_gcs contrib operator

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16772442#comment-16772442 ] 

ASF GitHub Bot commented on AIRFLOW-2224:
-----------------------------------------

ttanay commented on pull request #4738: [AIRFLOW-2224] Add support CSV files in MySqlToGoogleCloudStorageOperator
URL: https://github.com/apache/airflow/pull/4738
 
 
   MySqlToGoogleCloudStorageOperator supported export from MySQL in newline-delimited JSON format only. 
   
   Added support for export in CSV format with the option of specifying a field delimiter.
   
   Thanks to Bernardo Najlis(@bnajlis) for the original PR(#3139).
   I made some changes to the the original PR.
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [X] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-2224
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
   
   ### Description
   
   - [X] Here are some details about my PR, including screenshots of any UI changes:
   
   ### Tests
   
   - [X] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   Added tests:
    * test_init
    * test_exec_success_json
    * test_exec_success_csv
    * test_exec_success_csv_with_delimiter
    * test_file_splitting
    * test_schema_file
   Replaced the pre-existing test with the one @bnajlis wrote as those tests covered that case too.
   
   ### Commits
   
   - [X] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [X] In case of new functionality, my PR adds documentation that describes how to use it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
   
   ### Code Quality
   
   - [ ] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add support for CSV file exports in mysql_to_gcs contrib operator
> -----------------------------------------------------------------
>
>                 Key: AIRFLOW-2224
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-2224
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: contrib
>    Affects Versions: 1.9.0
>            Reporter: Bernardo Najlis
>            Assignee: Tanay Tummalapalli
>            Priority: Major
>
> Add support to export files into CSV format for the mysql_to_gcs contrib operator.
> Using unicodecsv, this allows to:
>  # Include column names in first row
>  # Handle different CSV file types
>  # Delimiters
>  # Quoting
>  # Char escaping
>  # Line termination
> Set default format to still be JSON (current default) and also keep the multi-file format option available as JSON.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)