You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Adam B <ad...@mesosphere.io> on 2016/01/13 19:06:08 UTC
Re: Review Request 32975: MESOS-1790 Adds chown option to
CommandInfo.URI
> On April 21, 2015, 10:30 a.m., Mesos ReviewBot wrote:
> > Patch looks great!
> >
> > Reviews applied: [32975]
> >
> > All tests passed.
Jim, I heard there was interest in reviving this patch. Could you please rebase?
- Adam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32975/#review81006
-----------------------------------------------------------
On April 21, 2015, 10 a.m., Jim Klucar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32975/
> -----------------------------------------------------------
>
> (Updated April 21, 2015, 10 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-1790
> https://issues.apache.org/jira/browse/MESOS-1790
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added chown to CommandInfo.URI protocol buffer as an optional
> boolean that defaults to true, the current chown behavior.
>
> The fetcher was updated to skip the os::chown operation if the chown
> boolean is set to false.
>
> No documentation was updated.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 3c592d5ab3092ecbeddfaff95e0c1addc3ac58f8
> src/common/type_utils.cpp e92f6f36de0955784619029a016667b46bbe221b
> src/launcher/fetcher.cpp 796526f59c25898ef6db2b828b0e2bb7b172ba25
> src/tests/fetcher_tests.cpp 4549e6a631e2c17cec3766efaa556593eeac9a1e
>
> Diff: https://reviews.apache.org/r/32975/diff/
>
>
> Testing
> -------
>
> Unit testing this functionality is difficult because it would require that the user running the test to have permission to chown a file to someone other than themselves. I didn't want to add that as a requirement to build. I added the new field to the existing test cases just to see that they populate.
>
>
> Thanks,
>
> Jim Klucar
>
>