You are viewing a plain text version of this content. The canonical link for it is here.
Posted to ojb-dev@db.apache.org by Antonio Gallardo <ag...@agsoftware.dnsalias.com> on 2004/01/10 03:28:27 UTC

Reviewing code.

Hi:

I found this interesting link:

http://cvs.apache.org/~tcopeland/pmdweb/

It reports unused code in many Apache project include OJB. I think we can
see it and try to fix them.

Before the 1.0 will be great!

WDYT? (What do you think?)

Best Regards,

Antonio Gallardo.



---------------------------------------------------------------------
To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
For additional commands, e-mail: ojb-dev-help@db.apache.org


Re: Reviewing code.

Posted by Jakob Braeuchi <jb...@gmx.ch>.
hi all,

i had a look at pmdweb and configured *eclipse* to flag unused code.

most of the listed problems are due to generated code (OQLLexer and 
...PropertySheet). there are some minor problems in other classes as well, 
mainly caused by unused parameters or unused private (ie. Logger) or local 
variables.

jakob

Thomas Mahler wrote:

> Hi again Antonio,
> 
> I always appreciate improving the code base. Using Code metrics is a 
> good and formal way to approach this task!
> 
> So I'm +1 for your suggestion.
> 
> I think we could add a code metrics report to the normal build routine. 
> Any Ideas which tool to use?
> 
> cu,
> Thomas
> 
> Antonio Gallardo wrote:
> 
>> Hi:
>>
>> I found this interesting link:
>>
>> http://cvs.apache.org/~tcopeland/pmdweb/
>>
>> It reports unused code in many Apache project include OJB. I think we can
>> see it and try to fix them.
>>
>> Before the 1.0 will be great!
>>
>> WDYT? (What do you think?)
>>
>> Best Regards,
>>
>> Antonio Gallardo.
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
>> For additional commands, e-mail: ojb-dev-help@db.apache.org
>>
>>
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
> For additional commands, e-mail: ojb-dev-help@db.apache.org
> 
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
For additional commands, e-mail: ojb-dev-help@db.apache.org


Re: Reviewing code.

Posted by Thomas Mahler <th...@web.de>.
Hi again Antonio,

I always appreciate improving the code base. Using Code metrics is a 
good and formal way to approach this task!

So I'm +1 for your suggestion.

I think we could add a code metrics report to the normal build routine. 
Any Ideas which tool to use?

cu,
Thomas

Antonio Gallardo wrote:
> Hi:
> 
> I found this interesting link:
> 
> http://cvs.apache.org/~tcopeland/pmdweb/
> 
> It reports unused code in many Apache project include OJB. I think we can
> see it and try to fix them.
> 
> Before the 1.0 will be great!
> 
> WDYT? (What do you think?)
> 
> Best Regards,
> 
> Antonio Gallardo.
> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
> For additional commands, e-mail: ojb-dev-help@db.apache.org
> 
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: ojb-dev-unsubscribe@db.apache.org
For additional commands, e-mail: ojb-dev-help@db.apache.org