You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@drill.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/11/13 18:10:00 UTC
[jira] [Commented] (DRILL-6246) Build Failing in jdbc-all artifact
[ https://issues.apache.org/jira/browse/DRILL-6246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16685561#comment-16685561 ]
ASF GitHub Bot commented on DRILL-6246:
---------------------------------------
sachouche closed pull request #1168: DRILL-6246: Reduced the size of the jdbc-all jar file
URL: https://github.com/apache/drill/pull/1168
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/exec/jdbc-all/pom.xml b/exec/jdbc-all/pom.xml
index 7a6c9eeb0f8..d209f3694b5 100644
--- a/exec/jdbc-all/pom.xml
+++ b/exec/jdbc-all/pom.xml
@@ -485,6 +485,8 @@
<exclude>org/yaml/**</exclude>
<exclude>hello/**</exclude>
<exclude>webapps/**</exclude>
+ <exclude>**/org/apache/calcite/avatica/metrics/**</exclude>
+ <exclude>**/org/apache/calcite/avatica/org/**</exclude>
</excludes>
</filter>
</filters>
@@ -511,7 +513,7 @@
This is likely due to you adding new dependencies to a java-exec and not updating the excludes in this module. This is important as it minimizes the size of the dependency of Drill application users.
</message>
- <maxsize>39000000</maxsize>
+ <maxsize>38000000</maxsize>
<minsize>15000000</minsize>
<files>
<file>${project.build.directory}/drill-jdbc-all-${project.version}.jar</file>
@@ -571,7 +573,7 @@
This is likely due to you adding new dependencies to a java-exec and not updating the excludes in this module. This is important as it minimizes the size of the dependency of Drill application users.
</message>
- <maxsize>37000000</maxsize>
+ <maxsize>35000000</maxsize>
<minsize>15000000</minsize>
<files>
<file>${project.build.directory}/drill-jdbc-all-${project.version}.jar</file>
@@ -788,6 +790,8 @@
<exclude>org/yaml/**</exclude>
<exclude>hello/**</exclude>
<exclude>webapps/**</exclude>
+ <exclude>**/org/apache/calcite/avatica/metrics/**</exclude>
+ <exclude>**/org/apache/calcite/avatica/org/**</exclude>
</excludes>
</filter>
</filters>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Build Failing in jdbc-all artifact
> ----------------------------------
>
> Key: DRILL-6246
> URL: https://issues.apache.org/jira/browse/DRILL-6246
> Project: Apache Drill
> Issue Type: Bug
> Components: Client - JDBC
> Affects Versions: 1.13.0
> Reporter: salim achouche
> Assignee: salim achouche
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.15.0
>
>
> * {color:#000000}It was noticed that the build was failing because of the jdbc-all artifact{color}
> * {color:#000000}The maximum compressed jar size was set to 32MB but we are currently creating a JAR a bit larger than 32MB {color}
> * {color:#000000}I compared apache drill-1.10.0, drill-1.12.0, and drill-1.13.0 (on my MacOS){color}
> * {color:#000000}jdbc-all-1.10.0 jar size: 21MB{color}
> * {color:#000000}jdbc-all-1.12.0 jar size: 27MB{color}
> * {color:#000000}jdbc-all-1.13.0 jar size: 34MB (on Linux this size is roughly 32MB){color}
> * {color:#000000}Compared then in more details jdbc-all-1.12.0 and jdbc-all-1.13.0{color}
> * {color:#000000}The bulk of the increase is attributed to the calcite artifact{color}
> * {color:#000000}Used to be 2MB (uncompressed) and now 22MB (uncompressed){color}
> * {color:#000000}It is likely an exclusion problem {color}
> * {color:#000000}The jdbc-all-1.12.0 version has only two top packages calcite/avatica/utils and calcite/avatica/remote{color}
> * {color:#000000}The jdbc-all-1.13.0 includes new packages (within calcite/avatica) metrics, proto, org/apache/, com/fasterxml, com/google{color}
> {color:#000000} {color}
> {color:#000000}I am planning to exclude these new sub-packages{color}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)