You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2021/08/16 14:17:56 UTC

[GitHub] [servicecomb-service-center] little-cui commented on a change in pull request #1138: add disabled situation

little-cui commented on a change in pull request #1138:
URL: https://github.com/apache/servicecomb-service-center/pull/1138#discussion_r689578243



##########
File path: server/service/rbac/context.go
##########
@@ -52,10 +52,12 @@ func AccountFromContext(ctx context.Context) (*rbacmodel.Account, error) {
 }
 
 func SignRequest(req *http.Request) error {
-	auth := token.FromContext(req.Context())
-	if auth == "" {
-		return errors.New("request unauthorized")
+	if Enabled() {

Review comment:
       SignRequest已经职责是明确要认证的场景，不应该在这里增加不认证的分支，应该在kie client初始化的地方进行判断




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org