You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/12/23 09:22:38 UTC
[GitHub] [incubator-eventmesh] Alonexc opened a new issue, #2668: [Enhancement] Method appears to call the same method on the same object redundantly [RemoteSubscribeEventProcessor]
Alonexc opened a new issue, #2668:
URL: https://github.com/apache/incubator-eventmesh/issues/2668
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no similar issues.
### Enhancement Request
located at:
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/processor/RemoteSubscribeEventProcessor.java line 87,103,213,222
analysis and explanation:
This method makes two consecutive calls to the same method, using the same constant parameters, on the same instance, without any intervening changes to the objects. If this method does not make changes to the object, which it appears it doesn't, then making two calls is just a waste.
### Describe the solution you'd like
These method calls could be combined by assigning the result into a temporary variable, and using the variable the second time.
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] jonyangx closed issue #2668: [Enhancement] Method appears to call the same method on the same object redundantly [RemoteSubscribeEventProcessor]
Posted by GitBox <gi...@apache.org>.
jonyangx closed issue #2668: [Enhancement] Method appears to call the same method on the same object redundantly [RemoteSubscribeEventProcessor]
URL: https://github.com/apache/incubator-eventmesh/issues/2668
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org