[GitHub] [iotdb] ericpai commented on a change in pull request #5173: [IOTDB-2692] Fix compaction exception caused by deleted timeseries

[GitBox <gi...@apache.org>]

ericpai commented on a change in pull request #5173:
URL: https://github.com/apache/iotdb/pull/5173#discussion_r820446976



##########
File path: server/src/main/java/org/apache/iotdb/db/engine/compaction/CompactionUtils.java
##########
@@ -125,8 +125,12 @@ private static void compactAlignedSeries(
     List<IMeasurementSchema> measurementSchemas = new ArrayList<>();
     for (String measurement : allMeasurments) {
       // TODO: use IDTable
-      measurementSchemas.add(
-          IoTDB.metaManager.getSeriesSchema(new PartialPath(device, measurement)));
+      PartialPath p = new PartialPath(device, measurement);
+      if (!IoTDB.metaManager.isPathExist(p)) {
+        logger.info("As path {} is dropped we skip it", p.getFullPath());
+        continue;
+      }

Review comment:
       That's a good catch, maybe we can just catch the exception without pre existence check?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org