You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Yip Ng (JIRA)" <ji...@apache.org> on 2007/02/17 10:26:05 UTC
[jira] Created: (DERBY-2352) Assertion Failure with order by
expression
Assertion Failure with order by expression
------------------------------------------
Key: DERBY-2352
URL: https://issues.apache.org/jira/browse/DERBY-2352
Project: Derby
Issue Type: Bug
Components: SQL
Affects Versions: 10.2.2.0, 10.3.0.0
Environment: Any
Reporter: Yip Ng
Assertion failure with order by expression:
ij> select substr('abc', 1) from t1 order by substr('abc', 1);
ERROR XJ001: Java exception: 'ASSERT FAILED col1.getClass() (class org.apache.derby.iapi.types.SQLVarchar) expected to be the same as col2.getClass() (class org.apache.derby.iapi.types.SQLChar): org.apache.derby.shared.common.sanity.AssertFailure'.
Stacktrace:
org.apache.derby.shared.common.sanity.AssertFailure: ASSERT FAILED col1.getClass() (class org.apache.derby.iapi.types.SQLVarchar) expected to be the same as col2.getClass() (class org.apache.derby.iapi.types.SQLChar)
at org.apache.derby.shared.common.sanity.SanityManager.THROWASSERT(SanityManager.java:149)
at org.apache.derby.impl.store.access.sort.MergeSort.checkColumnTypes(MergeSort.java:472)
at org.apache.derby.impl.store.access.sort.MergeInserter.insert(MergeInserter.java:106)
at org.apache.derby.impl.sql.execute.SortResultSet.loadSorter(SortResultSet.java:318)
at org.apache.derby.impl.sql.execute.SortResultSet.openCore(SortResultSet.java:269)
at org.apache.derby.impl.sql.execute.ProjectRestrictResultSet.openCore(ProjectRestrictResultSet.java:169)
at org.apache.derby.impl.sql.execute.BasicNoPutResultSetImpl.open(BasicNoPutResultSetImpl.java:260)
at org.apache.derby.impl.sql.GenericPreparedStatement.execute(GenericPreparedStatement.java:358)
at org.apache.derby.impl.jdbc.EmbedStatement.executeStatement(EmbedStatement.java:1182)
at org.apache.derby.impl.jdbc.EmbedStatement.execute(EmbedStatement.java:585)
at org.apache.derby.impl.jdbc.EmbedStatement.execute(EmbedStatement.java:517)
at org.apache.derby.impl.tools.ij.ij.executeImmediate(ij.java:321)
at org.apache.derby.impl.tools.ij.utilMain.doCatch(utilMain.java:517)
at org.apache.derby.impl.tools.ij.utilMain.runScriptGuts(utilMain.java:370)
at org.apache.derby.impl.tools.ij.utilMain.go(utilMain.java:268)
at org.apache.derby.impl.tools.ij.Main.go(Main.java:204)
at org.apache.derby.impl.tools.ij.Main.mainCore(Main.java:170)
at org.apache.derby.impl.tools.ij.Main14.main(Main14.java:56)
at org.apache.derby.tools.ij.main(ij.java:71)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (DERBY-2352) Assertion Failure with order by and
group by expression
Posted by "Bryan Pendleton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Pendleton resolved DERBY-2352.
------------------------------------
Resolution: Fixed
Fix Version/s: 10.4.0.0
10.3.1.5
Derby Info: (was: [Patch Available])
Merged the change to the 10.3 branch and submitted as revision 597516.
> Assertion Failure with order by and group by expression
> -------------------------------------------------------
>
> Key: DERBY-2352
> URL: https://issues.apache.org/jira/browse/DERBY-2352
> Project: Derby
> Issue Type: Bug
> Components: SQL
> Affects Versions: 10.2.2.0, 10.3.1.4
> Environment: Any
> Reporter: Yip Ng
> Assignee: Bryan Pendleton
> Fix For: 10.3.1.5, 10.4.0.0
>
> Attachments: substrBind.diff, substrBindWithTests.diff, substrBindWithTestsUpdated.diff, substringReturnsChar.diff
>
>
> Assertion failure with order by expression:
> ij> select substr('abc', 1) from t1 order by substr('abc', 1);
> ERROR XJ001: Java exception: 'ASSERT FAILED col1.getClass() (class org.apache.derby.iapi.types.SQLVarchar) expected to be the same as col2.getClass() (class org.apache.derby.iapi.types.SQLChar): org.apache.derby.shared.common.sanity.AssertFailure'.
> Stacktrace:
> org.apache.derby.shared.common.sanity.AssertFailure: ASSERT FAILED col1.getClass() (class org.apache.derby.iapi.types.SQLVarchar) expected to be the same as col2.getClass() (class org.apache.derby.iapi.types.SQLChar)
> at org.apache.derby.shared.common.sanity.SanityManager.THROWASSERT(SanityManager.java:149)
> at org.apache.derby.impl.store.access.sort.MergeSort.checkColumnTypes(MergeSort.java:472)
> at org.apache.derby.impl.store.access.sort.MergeInserter.insert(MergeInserter.java:106)
> at org.apache.derby.impl.sql.execute.SortResultSet.loadSorter(SortResultSet.java:318)
> at org.apache.derby.impl.sql.execute.SortResultSet.openCore(SortResultSet.java:269)
> at org.apache.derby.impl.sql.execute.ProjectRestrictResultSet.openCore(ProjectRestrictResultSet.java:169)
> at org.apache.derby.impl.sql.execute.BasicNoPutResultSetImpl.open(BasicNoPutResultSetImpl.java:260)
> at org.apache.derby.impl.sql.GenericPreparedStatement.execute(GenericPreparedStatement.java:358)
> at org.apache.derby.impl.jdbc.EmbedStatement.executeStatement(EmbedStatement.java:1182)
> at org.apache.derby.impl.jdbc.EmbedStatement.execute(EmbedStatement.java:585)
> at org.apache.derby.impl.jdbc.EmbedStatement.execute(EmbedStatement.java:517)
> at org.apache.derby.impl.tools.ij.ij.executeImmediate(ij.java:321)
> at org.apache.derby.impl.tools.ij.utilMain.doCatch(utilMain.java:517)
> at org.apache.derby.impl.tools.ij.utilMain.runScriptGuts(utilMain.java:370)
> at org.apache.derby.impl.tools.ij.utilMain.go(utilMain.java:268)
> at org.apache.derby.impl.tools.ij.Main.go(Main.java:204)
> at org.apache.derby.impl.tools.ij.Main.mainCore(Main.java:170)
> at org.apache.derby.impl.tools.ij.Main14.main(Main14.java:56)
> at org.apache.derby.tools.ij.main(ij.java:71)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2352) Assertion Failure with order by and
group by expression
Posted by "Bryan Pendleton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12536900 ]
Bryan Pendleton commented on DERBY-2352:
----------------------------------------
LTRIM and TRIM (TRAILING) don't obviously suffer from the same problem as SUBSTR:
ij> connect 'jdbc:derby:brydb';
ij(CONNECTION1)> select ltrim('abc') from d2352 order by ltrim('abc');
1
----
abc
1 row selected
ij(CONNECTION1)> select trim(trailing ' ' from 'abc') from d2352 order by trim(trailing ' ' from 'abc');
1
----
abc
1 row selected
> Assertion Failure with order by and group by expression
> -------------------------------------------------------
>
> Key: DERBY-2352
> URL: https://issues.apache.org/jira/browse/DERBY-2352
> Project: Derby
> Issue Type: Bug
> Components: SQL
> Affects Versions: 10.2.2.0, 10.3.1.4
> Environment: Any
> Reporter: Yip Ng
> Assignee: Bryan Pendleton
> Attachments: substringReturnsChar.diff
>
>
> Assertion failure with order by expression:
> ij> select substr('abc', 1) from t1 order by substr('abc', 1);
> ERROR XJ001: Java exception: 'ASSERT FAILED col1.getClass() (class org.apache.derby.iapi.types.SQLVarchar) expected to be the same as col2.getClass() (class org.apache.derby.iapi.types.SQLChar): org.apache.derby.shared.common.sanity.AssertFailure'.
> Stacktrace:
> org.apache.derby.shared.common.sanity.AssertFailure: ASSERT FAILED col1.getClass() (class org.apache.derby.iapi.types.SQLVarchar) expected to be the same as col2.getClass() (class org.apache.derby.iapi.types.SQLChar)
> at org.apache.derby.shared.common.sanity.SanityManager.THROWASSERT(SanityManager.java:149)
> at org.apache.derby.impl.store.access.sort.MergeSort.checkColumnTypes(MergeSort.java:472)
> at org.apache.derby.impl.store.access.sort.MergeInserter.insert(MergeInserter.java:106)
> at org.apache.derby.impl.sql.execute.SortResultSet.loadSorter(SortResultSet.java:318)
> at org.apache.derby.impl.sql.execute.SortResultSet.openCore(SortResultSet.java:269)
> at org.apache.derby.impl.sql.execute.ProjectRestrictResultSet.openCore(ProjectRestrictResultSet.java:169)
> at org.apache.derby.impl.sql.execute.BasicNoPutResultSetImpl.open(BasicNoPutResultSetImpl.java:260)
> at org.apache.derby.impl.sql.GenericPreparedStatement.execute(GenericPreparedStatement.java:358)
> at org.apache.derby.impl.jdbc.EmbedStatement.executeStatement(EmbedStatement.java:1182)
> at org.apache.derby.impl.jdbc.EmbedStatement.execute(EmbedStatement.java:585)
> at org.apache.derby.impl.jdbc.EmbedStatement.execute(EmbedStatement.java:517)
> at org.apache.derby.impl.tools.ij.ij.executeImmediate(ij.java:321)
> at org.apache.derby.impl.tools.ij.utilMain.doCatch(utilMain.java:517)
> at org.apache.derby.impl.tools.ij.utilMain.runScriptGuts(utilMain.java:370)
> at org.apache.derby.impl.tools.ij.utilMain.go(utilMain.java:268)
> at org.apache.derby.impl.tools.ij.Main.go(Main.java:204)
> at org.apache.derby.impl.tools.ij.Main.mainCore(Main.java:170)
> at org.apache.derby.impl.tools.ij.Main14.main(Main14.java:56)
> at org.apache.derby.tools.ij.main(ij.java:71)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2352) Assertion Failure with order by and
group by expression
Posted by "Bryan Pendleton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12543610 ]
Bryan Pendleton commented on DERBY-2352:
----------------------------------------
Thanks Thomas for the feedback and testing and suggestions! I'll try to clean these
up when I commit the change.
> Assertion Failure with order by and group by expression
> -------------------------------------------------------
>
> Key: DERBY-2352
> URL: https://issues.apache.org/jira/browse/DERBY-2352
> Project: Derby
> Issue Type: Bug
> Components: SQL
> Affects Versions: 10.2.2.0, 10.3.1.4
> Environment: Any
> Reporter: Yip Ng
> Assignee: Bryan Pendleton
> Attachments: substrBind.diff, substrBindWithTests.diff, substringReturnsChar.diff
>
>
> Assertion failure with order by expression:
> ij> select substr('abc', 1) from t1 order by substr('abc', 1);
> ERROR XJ001: Java exception: 'ASSERT FAILED col1.getClass() (class org.apache.derby.iapi.types.SQLVarchar) expected to be the same as col2.getClass() (class org.apache.derby.iapi.types.SQLChar): org.apache.derby.shared.common.sanity.AssertFailure'.
> Stacktrace:
> org.apache.derby.shared.common.sanity.AssertFailure: ASSERT FAILED col1.getClass() (class org.apache.derby.iapi.types.SQLVarchar) expected to be the same as col2.getClass() (class org.apache.derby.iapi.types.SQLChar)
> at org.apache.derby.shared.common.sanity.SanityManager.THROWASSERT(SanityManager.java:149)
> at org.apache.derby.impl.store.access.sort.MergeSort.checkColumnTypes(MergeSort.java:472)
> at org.apache.derby.impl.store.access.sort.MergeInserter.insert(MergeInserter.java:106)
> at org.apache.derby.impl.sql.execute.SortResultSet.loadSorter(SortResultSet.java:318)
> at org.apache.derby.impl.sql.execute.SortResultSet.openCore(SortResultSet.java:269)
> at org.apache.derby.impl.sql.execute.ProjectRestrictResultSet.openCore(ProjectRestrictResultSet.java:169)
> at org.apache.derby.impl.sql.execute.BasicNoPutResultSetImpl.open(BasicNoPutResultSetImpl.java:260)
> at org.apache.derby.impl.sql.GenericPreparedStatement.execute(GenericPreparedStatement.java:358)
> at org.apache.derby.impl.jdbc.EmbedStatement.executeStatement(EmbedStatement.java:1182)
> at org.apache.derby.impl.jdbc.EmbedStatement.execute(EmbedStatement.java:585)
> at org.apache.derby.impl.jdbc.EmbedStatement.execute(EmbedStatement.java:517)
> at org.apache.derby.impl.tools.ij.ij.executeImmediate(ij.java:321)
> at org.apache.derby.impl.tools.ij.utilMain.doCatch(utilMain.java:517)
> at org.apache.derby.impl.tools.ij.utilMain.runScriptGuts(utilMain.java:370)
> at org.apache.derby.impl.tools.ij.utilMain.go(utilMain.java:268)
> at org.apache.derby.impl.tools.ij.Main.go(Main.java:204)
> at org.apache.derby.impl.tools.ij.Main.mainCore(Main.java:170)
> at org.apache.derby.impl.tools.ij.Main14.main(Main14.java:56)
> at org.apache.derby.tools.ij.main(ij.java:71)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2352) Assertion Failure with order by and
group by expression
Posted by "Bryan Pendleton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12543307 ]
Bryan Pendleton commented on DERBY-2352:
----------------------------------------
Perhaps there are no longer any code paths which lead to SQLChar.trim,
but instead the code always goes to SQLChar.ansiTrim.
I'll try looking at code coverage results to see if they indicate that trim() is ever called.
> Assertion Failure with order by and group by expression
> -------------------------------------------------------
>
> Key: DERBY-2352
> URL: https://issues.apache.org/jira/browse/DERBY-2352
> Project: Derby
> Issue Type: Bug
> Components: SQL
> Affects Versions: 10.2.2.0, 10.3.1.4
> Environment: Any
> Reporter: Yip Ng
> Assignee: Bryan Pendleton
> Attachments: substringReturnsChar.diff
>
>
> Assertion failure with order by expression:
> ij> select substr('abc', 1) from t1 order by substr('abc', 1);
> ERROR XJ001: Java exception: 'ASSERT FAILED col1.getClass() (class org.apache.derby.iapi.types.SQLVarchar) expected to be the same as col2.getClass() (class org.apache.derby.iapi.types.SQLChar): org.apache.derby.shared.common.sanity.AssertFailure'.
> Stacktrace:
> org.apache.derby.shared.common.sanity.AssertFailure: ASSERT FAILED col1.getClass() (class org.apache.derby.iapi.types.SQLVarchar) expected to be the same as col2.getClass() (class org.apache.derby.iapi.types.SQLChar)
> at org.apache.derby.shared.common.sanity.SanityManager.THROWASSERT(SanityManager.java:149)
> at org.apache.derby.impl.store.access.sort.MergeSort.checkColumnTypes(MergeSort.java:472)
> at org.apache.derby.impl.store.access.sort.MergeInserter.insert(MergeInserter.java:106)
> at org.apache.derby.impl.sql.execute.SortResultSet.loadSorter(SortResultSet.java:318)
> at org.apache.derby.impl.sql.execute.SortResultSet.openCore(SortResultSet.java:269)
> at org.apache.derby.impl.sql.execute.ProjectRestrictResultSet.openCore(ProjectRestrictResultSet.java:169)
> at org.apache.derby.impl.sql.execute.BasicNoPutResultSetImpl.open(BasicNoPutResultSetImpl.java:260)
> at org.apache.derby.impl.sql.GenericPreparedStatement.execute(GenericPreparedStatement.java:358)
> at org.apache.derby.impl.jdbc.EmbedStatement.executeStatement(EmbedStatement.java:1182)
> at org.apache.derby.impl.jdbc.EmbedStatement.execute(EmbedStatement.java:585)
> at org.apache.derby.impl.jdbc.EmbedStatement.execute(EmbedStatement.java:517)
> at org.apache.derby.impl.tools.ij.ij.executeImmediate(ij.java:321)
> at org.apache.derby.impl.tools.ij.utilMain.doCatch(utilMain.java:517)
> at org.apache.derby.impl.tools.ij.utilMain.runScriptGuts(utilMain.java:370)
> at org.apache.derby.impl.tools.ij.utilMain.go(utilMain.java:268)
> at org.apache.derby.impl.tools.ij.Main.go(Main.java:204)
> at org.apache.derby.impl.tools.ij.Main.mainCore(Main.java:170)
> at org.apache.derby.impl.tools.ij.Main14.main(Main14.java:56)
> at org.apache.derby.tools.ij.main(ij.java:71)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2352) Assertion Failure with order by and
group by expression
Posted by "Bryan Pendleton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12536345 ]
Bryan Pendleton commented on DERBY-2352:
----------------------------------------
Modifying SQLChar.getNewVarchar() will affect SQLChar.substring(),
SQLChar.trim(), and SQLChar.ansiTrim().
I'm not clear on the difference between trim() and ansiTrim(). May have to set
breakpoints to try to figure out which one is called by what SQL. I think that
the difference may involve LTRIM vs TRIM LEADING and RTRIM vs
TRIM TRAILING
I see that in our docs, we state explicitly that TRIM and SUBSTR return
a value of type VARCHAR. For example,
http://db.apache.org/derby/docs/10.3/ref/rreftrimfunc.html
So if we change this we'll need to change some docs.
The docs also talk about how these functions work with CLOB types, which
indicates that any complete patch built on substringReturnsChar.diff would
need to have tests that include CLOB.
So, to turn substringReturnsChar.diff into a complete patch, I need to:
- figure out exactly what SQL functions cause us to arrive at the
SQLChar methods 'substring', 'trim', and 'ansiTrim'.
- write tests which use those SQL functions in both ORDER BY and
GROUP BY expressions
- ensure that those tests cover CHAR, VARCHAR, LONG VARCHAR,
CHAR FOR BIT DATA, VARCHAR FOR BIT DATA,
LONG VARCHAR FOR BIT DATA, BLOB, and CLOB data types.
> Assertion Failure with order by and group by expression
> -------------------------------------------------------
>
> Key: DERBY-2352
> URL: https://issues.apache.org/jira/browse/DERBY-2352
> Project: Derby
> Issue Type: Bug
> Components: SQL
> Affects Versions: 10.2.2.0, 10.3.1.4
> Environment: Any
> Reporter: Yip Ng
> Assignee: Bryan Pendleton
> Attachments: substringReturnsChar.diff
>
>
> Assertion failure with order by expression:
> ij> select substr('abc', 1) from t1 order by substr('abc', 1);
> ERROR XJ001: Java exception: 'ASSERT FAILED col1.getClass() (class org.apache.derby.iapi.types.SQLVarchar) expected to be the same as col2.getClass() (class org.apache.derby.iapi.types.SQLChar): org.apache.derby.shared.common.sanity.AssertFailure'.
> Stacktrace:
> org.apache.derby.shared.common.sanity.AssertFailure: ASSERT FAILED col1.getClass() (class org.apache.derby.iapi.types.SQLVarchar) expected to be the same as col2.getClass() (class org.apache.derby.iapi.types.SQLChar)
> at org.apache.derby.shared.common.sanity.SanityManager.THROWASSERT(SanityManager.java:149)
> at org.apache.derby.impl.store.access.sort.MergeSort.checkColumnTypes(MergeSort.java:472)
> at org.apache.derby.impl.store.access.sort.MergeInserter.insert(MergeInserter.java:106)
> at org.apache.derby.impl.sql.execute.SortResultSet.loadSorter(SortResultSet.java:318)
> at org.apache.derby.impl.sql.execute.SortResultSet.openCore(SortResultSet.java:269)
> at org.apache.derby.impl.sql.execute.ProjectRestrictResultSet.openCore(ProjectRestrictResultSet.java:169)
> at org.apache.derby.impl.sql.execute.BasicNoPutResultSetImpl.open(BasicNoPutResultSetImpl.java:260)
> at org.apache.derby.impl.sql.GenericPreparedStatement.execute(GenericPreparedStatement.java:358)
> at org.apache.derby.impl.jdbc.EmbedStatement.executeStatement(EmbedStatement.java:1182)
> at org.apache.derby.impl.jdbc.EmbedStatement.execute(EmbedStatement.java:585)
> at org.apache.derby.impl.jdbc.EmbedStatement.execute(EmbedStatement.java:517)
> at org.apache.derby.impl.tools.ij.ij.executeImmediate(ij.java:321)
> at org.apache.derby.impl.tools.ij.utilMain.doCatch(utilMain.java:517)
> at org.apache.derby.impl.tools.ij.utilMain.runScriptGuts(utilMain.java:370)
> at org.apache.derby.impl.tools.ij.utilMain.go(utilMain.java:268)
> at org.apache.derby.impl.tools.ij.Main.go(Main.java:204)
> at org.apache.derby.impl.tools.ij.Main.mainCore(Main.java:170)
> at org.apache.derby.impl.tools.ij.Main14.main(Main14.java:56)
> at org.apache.derby.tools.ij.main(ij.java:71)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2352) Assertion Failure with order by and
group by expression
Posted by "Thomas Nielsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12543540 ]
Thomas Nielsen commented on DERBY-2352:
---------------------------------------
Since you will touch TernaryOperatorNode.java anyway, there's
- an unused import of 'org.apache.derby.iapi.sql.dictionary.DataDictionary'
- an unused import of 'org.apache.derby.iapi.types.NumberDataValue'
- an unused import of 'org.apache.derby.iapi.store.access.Qualifier'
- an import from the same package of 'org.apache.derby.impl.sql.compile.ExpressionClassBuilder'
These could possibly be cleaned up?
Both suites.All and derbyAll ran successfully for me as well.
> Assertion Failure with order by and group by expression
> -------------------------------------------------------
>
> Key: DERBY-2352
> URL: https://issues.apache.org/jira/browse/DERBY-2352
> Project: Derby
> Issue Type: Bug
> Components: SQL
> Affects Versions: 10.2.2.0, 10.3.1.4
> Environment: Any
> Reporter: Yip Ng
> Assignee: Bryan Pendleton
> Attachments: substrBind.diff, substrBindWithTests.diff, substringReturnsChar.diff
>
>
> Assertion failure with order by expression:
> ij> select substr('abc', 1) from t1 order by substr('abc', 1);
> ERROR XJ001: Java exception: 'ASSERT FAILED col1.getClass() (class org.apache.derby.iapi.types.SQLVarchar) expected to be the same as col2.getClass() (class org.apache.derby.iapi.types.SQLChar): org.apache.derby.shared.common.sanity.AssertFailure'.
> Stacktrace:
> org.apache.derby.shared.common.sanity.AssertFailure: ASSERT FAILED col1.getClass() (class org.apache.derby.iapi.types.SQLVarchar) expected to be the same as col2.getClass() (class org.apache.derby.iapi.types.SQLChar)
> at org.apache.derby.shared.common.sanity.SanityManager.THROWASSERT(SanityManager.java:149)
> at org.apache.derby.impl.store.access.sort.MergeSort.checkColumnTypes(MergeSort.java:472)
> at org.apache.derby.impl.store.access.sort.MergeInserter.insert(MergeInserter.java:106)
> at org.apache.derby.impl.sql.execute.SortResultSet.loadSorter(SortResultSet.java:318)
> at org.apache.derby.impl.sql.execute.SortResultSet.openCore(SortResultSet.java:269)
> at org.apache.derby.impl.sql.execute.ProjectRestrictResultSet.openCore(ProjectRestrictResultSet.java:169)
> at org.apache.derby.impl.sql.execute.BasicNoPutResultSetImpl.open(BasicNoPutResultSetImpl.java:260)
> at org.apache.derby.impl.sql.GenericPreparedStatement.execute(GenericPreparedStatement.java:358)
> at org.apache.derby.impl.jdbc.EmbedStatement.executeStatement(EmbedStatement.java:1182)
> at org.apache.derby.impl.jdbc.EmbedStatement.execute(EmbedStatement.java:585)
> at org.apache.derby.impl.jdbc.EmbedStatement.execute(EmbedStatement.java:517)
> at org.apache.derby.impl.tools.ij.ij.executeImmediate(ij.java:321)
> at org.apache.derby.impl.tools.ij.utilMain.doCatch(utilMain.java:517)
> at org.apache.derby.impl.tools.ij.utilMain.runScriptGuts(utilMain.java:370)
> at org.apache.derby.impl.tools.ij.utilMain.go(utilMain.java:268)
> at org.apache.derby.impl.tools.ij.Main.go(Main.java:204)
> at org.apache.derby.impl.tools.ij.Main.mainCore(Main.java:170)
> at org.apache.derby.impl.tools.ij.Main14.main(Main14.java:56)
> at org.apache.derby.tools.ij.main(ij.java:71)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2352) Assertion Failure with order by and
group by expression
Posted by "Bryan Pendleton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Pendleton updated DERBY-2352:
-----------------------------------
Attachment: substrBind.diff
Attached is substrBind.diff, an alternate idea for a patch.
I found myself interested in why the rowAllocator method for
select substr('abc', 1) from d2352 order by substr('abc', 1);
is different from the rowAllocator method that is generated for
select ltrim('abc') from d2352 order by ltrim('abc');
The SUBSTR version generates
e5.setColumn(1, getDataValueFactory().getNullChar(null));
while the LTRIM version generates
e5.setColumn(1, getDataValueFactory().getNullVarchar(null));
The generation activity happens in ResultColumnList.generateHolderMethod,
so I stepped through that code to see what was different in the two cases.
ResultColumnList.generateHolderMethod() calls ResultColumn.generateHolder()
for each result column, and that code in turn generates a null of the
appropriate type, where the type is given by the DataTypeDescriptor in
the ResultColumn, and controls the behavior of CharTypeCompiler.nullMethodName.
During bind processing, ResultColumn.bindResultColumnToExpression() sets
the ResultColumn type to the type of its expression, which in both cases
is a TernaryOperatorNode.
The TernaryOperatorNode's type is determined during bind processing. For
the TRIM expression, TernaryOperatorNode.trimBind() is called, and it
chooses a VARCHAR type except in some cases involving BLOBs.
TypeId resultType = TypeId.getBuiltInTypeId(Types.VARCHAR);
For the SUBSTR expression, TernaryOperatorNode.substrBind() is called, and
it has a completely different set of logic for choosing the result type,
which is driven by the type of the value on which we're calling SUBSTR:
resultType = receiverType = receiver.getTypeId();
In the case of SUBSTR('abc', 1), "receiver" is a CharConstantNode, and its
typeId is a CHAR type, so the resultType is set to CHAR, not VARCHAR.
The technique of substrBind() -- using the receiver's type -- also handles
CLOB/BLOB types, but it has the result of choosing CHAR in cases where
trimBind() chooses VARCHAR instead.
So it seems that an alternate solution for DERBY-2352 could be to modify
TernaryOperatorNode.substrBind() so that it chooses the result type using
a set of rules more like those used by TernaryOperatorNode.trimBind().
The attached 'substrBind.diff' implements those alternate rules, and the
resulting code successfully processes the repro script, and the generated
row allocator method now matches the code generated in the TRIM cases.
I think this is a cleaner approach than 'substringReturnsChar.diff', because
I think that the intent of the system is for SUBSTR to return a VARCHAR
type. Feedback about whether one change seems better or worse, or any other
feedback on these topics, would be most welcome.
> Assertion Failure with order by and group by expression
> -------------------------------------------------------
>
> Key: DERBY-2352
> URL: https://issues.apache.org/jira/browse/DERBY-2352
> Project: Derby
> Issue Type: Bug
> Components: SQL
> Affects Versions: 10.2.2.0, 10.3.1.4
> Environment: Any
> Reporter: Yip Ng
> Assignee: Bryan Pendleton
> Attachments: substrBind.diff, substringReturnsChar.diff
>
>
> Assertion failure with order by expression:
> ij> select substr('abc', 1) from t1 order by substr('abc', 1);
> ERROR XJ001: Java exception: 'ASSERT FAILED col1.getClass() (class org.apache.derby.iapi.types.SQLVarchar) expected to be the same as col2.getClass() (class org.apache.derby.iapi.types.SQLChar): org.apache.derby.shared.common.sanity.AssertFailure'.
> Stacktrace:
> org.apache.derby.shared.common.sanity.AssertFailure: ASSERT FAILED col1.getClass() (class org.apache.derby.iapi.types.SQLVarchar) expected to be the same as col2.getClass() (class org.apache.derby.iapi.types.SQLChar)
> at org.apache.derby.shared.common.sanity.SanityManager.THROWASSERT(SanityManager.java:149)
> at org.apache.derby.impl.store.access.sort.MergeSort.checkColumnTypes(MergeSort.java:472)
> at org.apache.derby.impl.store.access.sort.MergeInserter.insert(MergeInserter.java:106)
> at org.apache.derby.impl.sql.execute.SortResultSet.loadSorter(SortResultSet.java:318)
> at org.apache.derby.impl.sql.execute.SortResultSet.openCore(SortResultSet.java:269)
> at org.apache.derby.impl.sql.execute.ProjectRestrictResultSet.openCore(ProjectRestrictResultSet.java:169)
> at org.apache.derby.impl.sql.execute.BasicNoPutResultSetImpl.open(BasicNoPutResultSetImpl.java:260)
> at org.apache.derby.impl.sql.GenericPreparedStatement.execute(GenericPreparedStatement.java:358)
> at org.apache.derby.impl.jdbc.EmbedStatement.executeStatement(EmbedStatement.java:1182)
> at org.apache.derby.impl.jdbc.EmbedStatement.execute(EmbedStatement.java:585)
> at org.apache.derby.impl.jdbc.EmbedStatement.execute(EmbedStatement.java:517)
> at org.apache.derby.impl.tools.ij.ij.executeImmediate(ij.java:321)
> at org.apache.derby.impl.tools.ij.utilMain.doCatch(utilMain.java:517)
> at org.apache.derby.impl.tools.ij.utilMain.runScriptGuts(utilMain.java:370)
> at org.apache.derby.impl.tools.ij.utilMain.go(utilMain.java:268)
> at org.apache.derby.impl.tools.ij.Main.go(Main.java:204)
> at org.apache.derby.impl.tools.ij.Main.mainCore(Main.java:170)
> at org.apache.derby.impl.tools.ij.Main14.main(Main14.java:56)
> at org.apache.derby.tools.ij.main(ij.java:71)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2352) Assertion Failure with order by and
group by expression
Posted by "Thomas Nielsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12543805 ]
Thomas Nielsen commented on DERBY-2352:
---------------------------------------
'substrBindWithTestsUpdated.diff' looks good.
+1 to commit
> Assertion Failure with order by and group by expression
> -------------------------------------------------------
>
> Key: DERBY-2352
> URL: https://issues.apache.org/jira/browse/DERBY-2352
> Project: Derby
> Issue Type: Bug
> Components: SQL
> Affects Versions: 10.2.2.0, 10.3.1.4
> Environment: Any
> Reporter: Yip Ng
> Assignee: Bryan Pendleton
> Attachments: substrBind.diff, substrBindWithTests.diff, substrBindWithTestsUpdated.diff, substringReturnsChar.diff
>
>
> Assertion failure with order by expression:
> ij> select substr('abc', 1) from t1 order by substr('abc', 1);
> ERROR XJ001: Java exception: 'ASSERT FAILED col1.getClass() (class org.apache.derby.iapi.types.SQLVarchar) expected to be the same as col2.getClass() (class org.apache.derby.iapi.types.SQLChar): org.apache.derby.shared.common.sanity.AssertFailure'.
> Stacktrace:
> org.apache.derby.shared.common.sanity.AssertFailure: ASSERT FAILED col1.getClass() (class org.apache.derby.iapi.types.SQLVarchar) expected to be the same as col2.getClass() (class org.apache.derby.iapi.types.SQLChar)
> at org.apache.derby.shared.common.sanity.SanityManager.THROWASSERT(SanityManager.java:149)
> at org.apache.derby.impl.store.access.sort.MergeSort.checkColumnTypes(MergeSort.java:472)
> at org.apache.derby.impl.store.access.sort.MergeInserter.insert(MergeInserter.java:106)
> at org.apache.derby.impl.sql.execute.SortResultSet.loadSorter(SortResultSet.java:318)
> at org.apache.derby.impl.sql.execute.SortResultSet.openCore(SortResultSet.java:269)
> at org.apache.derby.impl.sql.execute.ProjectRestrictResultSet.openCore(ProjectRestrictResultSet.java:169)
> at org.apache.derby.impl.sql.execute.BasicNoPutResultSetImpl.open(BasicNoPutResultSetImpl.java:260)
> at org.apache.derby.impl.sql.GenericPreparedStatement.execute(GenericPreparedStatement.java:358)
> at org.apache.derby.impl.jdbc.EmbedStatement.executeStatement(EmbedStatement.java:1182)
> at org.apache.derby.impl.jdbc.EmbedStatement.execute(EmbedStatement.java:585)
> at org.apache.derby.impl.jdbc.EmbedStatement.execute(EmbedStatement.java:517)
> at org.apache.derby.impl.tools.ij.ij.executeImmediate(ij.java:321)
> at org.apache.derby.impl.tools.ij.utilMain.doCatch(utilMain.java:517)
> at org.apache.derby.impl.tools.ij.utilMain.runScriptGuts(utilMain.java:370)
> at org.apache.derby.impl.tools.ij.utilMain.go(utilMain.java:268)
> at org.apache.derby.impl.tools.ij.Main.go(Main.java:204)
> at org.apache.derby.impl.tools.ij.Main.mainCore(Main.java:170)
> at org.apache.derby.impl.tools.ij.Main14.main(Main14.java:56)
> at org.apache.derby.tools.ij.main(ij.java:71)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2352) Assertion Failure with order by and
group by expression
Posted by "Bryan Pendleton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12544062 ]
Bryan Pendleton commented on DERBY-2352:
----------------------------------------
Thanks Thomas! I committed substrBindWithTestsUpdated.diff to the
trunk as revision 596824. I will investigate merging this patch to 10.3,
hopefully by Nov 25 so that it can make the 10.3.2 release.
> Assertion Failure with order by and group by expression
> -------------------------------------------------------
>
> Key: DERBY-2352
> URL: https://issues.apache.org/jira/browse/DERBY-2352
> Project: Derby
> Issue Type: Bug
> Components: SQL
> Affects Versions: 10.2.2.0, 10.3.1.4
> Environment: Any
> Reporter: Yip Ng
> Assignee: Bryan Pendleton
> Attachments: substrBind.diff, substrBindWithTests.diff, substrBindWithTestsUpdated.diff, substringReturnsChar.diff
>
>
> Assertion failure with order by expression:
> ij> select substr('abc', 1) from t1 order by substr('abc', 1);
> ERROR XJ001: Java exception: 'ASSERT FAILED col1.getClass() (class org.apache.derby.iapi.types.SQLVarchar) expected to be the same as col2.getClass() (class org.apache.derby.iapi.types.SQLChar): org.apache.derby.shared.common.sanity.AssertFailure'.
> Stacktrace:
> org.apache.derby.shared.common.sanity.AssertFailure: ASSERT FAILED col1.getClass() (class org.apache.derby.iapi.types.SQLVarchar) expected to be the same as col2.getClass() (class org.apache.derby.iapi.types.SQLChar)
> at org.apache.derby.shared.common.sanity.SanityManager.THROWASSERT(SanityManager.java:149)
> at org.apache.derby.impl.store.access.sort.MergeSort.checkColumnTypes(MergeSort.java:472)
> at org.apache.derby.impl.store.access.sort.MergeInserter.insert(MergeInserter.java:106)
> at org.apache.derby.impl.sql.execute.SortResultSet.loadSorter(SortResultSet.java:318)
> at org.apache.derby.impl.sql.execute.SortResultSet.openCore(SortResultSet.java:269)
> at org.apache.derby.impl.sql.execute.ProjectRestrictResultSet.openCore(ProjectRestrictResultSet.java:169)
> at org.apache.derby.impl.sql.execute.BasicNoPutResultSetImpl.open(BasicNoPutResultSetImpl.java:260)
> at org.apache.derby.impl.sql.GenericPreparedStatement.execute(GenericPreparedStatement.java:358)
> at org.apache.derby.impl.jdbc.EmbedStatement.executeStatement(EmbedStatement.java:1182)
> at org.apache.derby.impl.jdbc.EmbedStatement.execute(EmbedStatement.java:585)
> at org.apache.derby.impl.jdbc.EmbedStatement.execute(EmbedStatement.java:517)
> at org.apache.derby.impl.tools.ij.ij.executeImmediate(ij.java:321)
> at org.apache.derby.impl.tools.ij.utilMain.doCatch(utilMain.java:517)
> at org.apache.derby.impl.tools.ij.utilMain.runScriptGuts(utilMain.java:370)
> at org.apache.derby.impl.tools.ij.utilMain.go(utilMain.java:268)
> at org.apache.derby.impl.tools.ij.Main.go(Main.java:204)
> at org.apache.derby.impl.tools.ij.Main.mainCore(Main.java:170)
> at org.apache.derby.impl.tools.ij.Main14.main(Main14.java:56)
> at org.apache.derby.tools.ij.main(ij.java:71)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2352) Assertion Failure with order by and
group by expression
Posted by "Yip Ng (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yip Ng updated DERBY-2352:
--------------------------
Summary: Assertion Failure with order by and group by expression (was: Assertion Failure with order by expression)
> Assertion Failure with order by and group by expression
> -------------------------------------------------------
>
> Key: DERBY-2352
> URL: https://issues.apache.org/jira/browse/DERBY-2352
> Project: Derby
> Issue Type: Bug
> Components: SQL
> Affects Versions: 10.2.2.0, 10.3.0.0
> Environment: Any
> Reporter: Yip Ng
>
> Assertion failure with order by expression:
> ij> select substr('abc', 1) from t1 order by substr('abc', 1);
> ERROR XJ001: Java exception: 'ASSERT FAILED col1.getClass() (class org.apache.derby.iapi.types.SQLVarchar) expected to be the same as col2.getClass() (class org.apache.derby.iapi.types.SQLChar): org.apache.derby.shared.common.sanity.AssertFailure'.
> Stacktrace:
> org.apache.derby.shared.common.sanity.AssertFailure: ASSERT FAILED col1.getClass() (class org.apache.derby.iapi.types.SQLVarchar) expected to be the same as col2.getClass() (class org.apache.derby.iapi.types.SQLChar)
> at org.apache.derby.shared.common.sanity.SanityManager.THROWASSERT(SanityManager.java:149)
> at org.apache.derby.impl.store.access.sort.MergeSort.checkColumnTypes(MergeSort.java:472)
> at org.apache.derby.impl.store.access.sort.MergeInserter.insert(MergeInserter.java:106)
> at org.apache.derby.impl.sql.execute.SortResultSet.loadSorter(SortResultSet.java:318)
> at org.apache.derby.impl.sql.execute.SortResultSet.openCore(SortResultSet.java:269)
> at org.apache.derby.impl.sql.execute.ProjectRestrictResultSet.openCore(ProjectRestrictResultSet.java:169)
> at org.apache.derby.impl.sql.execute.BasicNoPutResultSetImpl.open(BasicNoPutResultSetImpl.java:260)
> at org.apache.derby.impl.sql.GenericPreparedStatement.execute(GenericPreparedStatement.java:358)
> at org.apache.derby.impl.jdbc.EmbedStatement.executeStatement(EmbedStatement.java:1182)
> at org.apache.derby.impl.jdbc.EmbedStatement.execute(EmbedStatement.java:585)
> at org.apache.derby.impl.jdbc.EmbedStatement.execute(EmbedStatement.java:517)
> at org.apache.derby.impl.tools.ij.ij.executeImmediate(ij.java:321)
> at org.apache.derby.impl.tools.ij.utilMain.doCatch(utilMain.java:517)
> at org.apache.derby.impl.tools.ij.utilMain.runScriptGuts(utilMain.java:370)
> at org.apache.derby.impl.tools.ij.utilMain.go(utilMain.java:268)
> at org.apache.derby.impl.tools.ij.Main.go(Main.java:204)
> at org.apache.derby.impl.tools.ij.Main.mainCore(Main.java:170)
> at org.apache.derby.impl.tools.ij.Main14.main(Main14.java:56)
> at org.apache.derby.tools.ij.main(ij.java:71)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2352) Assertion Failure with order by and
group by expression
Posted by "Bryan Pendleton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Pendleton updated DERBY-2352:
-----------------------------------
Attachment: substrBindWithTests.diff
Attached is 'substrBindWithTests.diff', which includes some simple
tests that verify that substrBind now works correctly.
I believe this patch is ready for review. Please let me know what you think.
derbyall and suites.All were clean.
> Assertion Failure with order by and group by expression
> -------------------------------------------------------
>
> Key: DERBY-2352
> URL: https://issues.apache.org/jira/browse/DERBY-2352
> Project: Derby
> Issue Type: Bug
> Components: SQL
> Affects Versions: 10.2.2.0, 10.3.1.4
> Environment: Any
> Reporter: Yip Ng
> Assignee: Bryan Pendleton
> Attachments: substrBind.diff, substrBindWithTests.diff, substringReturnsChar.diff
>
>
> Assertion failure with order by expression:
> ij> select substr('abc', 1) from t1 order by substr('abc', 1);
> ERROR XJ001: Java exception: 'ASSERT FAILED col1.getClass() (class org.apache.derby.iapi.types.SQLVarchar) expected to be the same as col2.getClass() (class org.apache.derby.iapi.types.SQLChar): org.apache.derby.shared.common.sanity.AssertFailure'.
> Stacktrace:
> org.apache.derby.shared.common.sanity.AssertFailure: ASSERT FAILED col1.getClass() (class org.apache.derby.iapi.types.SQLVarchar) expected to be the same as col2.getClass() (class org.apache.derby.iapi.types.SQLChar)
> at org.apache.derby.shared.common.sanity.SanityManager.THROWASSERT(SanityManager.java:149)
> at org.apache.derby.impl.store.access.sort.MergeSort.checkColumnTypes(MergeSort.java:472)
> at org.apache.derby.impl.store.access.sort.MergeInserter.insert(MergeInserter.java:106)
> at org.apache.derby.impl.sql.execute.SortResultSet.loadSorter(SortResultSet.java:318)
> at org.apache.derby.impl.sql.execute.SortResultSet.openCore(SortResultSet.java:269)
> at org.apache.derby.impl.sql.execute.ProjectRestrictResultSet.openCore(ProjectRestrictResultSet.java:169)
> at org.apache.derby.impl.sql.execute.BasicNoPutResultSetImpl.open(BasicNoPutResultSetImpl.java:260)
> at org.apache.derby.impl.sql.GenericPreparedStatement.execute(GenericPreparedStatement.java:358)
> at org.apache.derby.impl.jdbc.EmbedStatement.executeStatement(EmbedStatement.java:1182)
> at org.apache.derby.impl.jdbc.EmbedStatement.execute(EmbedStatement.java:585)
> at org.apache.derby.impl.jdbc.EmbedStatement.execute(EmbedStatement.java:517)
> at org.apache.derby.impl.tools.ij.ij.executeImmediate(ij.java:321)
> at org.apache.derby.impl.tools.ij.utilMain.doCatch(utilMain.java:517)
> at org.apache.derby.impl.tools.ij.utilMain.runScriptGuts(utilMain.java:370)
> at org.apache.derby.impl.tools.ij.utilMain.go(utilMain.java:268)
> at org.apache.derby.impl.tools.ij.Main.go(Main.java:204)
> at org.apache.derby.impl.tools.ij.Main.mainCore(Main.java:170)
> at org.apache.derby.impl.tools.ij.Main14.main(Main14.java:56)
> at org.apache.derby.tools.ij.main(ij.java:71)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2352) Assertion Failure with order by
expression
Posted by "Yip Ng (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12473904 ]
Yip Ng commented on DERBY-2352:
-------------------------------
Also fails with group by expression.
ij> select substr('abc', 1) from t1 group by substr('abc', 1);
ERROR XJ001: Java exception: 'ASSERT FAILED col1.getClass() (class org.apache.de
rby.iapi.types.SQLVarchar) expected to be the same as col2.getClass() (class org
.apache.derby.iapi.types.SQLChar): org.apache.derby.shared.common.sanity.AssertF
ailure'.
> Assertion Failure with order by expression
> ------------------------------------------
>
> Key: DERBY-2352
> URL: https://issues.apache.org/jira/browse/DERBY-2352
> Project: Derby
> Issue Type: Bug
> Components: SQL
> Affects Versions: 10.2.2.0, 10.3.0.0
> Environment: Any
> Reporter: Yip Ng
>
> Assertion failure with order by expression:
> ij> select substr('abc', 1) from t1 order by substr('abc', 1);
> ERROR XJ001: Java exception: 'ASSERT FAILED col1.getClass() (class org.apache.derby.iapi.types.SQLVarchar) expected to be the same as col2.getClass() (class org.apache.derby.iapi.types.SQLChar): org.apache.derby.shared.common.sanity.AssertFailure'.
> Stacktrace:
> org.apache.derby.shared.common.sanity.AssertFailure: ASSERT FAILED col1.getClass() (class org.apache.derby.iapi.types.SQLVarchar) expected to be the same as col2.getClass() (class org.apache.derby.iapi.types.SQLChar)
> at org.apache.derby.shared.common.sanity.SanityManager.THROWASSERT(SanityManager.java:149)
> at org.apache.derby.impl.store.access.sort.MergeSort.checkColumnTypes(MergeSort.java:472)
> at org.apache.derby.impl.store.access.sort.MergeInserter.insert(MergeInserter.java:106)
> at org.apache.derby.impl.sql.execute.SortResultSet.loadSorter(SortResultSet.java:318)
> at org.apache.derby.impl.sql.execute.SortResultSet.openCore(SortResultSet.java:269)
> at org.apache.derby.impl.sql.execute.ProjectRestrictResultSet.openCore(ProjectRestrictResultSet.java:169)
> at org.apache.derby.impl.sql.execute.BasicNoPutResultSetImpl.open(BasicNoPutResultSetImpl.java:260)
> at org.apache.derby.impl.sql.GenericPreparedStatement.execute(GenericPreparedStatement.java:358)
> at org.apache.derby.impl.jdbc.EmbedStatement.executeStatement(EmbedStatement.java:1182)
> at org.apache.derby.impl.jdbc.EmbedStatement.execute(EmbedStatement.java:585)
> at org.apache.derby.impl.jdbc.EmbedStatement.execute(EmbedStatement.java:517)
> at org.apache.derby.impl.tools.ij.ij.executeImmediate(ij.java:321)
> at org.apache.derby.impl.tools.ij.utilMain.doCatch(utilMain.java:517)
> at org.apache.derby.impl.tools.ij.utilMain.runScriptGuts(utilMain.java:370)
> at org.apache.derby.impl.tools.ij.utilMain.go(utilMain.java:268)
> at org.apache.derby.impl.tools.ij.Main.go(Main.java:204)
> at org.apache.derby.impl.tools.ij.Main.mainCore(Main.java:170)
> at org.apache.derby.impl.tools.ij.Main14.main(Main14.java:56)
> at org.apache.derby.tools.ij.main(ij.java:71)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2352) Assertion Failure with order by and
group by expression
Posted by "Bryan Pendleton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12533945 ]
Bryan Pendleton commented on DERBY-2352:
----------------------------------------
Ah. For this to reproduce, table "t" must contain at least one row:
ij> insert into d2352 values (1), (2), (3);
3 rows inserted/updated/deleted
ij> select substr('abc', 1) from d2352 order by substr('abc', 1);
ERROR XJ001: Java exception: 'ASSERT FAILED col1.getClass() (class org.apache.de
rby.iapi.types.SQLVarchar) expected to be the same as col2.getClass() (class org
.apache.derby.iapi.types.SQLChar): org.apache.derby.shared.common.sanity.AssertF
ailure'.
> Assertion Failure with order by and group by expression
> -------------------------------------------------------
>
> Key: DERBY-2352
> URL: https://issues.apache.org/jira/browse/DERBY-2352
> Project: Derby
> Issue Type: Bug
> Components: SQL
> Affects Versions: 10.2.2.0, 10.3.1.4
> Environment: Any
> Reporter: Yip Ng
> Assignee: Bryan Pendleton
>
> Assertion failure with order by expression:
> ij> select substr('abc', 1) from t1 order by substr('abc', 1);
> ERROR XJ001: Java exception: 'ASSERT FAILED col1.getClass() (class org.apache.derby.iapi.types.SQLVarchar) expected to be the same as col2.getClass() (class org.apache.derby.iapi.types.SQLChar): org.apache.derby.shared.common.sanity.AssertFailure'.
> Stacktrace:
> org.apache.derby.shared.common.sanity.AssertFailure: ASSERT FAILED col1.getClass() (class org.apache.derby.iapi.types.SQLVarchar) expected to be the same as col2.getClass() (class org.apache.derby.iapi.types.SQLChar)
> at org.apache.derby.shared.common.sanity.SanityManager.THROWASSERT(SanityManager.java:149)
> at org.apache.derby.impl.store.access.sort.MergeSort.checkColumnTypes(MergeSort.java:472)
> at org.apache.derby.impl.store.access.sort.MergeInserter.insert(MergeInserter.java:106)
> at org.apache.derby.impl.sql.execute.SortResultSet.loadSorter(SortResultSet.java:318)
> at org.apache.derby.impl.sql.execute.SortResultSet.openCore(SortResultSet.java:269)
> at org.apache.derby.impl.sql.execute.ProjectRestrictResultSet.openCore(ProjectRestrictResultSet.java:169)
> at org.apache.derby.impl.sql.execute.BasicNoPutResultSetImpl.open(BasicNoPutResultSetImpl.java:260)
> at org.apache.derby.impl.sql.GenericPreparedStatement.execute(GenericPreparedStatement.java:358)
> at org.apache.derby.impl.jdbc.EmbedStatement.executeStatement(EmbedStatement.java:1182)
> at org.apache.derby.impl.jdbc.EmbedStatement.execute(EmbedStatement.java:585)
> at org.apache.derby.impl.jdbc.EmbedStatement.execute(EmbedStatement.java:517)
> at org.apache.derby.impl.tools.ij.ij.executeImmediate(ij.java:321)
> at org.apache.derby.impl.tools.ij.utilMain.doCatch(utilMain.java:517)
> at org.apache.derby.impl.tools.ij.utilMain.runScriptGuts(utilMain.java:370)
> at org.apache.derby.impl.tools.ij.utilMain.go(utilMain.java:268)
> at org.apache.derby.impl.tools.ij.Main.go(Main.java:204)
> at org.apache.derby.impl.tools.ij.Main.mainCore(Main.java:170)
> at org.apache.derby.impl.tools.ij.Main14.main(Main14.java:56)
> at org.apache.derby.tools.ij.main(ij.java:71)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2352) Assertion Failure with order by and
group by expression
Posted by "Bryan Pendleton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12531818 ]
Bryan Pendleton commented on DERBY-2352:
----------------------------------------
Is DERBY-3094 related?
> Assertion Failure with order by and group by expression
> -------------------------------------------------------
>
> Key: DERBY-2352
> URL: https://issues.apache.org/jira/browse/DERBY-2352
> Project: Derby
> Issue Type: Bug
> Components: SQL
> Affects Versions: 10.2.2.0, 10.3.1.4
> Environment: Any
> Reporter: Yip Ng
>
> Assertion failure with order by expression:
> ij> select substr('abc', 1) from t1 order by substr('abc', 1);
> ERROR XJ001: Java exception: 'ASSERT FAILED col1.getClass() (class org.apache.derby.iapi.types.SQLVarchar) expected to be the same as col2.getClass() (class org.apache.derby.iapi.types.SQLChar): org.apache.derby.shared.common.sanity.AssertFailure'.
> Stacktrace:
> org.apache.derby.shared.common.sanity.AssertFailure: ASSERT FAILED col1.getClass() (class org.apache.derby.iapi.types.SQLVarchar) expected to be the same as col2.getClass() (class org.apache.derby.iapi.types.SQLChar)
> at org.apache.derby.shared.common.sanity.SanityManager.THROWASSERT(SanityManager.java:149)
> at org.apache.derby.impl.store.access.sort.MergeSort.checkColumnTypes(MergeSort.java:472)
> at org.apache.derby.impl.store.access.sort.MergeInserter.insert(MergeInserter.java:106)
> at org.apache.derby.impl.sql.execute.SortResultSet.loadSorter(SortResultSet.java:318)
> at org.apache.derby.impl.sql.execute.SortResultSet.openCore(SortResultSet.java:269)
> at org.apache.derby.impl.sql.execute.ProjectRestrictResultSet.openCore(ProjectRestrictResultSet.java:169)
> at org.apache.derby.impl.sql.execute.BasicNoPutResultSetImpl.open(BasicNoPutResultSetImpl.java:260)
> at org.apache.derby.impl.sql.GenericPreparedStatement.execute(GenericPreparedStatement.java:358)
> at org.apache.derby.impl.jdbc.EmbedStatement.executeStatement(EmbedStatement.java:1182)
> at org.apache.derby.impl.jdbc.EmbedStatement.execute(EmbedStatement.java:585)
> at org.apache.derby.impl.jdbc.EmbedStatement.execute(EmbedStatement.java:517)
> at org.apache.derby.impl.tools.ij.ij.executeImmediate(ij.java:321)
> at org.apache.derby.impl.tools.ij.utilMain.doCatch(utilMain.java:517)
> at org.apache.derby.impl.tools.ij.utilMain.runScriptGuts(utilMain.java:370)
> at org.apache.derby.impl.tools.ij.utilMain.go(utilMain.java:268)
> at org.apache.derby.impl.tools.ij.Main.go(Main.java:204)
> at org.apache.derby.impl.tools.ij.Main.mainCore(Main.java:170)
> at org.apache.derby.impl.tools.ij.Main14.main(Main14.java:56)
> at org.apache.derby.tools.ij.main(ij.java:71)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2352) Assertion Failure with order by and
group by expression
Posted by "Bryan Pendleton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12533933 ]
Bryan Pendleton commented on DERBY-2352:
----------------------------------------
The group by variant did not easily reproduce, either:
ij> select substr('abc', 1) from d2352 group by substr('abc', 1);
1
----
0 rows selected
> Assertion Failure with order by and group by expression
> -------------------------------------------------------
>
> Key: DERBY-2352
> URL: https://issues.apache.org/jira/browse/DERBY-2352
> Project: Derby
> Issue Type: Bug
> Components: SQL
> Affects Versions: 10.2.2.0, 10.3.1.4
> Environment: Any
> Reporter: Yip Ng
> Assignee: Bryan Pendleton
>
> Assertion failure with order by expression:
> ij> select substr('abc', 1) from t1 order by substr('abc', 1);
> ERROR XJ001: Java exception: 'ASSERT FAILED col1.getClass() (class org.apache.derby.iapi.types.SQLVarchar) expected to be the same as col2.getClass() (class org.apache.derby.iapi.types.SQLChar): org.apache.derby.shared.common.sanity.AssertFailure'.
> Stacktrace:
> org.apache.derby.shared.common.sanity.AssertFailure: ASSERT FAILED col1.getClass() (class org.apache.derby.iapi.types.SQLVarchar) expected to be the same as col2.getClass() (class org.apache.derby.iapi.types.SQLChar)
> at org.apache.derby.shared.common.sanity.SanityManager.THROWASSERT(SanityManager.java:149)
> at org.apache.derby.impl.store.access.sort.MergeSort.checkColumnTypes(MergeSort.java:472)
> at org.apache.derby.impl.store.access.sort.MergeInserter.insert(MergeInserter.java:106)
> at org.apache.derby.impl.sql.execute.SortResultSet.loadSorter(SortResultSet.java:318)
> at org.apache.derby.impl.sql.execute.SortResultSet.openCore(SortResultSet.java:269)
> at org.apache.derby.impl.sql.execute.ProjectRestrictResultSet.openCore(ProjectRestrictResultSet.java:169)
> at org.apache.derby.impl.sql.execute.BasicNoPutResultSetImpl.open(BasicNoPutResultSetImpl.java:260)
> at org.apache.derby.impl.sql.GenericPreparedStatement.execute(GenericPreparedStatement.java:358)
> at org.apache.derby.impl.jdbc.EmbedStatement.executeStatement(EmbedStatement.java:1182)
> at org.apache.derby.impl.jdbc.EmbedStatement.execute(EmbedStatement.java:585)
> at org.apache.derby.impl.jdbc.EmbedStatement.execute(EmbedStatement.java:517)
> at org.apache.derby.impl.tools.ij.ij.executeImmediate(ij.java:321)
> at org.apache.derby.impl.tools.ij.utilMain.doCatch(utilMain.java:517)
> at org.apache.derby.impl.tools.ij.utilMain.runScriptGuts(utilMain.java:370)
> at org.apache.derby.impl.tools.ij.utilMain.go(utilMain.java:268)
> at org.apache.derby.impl.tools.ij.Main.go(Main.java:204)
> at org.apache.derby.impl.tools.ij.Main.mainCore(Main.java:170)
> at org.apache.derby.impl.tools.ij.Main14.main(Main14.java:56)
> at org.apache.derby.tools.ij.main(ij.java:71)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2352) Assertion Failure with order by and
group by expression
Posted by "Bryan Pendleton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12543301 ]
Bryan Pendleton commented on DERBY-2352:
----------------------------------------
Here is the generated projection (e1) and rowAllocator (e2) code for
select ltrim('abcd') from d2352 order by trim('abcd');
public Object e1()
throws StandardException, Exception
{
StringDataValue stringdatavalue = getDataValueFactory().getCharDataValue("abcd", null).
ansiTrim(2, getDataValueFactory().getCharDataValue(" ", null), e3);
e3 = stringdatavalue;
e2.setColumn(1, (DataValueDescriptor)stringdatavalue);
StringDataValue stringdatavalue1 = getDataValueFactory().getCharDataValue("abcd", null).
ansiTrim(2, getDataValueFactory().getCharDataValue(" ", null), e4);
e4 = stringdatavalue1;
e2.setColumn(2, (DataValueDescriptor)stringdatavalue1);
return e2;
}
public Object e2()
throws StandardException
{
e5.setColumn(1, getDataValueFactory().getNullVarchar(null));
e5.setColumn(2, getDataValueFactory().getNullVarchar(null));
return e5;
}
Note that the generated projection code calls SQLChar.ansiTrim, and also note
that the rowAllocator allocates columns of Varchar type, not of Char type.
I believe this explains why the CHAR vs VARCHAR assertion does not arise
in the cases of LTRIM and TRIM(TRAILING), but only for SUBSTR.
> Assertion Failure with order by and group by expression
> -------------------------------------------------------
>
> Key: DERBY-2352
> URL: https://issues.apache.org/jira/browse/DERBY-2352
> Project: Derby
> Issue Type: Bug
> Components: SQL
> Affects Versions: 10.2.2.0, 10.3.1.4
> Environment: Any
> Reporter: Yip Ng
> Assignee: Bryan Pendleton
> Attachments: substringReturnsChar.diff
>
>
> Assertion failure with order by expression:
> ij> select substr('abc', 1) from t1 order by substr('abc', 1);
> ERROR XJ001: Java exception: 'ASSERT FAILED col1.getClass() (class org.apache.derby.iapi.types.SQLVarchar) expected to be the same as col2.getClass() (class org.apache.derby.iapi.types.SQLChar): org.apache.derby.shared.common.sanity.AssertFailure'.
> Stacktrace:
> org.apache.derby.shared.common.sanity.AssertFailure: ASSERT FAILED col1.getClass() (class org.apache.derby.iapi.types.SQLVarchar) expected to be the same as col2.getClass() (class org.apache.derby.iapi.types.SQLChar)
> at org.apache.derby.shared.common.sanity.SanityManager.THROWASSERT(SanityManager.java:149)
> at org.apache.derby.impl.store.access.sort.MergeSort.checkColumnTypes(MergeSort.java:472)
> at org.apache.derby.impl.store.access.sort.MergeInserter.insert(MergeInserter.java:106)
> at org.apache.derby.impl.sql.execute.SortResultSet.loadSorter(SortResultSet.java:318)
> at org.apache.derby.impl.sql.execute.SortResultSet.openCore(SortResultSet.java:269)
> at org.apache.derby.impl.sql.execute.ProjectRestrictResultSet.openCore(ProjectRestrictResultSet.java:169)
> at org.apache.derby.impl.sql.execute.BasicNoPutResultSetImpl.open(BasicNoPutResultSetImpl.java:260)
> at org.apache.derby.impl.sql.GenericPreparedStatement.execute(GenericPreparedStatement.java:358)
> at org.apache.derby.impl.jdbc.EmbedStatement.executeStatement(EmbedStatement.java:1182)
> at org.apache.derby.impl.jdbc.EmbedStatement.execute(EmbedStatement.java:585)
> at org.apache.derby.impl.jdbc.EmbedStatement.execute(EmbedStatement.java:517)
> at org.apache.derby.impl.tools.ij.ij.executeImmediate(ij.java:321)
> at org.apache.derby.impl.tools.ij.utilMain.doCatch(utilMain.java:517)
> at org.apache.derby.impl.tools.ij.utilMain.runScriptGuts(utilMain.java:370)
> at org.apache.derby.impl.tools.ij.utilMain.go(utilMain.java:268)
> at org.apache.derby.impl.tools.ij.Main.go(Main.java:204)
> at org.apache.derby.impl.tools.ij.Main.mainCore(Main.java:170)
> at org.apache.derby.impl.tools.ij.Main14.main(Main14.java:56)
> at org.apache.derby.tools.ij.main(ij.java:71)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (DERBY-2352) Assertion Failure with order by and
group by expression
Posted by "Bryan Pendleton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Pendleton reassigned DERBY-2352:
--------------------------------------
Assignee: Bryan Pendleton
> Assertion Failure with order by and group by expression
> -------------------------------------------------------
>
> Key: DERBY-2352
> URL: https://issues.apache.org/jira/browse/DERBY-2352
> Project: Derby
> Issue Type: Bug
> Components: SQL
> Affects Versions: 10.2.2.0, 10.3.1.4
> Environment: Any
> Reporter: Yip Ng
> Assignee: Bryan Pendleton
>
> Assertion failure with order by expression:
> ij> select substr('abc', 1) from t1 order by substr('abc', 1);
> ERROR XJ001: Java exception: 'ASSERT FAILED col1.getClass() (class org.apache.derby.iapi.types.SQLVarchar) expected to be the same as col2.getClass() (class org.apache.derby.iapi.types.SQLChar): org.apache.derby.shared.common.sanity.AssertFailure'.
> Stacktrace:
> org.apache.derby.shared.common.sanity.AssertFailure: ASSERT FAILED col1.getClass() (class org.apache.derby.iapi.types.SQLVarchar) expected to be the same as col2.getClass() (class org.apache.derby.iapi.types.SQLChar)
> at org.apache.derby.shared.common.sanity.SanityManager.THROWASSERT(SanityManager.java:149)
> at org.apache.derby.impl.store.access.sort.MergeSort.checkColumnTypes(MergeSort.java:472)
> at org.apache.derby.impl.store.access.sort.MergeInserter.insert(MergeInserter.java:106)
> at org.apache.derby.impl.sql.execute.SortResultSet.loadSorter(SortResultSet.java:318)
> at org.apache.derby.impl.sql.execute.SortResultSet.openCore(SortResultSet.java:269)
> at org.apache.derby.impl.sql.execute.ProjectRestrictResultSet.openCore(ProjectRestrictResultSet.java:169)
> at org.apache.derby.impl.sql.execute.BasicNoPutResultSetImpl.open(BasicNoPutResultSetImpl.java:260)
> at org.apache.derby.impl.sql.GenericPreparedStatement.execute(GenericPreparedStatement.java:358)
> at org.apache.derby.impl.jdbc.EmbedStatement.executeStatement(EmbedStatement.java:1182)
> at org.apache.derby.impl.jdbc.EmbedStatement.execute(EmbedStatement.java:585)
> at org.apache.derby.impl.jdbc.EmbedStatement.execute(EmbedStatement.java:517)
> at org.apache.derby.impl.tools.ij.ij.executeImmediate(ij.java:321)
> at org.apache.derby.impl.tools.ij.utilMain.doCatch(utilMain.java:517)
> at org.apache.derby.impl.tools.ij.utilMain.runScriptGuts(utilMain.java:370)
> at org.apache.derby.impl.tools.ij.utilMain.go(utilMain.java:268)
> at org.apache.derby.impl.tools.ij.Main.go(Main.java:204)
> at org.apache.derby.impl.tools.ij.Main.mainCore(Main.java:170)
> at org.apache.derby.impl.tools.ij.Main14.main(Main14.java:56)
> at org.apache.derby.tools.ij.main(ij.java:71)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2352) Assertion Failure with order by and
group by expression
Posted by "Bryan Pendleton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12534436 ]
Bryan Pendleton commented on DERBY-2352:
----------------------------------------
Here is the generated code for the "projection" method (e1) and the "rowAllocator" method (e3)
for the "order by" variant of the select statement:
public Object e1()
throws StandardException, Exception
{
ConcatableDataValue concatabledatavalue =
getDataValueFactory().getCharDataValue("abc", null).
substring(getDataValueFactory().getDataValue(1, null), null, e3, 3);
e3 = concatabledatavalue;
e2.setColumn(1, (DataValueDescriptor)concatabledatavalue);
ConcatableDataValue concatabledatavalue1 =
getDataValueFactory().getCharDataValue("abc", null).
substring(getDataValueFactory().getDataValue(1, null), null, e4, 3);
e4 = concatabledatavalue1;
e2.setColumn(2, (DataValueDescriptor)concatabledatavalue1);
return e2;
}
public Object e2()
throws StandardException
{
e5.setColumn(1, getDataValueFactory().getNullChar(null));
e5.setColumn(2, getDataValueFactory().getNullChar(null));
return e5;
}
The projection method's call to getCharDataValue() constructs a SQLChar,
and SQLChar.substring() then returns a SQLVarchar.
But the rowAllocator's getNullChar() method constructs a SQLChar.
It is the mismatch between the SQLVarchar that is returned by substring,
and the SQLChar that is created by the rowAllocator's getNullChar, that
is causing the assertion to trip in the sorter.
> Assertion Failure with order by and group by expression
> -------------------------------------------------------
>
> Key: DERBY-2352
> URL: https://issues.apache.org/jira/browse/DERBY-2352
> Project: Derby
> Issue Type: Bug
> Components: SQL
> Affects Versions: 10.2.2.0, 10.3.1.4
> Environment: Any
> Reporter: Yip Ng
> Assignee: Bryan Pendleton
>
> Assertion failure with order by expression:
> ij> select substr('abc', 1) from t1 order by substr('abc', 1);
> ERROR XJ001: Java exception: 'ASSERT FAILED col1.getClass() (class org.apache.derby.iapi.types.SQLVarchar) expected to be the same as col2.getClass() (class org.apache.derby.iapi.types.SQLChar): org.apache.derby.shared.common.sanity.AssertFailure'.
> Stacktrace:
> org.apache.derby.shared.common.sanity.AssertFailure: ASSERT FAILED col1.getClass() (class org.apache.derby.iapi.types.SQLVarchar) expected to be the same as col2.getClass() (class org.apache.derby.iapi.types.SQLChar)
> at org.apache.derby.shared.common.sanity.SanityManager.THROWASSERT(SanityManager.java:149)
> at org.apache.derby.impl.store.access.sort.MergeSort.checkColumnTypes(MergeSort.java:472)
> at org.apache.derby.impl.store.access.sort.MergeInserter.insert(MergeInserter.java:106)
> at org.apache.derby.impl.sql.execute.SortResultSet.loadSorter(SortResultSet.java:318)
> at org.apache.derby.impl.sql.execute.SortResultSet.openCore(SortResultSet.java:269)
> at org.apache.derby.impl.sql.execute.ProjectRestrictResultSet.openCore(ProjectRestrictResultSet.java:169)
> at org.apache.derby.impl.sql.execute.BasicNoPutResultSetImpl.open(BasicNoPutResultSetImpl.java:260)
> at org.apache.derby.impl.sql.GenericPreparedStatement.execute(GenericPreparedStatement.java:358)
> at org.apache.derby.impl.jdbc.EmbedStatement.executeStatement(EmbedStatement.java:1182)
> at org.apache.derby.impl.jdbc.EmbedStatement.execute(EmbedStatement.java:585)
> at org.apache.derby.impl.jdbc.EmbedStatement.execute(EmbedStatement.java:517)
> at org.apache.derby.impl.tools.ij.ij.executeImmediate(ij.java:321)
> at org.apache.derby.impl.tools.ij.utilMain.doCatch(utilMain.java:517)
> at org.apache.derby.impl.tools.ij.utilMain.runScriptGuts(utilMain.java:370)
> at org.apache.derby.impl.tools.ij.utilMain.go(utilMain.java:268)
> at org.apache.derby.impl.tools.ij.Main.go(Main.java:204)
> at org.apache.derby.impl.tools.ij.Main.mainCore(Main.java:170)
> at org.apache.derby.impl.tools.ij.Main14.main(Main14.java:56)
> at org.apache.derby.tools.ij.main(ij.java:71)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2352) Assertion Failure with order by and
group by expression
Posted by "Bryan Pendleton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Pendleton updated DERBY-2352:
-----------------------------------
Attachment: substringReturnsChar.diff
Attached is substringReturnsChar.diff, which modifies the substring, trim, and similar functions in SQLChar so that they no longer always return a value of type SQLVarchar, but instead return either SQLChar or SQLVarchar, depending on what type of object they are called on.
That is, SQLChar.substring returns SQLChar, but SQLVarchar.substring returns SQLVarchar.
With this change, the reproduction code passes.
Also, with this change, derbyall and suites.All are 100% pass.
I intend to follow this up with a more complete patch proposal, including various new regression tests, to allow for a more complete review. In the meantime, any feedback about the attached code change is most welcome.
> Assertion Failure with order by and group by expression
> -------------------------------------------------------
>
> Key: DERBY-2352
> URL: https://issues.apache.org/jira/browse/DERBY-2352
> Project: Derby
> Issue Type: Bug
> Components: SQL
> Affects Versions: 10.2.2.0, 10.3.1.4
> Environment: Any
> Reporter: Yip Ng
> Assignee: Bryan Pendleton
> Attachments: substringReturnsChar.diff
>
>
> Assertion failure with order by expression:
> ij> select substr('abc', 1) from t1 order by substr('abc', 1);
> ERROR XJ001: Java exception: 'ASSERT FAILED col1.getClass() (class org.apache.derby.iapi.types.SQLVarchar) expected to be the same as col2.getClass() (class org.apache.derby.iapi.types.SQLChar): org.apache.derby.shared.common.sanity.AssertFailure'.
> Stacktrace:
> org.apache.derby.shared.common.sanity.AssertFailure: ASSERT FAILED col1.getClass() (class org.apache.derby.iapi.types.SQLVarchar) expected to be the same as col2.getClass() (class org.apache.derby.iapi.types.SQLChar)
> at org.apache.derby.shared.common.sanity.SanityManager.THROWASSERT(SanityManager.java:149)
> at org.apache.derby.impl.store.access.sort.MergeSort.checkColumnTypes(MergeSort.java:472)
> at org.apache.derby.impl.store.access.sort.MergeInserter.insert(MergeInserter.java:106)
> at org.apache.derby.impl.sql.execute.SortResultSet.loadSorter(SortResultSet.java:318)
> at org.apache.derby.impl.sql.execute.SortResultSet.openCore(SortResultSet.java:269)
> at org.apache.derby.impl.sql.execute.ProjectRestrictResultSet.openCore(ProjectRestrictResultSet.java:169)
> at org.apache.derby.impl.sql.execute.BasicNoPutResultSetImpl.open(BasicNoPutResultSetImpl.java:260)
> at org.apache.derby.impl.sql.GenericPreparedStatement.execute(GenericPreparedStatement.java:358)
> at org.apache.derby.impl.jdbc.EmbedStatement.executeStatement(EmbedStatement.java:1182)
> at org.apache.derby.impl.jdbc.EmbedStatement.execute(EmbedStatement.java:585)
> at org.apache.derby.impl.jdbc.EmbedStatement.execute(EmbedStatement.java:517)
> at org.apache.derby.impl.tools.ij.ij.executeImmediate(ij.java:321)
> at org.apache.derby.impl.tools.ij.utilMain.doCatch(utilMain.java:517)
> at org.apache.derby.impl.tools.ij.utilMain.runScriptGuts(utilMain.java:370)
> at org.apache.derby.impl.tools.ij.utilMain.go(utilMain.java:268)
> at org.apache.derby.impl.tools.ij.Main.go(Main.java:204)
> at org.apache.derby.impl.tools.ij.Main.mainCore(Main.java:170)
> at org.apache.derby.impl.tools.ij.Main14.main(Main14.java:56)
> at org.apache.derby.tools.ij.main(ij.java:71)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2352) Assertion Failure with order by and
group by expression
Posted by "Bryan Pendleton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12536899 ]
Bryan Pendleton commented on DERBY-2352:
----------------------------------------
A naive attempt to use other data types in the repro script via CAST expressions is not so successful:
ij> select substr( cast ('abc' as long varchar), 1) from d2352 order by substr(cast ('abc' as long varchar), 1);
ERROR X0X67: Columns of type 'LONG VARCHAR' may not be used in CREATE INDEX, ORDER BY, GROUP BY, UNION, INTERSECT, EXCEPT or DISTINCT statements because comparisons are not supported for that type.
ij> select substr( cast ('abc' as char for bit data), 1) from d2352 order by substr( cast ('abc' as char for bit data), 1);
ERROR 42846: Cannot convert types 'CHAR' to 'CHAR () FOR BIT DATA'.
ij> select substr( cast ('abc' as clob), 1) from d2352 order by substr( cast ('abc' as clob), 1);
ERROR X0X67: Columns of type 'CLOB' may not be used in CREATE INDEX, ORDER BY, GROUP BY, UNION, INTERSECT, EXCEPT or DISTINCT statements because comparisons are not supported for that type.
Perhaps I can still invoke substring, trim, and ansiTrim on these other data types, just not in the ORDER BY or GROUP BY clauses.
> Assertion Failure with order by and group by expression
> -------------------------------------------------------
>
> Key: DERBY-2352
> URL: https://issues.apache.org/jira/browse/DERBY-2352
> Project: Derby
> Issue Type: Bug
> Components: SQL
> Affects Versions: 10.2.2.0, 10.3.1.4
> Environment: Any
> Reporter: Yip Ng
> Assignee: Bryan Pendleton
> Attachments: substringReturnsChar.diff
>
>
> Assertion failure with order by expression:
> ij> select substr('abc', 1) from t1 order by substr('abc', 1);
> ERROR XJ001: Java exception: 'ASSERT FAILED col1.getClass() (class org.apache.derby.iapi.types.SQLVarchar) expected to be the same as col2.getClass() (class org.apache.derby.iapi.types.SQLChar): org.apache.derby.shared.common.sanity.AssertFailure'.
> Stacktrace:
> org.apache.derby.shared.common.sanity.AssertFailure: ASSERT FAILED col1.getClass() (class org.apache.derby.iapi.types.SQLVarchar) expected to be the same as col2.getClass() (class org.apache.derby.iapi.types.SQLChar)
> at org.apache.derby.shared.common.sanity.SanityManager.THROWASSERT(SanityManager.java:149)
> at org.apache.derby.impl.store.access.sort.MergeSort.checkColumnTypes(MergeSort.java:472)
> at org.apache.derby.impl.store.access.sort.MergeInserter.insert(MergeInserter.java:106)
> at org.apache.derby.impl.sql.execute.SortResultSet.loadSorter(SortResultSet.java:318)
> at org.apache.derby.impl.sql.execute.SortResultSet.openCore(SortResultSet.java:269)
> at org.apache.derby.impl.sql.execute.ProjectRestrictResultSet.openCore(ProjectRestrictResultSet.java:169)
> at org.apache.derby.impl.sql.execute.BasicNoPutResultSetImpl.open(BasicNoPutResultSetImpl.java:260)
> at org.apache.derby.impl.sql.GenericPreparedStatement.execute(GenericPreparedStatement.java:358)
> at org.apache.derby.impl.jdbc.EmbedStatement.executeStatement(EmbedStatement.java:1182)
> at org.apache.derby.impl.jdbc.EmbedStatement.execute(EmbedStatement.java:585)
> at org.apache.derby.impl.jdbc.EmbedStatement.execute(EmbedStatement.java:517)
> at org.apache.derby.impl.tools.ij.ij.executeImmediate(ij.java:321)
> at org.apache.derby.impl.tools.ij.utilMain.doCatch(utilMain.java:517)
> at org.apache.derby.impl.tools.ij.utilMain.runScriptGuts(utilMain.java:370)
> at org.apache.derby.impl.tools.ij.utilMain.go(utilMain.java:268)
> at org.apache.derby.impl.tools.ij.Main.go(Main.java:204)
> at org.apache.derby.impl.tools.ij.Main.mainCore(Main.java:170)
> at org.apache.derby.impl.tools.ij.Main14.main(Main14.java:56)
> at org.apache.derby.tools.ij.main(ij.java:71)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2352) Assertion Failure with order by and
group by expression
Posted by "Thomas Nielsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12543495 ]
Thomas Nielsen commented on DERBY-2352:
---------------------------------------
I'm giving the the latest patch a spin with the tests now.
Are the "missing" spaces in the
... trim(trailing' ' ...
of the last two select statements in 'orderby.out.original' intentional? Seems you have mixed using and not using a space - just curious.
To be really picky, there's an extra blank line (@839) introduced in TernaryOperatorNode.java by substrBindWithTests.diff.
Otherwise the patch looks sane to me.
> Assertion Failure with order by and group by expression
> -------------------------------------------------------
>
> Key: DERBY-2352
> URL: https://issues.apache.org/jira/browse/DERBY-2352
> Project: Derby
> Issue Type: Bug
> Components: SQL
> Affects Versions: 10.2.2.0, 10.3.1.4
> Environment: Any
> Reporter: Yip Ng
> Assignee: Bryan Pendleton
> Attachments: substrBind.diff, substrBindWithTests.diff, substringReturnsChar.diff
>
>
> Assertion failure with order by expression:
> ij> select substr('abc', 1) from t1 order by substr('abc', 1);
> ERROR XJ001: Java exception: 'ASSERT FAILED col1.getClass() (class org.apache.derby.iapi.types.SQLVarchar) expected to be the same as col2.getClass() (class org.apache.derby.iapi.types.SQLChar): org.apache.derby.shared.common.sanity.AssertFailure'.
> Stacktrace:
> org.apache.derby.shared.common.sanity.AssertFailure: ASSERT FAILED col1.getClass() (class org.apache.derby.iapi.types.SQLVarchar) expected to be the same as col2.getClass() (class org.apache.derby.iapi.types.SQLChar)
> at org.apache.derby.shared.common.sanity.SanityManager.THROWASSERT(SanityManager.java:149)
> at org.apache.derby.impl.store.access.sort.MergeSort.checkColumnTypes(MergeSort.java:472)
> at org.apache.derby.impl.store.access.sort.MergeInserter.insert(MergeInserter.java:106)
> at org.apache.derby.impl.sql.execute.SortResultSet.loadSorter(SortResultSet.java:318)
> at org.apache.derby.impl.sql.execute.SortResultSet.openCore(SortResultSet.java:269)
> at org.apache.derby.impl.sql.execute.ProjectRestrictResultSet.openCore(ProjectRestrictResultSet.java:169)
> at org.apache.derby.impl.sql.execute.BasicNoPutResultSetImpl.open(BasicNoPutResultSetImpl.java:260)
> at org.apache.derby.impl.sql.GenericPreparedStatement.execute(GenericPreparedStatement.java:358)
> at org.apache.derby.impl.jdbc.EmbedStatement.executeStatement(EmbedStatement.java:1182)
> at org.apache.derby.impl.jdbc.EmbedStatement.execute(EmbedStatement.java:585)
> at org.apache.derby.impl.jdbc.EmbedStatement.execute(EmbedStatement.java:517)
> at org.apache.derby.impl.tools.ij.ij.executeImmediate(ij.java:321)
> at org.apache.derby.impl.tools.ij.utilMain.doCatch(utilMain.java:517)
> at org.apache.derby.impl.tools.ij.utilMain.runScriptGuts(utilMain.java:370)
> at org.apache.derby.impl.tools.ij.utilMain.go(utilMain.java:268)
> at org.apache.derby.impl.tools.ij.Main.go(Main.java:204)
> at org.apache.derby.impl.tools.ij.Main.mainCore(Main.java:170)
> at org.apache.derby.impl.tools.ij.Main14.main(Main14.java:56)
> at org.apache.derby.tools.ij.main(ij.java:71)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2352) Assertion Failure with order by and
group by expression
Posted by "Bryan Pendleton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Pendleton updated DERBY-2352:
-----------------------------------
Derby Info: [Patch Available]
> Assertion Failure with order by and group by expression
> -------------------------------------------------------
>
> Key: DERBY-2352
> URL: https://issues.apache.org/jira/browse/DERBY-2352
> Project: Derby
> Issue Type: Bug
> Components: SQL
> Affects Versions: 10.2.2.0, 10.3.1.4
> Environment: Any
> Reporter: Yip Ng
> Assignee: Bryan Pendleton
> Attachments: substrBind.diff, substrBindWithTests.diff, substringReturnsChar.diff
>
>
> Assertion failure with order by expression:
> ij> select substr('abc', 1) from t1 order by substr('abc', 1);
> ERROR XJ001: Java exception: 'ASSERT FAILED col1.getClass() (class org.apache.derby.iapi.types.SQLVarchar) expected to be the same as col2.getClass() (class org.apache.derby.iapi.types.SQLChar): org.apache.derby.shared.common.sanity.AssertFailure'.
> Stacktrace:
> org.apache.derby.shared.common.sanity.AssertFailure: ASSERT FAILED col1.getClass() (class org.apache.derby.iapi.types.SQLVarchar) expected to be the same as col2.getClass() (class org.apache.derby.iapi.types.SQLChar)
> at org.apache.derby.shared.common.sanity.SanityManager.THROWASSERT(SanityManager.java:149)
> at org.apache.derby.impl.store.access.sort.MergeSort.checkColumnTypes(MergeSort.java:472)
> at org.apache.derby.impl.store.access.sort.MergeInserter.insert(MergeInserter.java:106)
> at org.apache.derby.impl.sql.execute.SortResultSet.loadSorter(SortResultSet.java:318)
> at org.apache.derby.impl.sql.execute.SortResultSet.openCore(SortResultSet.java:269)
> at org.apache.derby.impl.sql.execute.ProjectRestrictResultSet.openCore(ProjectRestrictResultSet.java:169)
> at org.apache.derby.impl.sql.execute.BasicNoPutResultSetImpl.open(BasicNoPutResultSetImpl.java:260)
> at org.apache.derby.impl.sql.GenericPreparedStatement.execute(GenericPreparedStatement.java:358)
> at org.apache.derby.impl.jdbc.EmbedStatement.executeStatement(EmbedStatement.java:1182)
> at org.apache.derby.impl.jdbc.EmbedStatement.execute(EmbedStatement.java:585)
> at org.apache.derby.impl.jdbc.EmbedStatement.execute(EmbedStatement.java:517)
> at org.apache.derby.impl.tools.ij.ij.executeImmediate(ij.java:321)
> at org.apache.derby.impl.tools.ij.utilMain.doCatch(utilMain.java:517)
> at org.apache.derby.impl.tools.ij.utilMain.runScriptGuts(utilMain.java:370)
> at org.apache.derby.impl.tools.ij.utilMain.go(utilMain.java:268)
> at org.apache.derby.impl.tools.ij.Main.go(Main.java:204)
> at org.apache.derby.impl.tools.ij.Main.mainCore(Main.java:170)
> at org.apache.derby.impl.tools.ij.Main14.main(Main14.java:56)
> at org.apache.derby.tools.ij.main(ij.java:71)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2352) Assertion Failure with order by and
group by expression
Posted by "Bryan Pendleton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12543312 ]
Bryan Pendleton commented on DERBY-2352:
----------------------------------------
According to fairly recent code coverage results, trim() is not called at all:
http://people.apache.org/~fuzzylogic/codecoverage/579033/_files/181.html#69
Also, I commented out the trim() method in SQLChar and in StringDataValue and
I got no compilation errors in the rest of the system, so perhaps SQLChar.trim
can be entirely removed. I'll log that as a separate JIRA for some future consideration.
In the meantime, I think I can proceed with putting together some test cases and
making a complete patch proposal out of the already-proposed code change.
> Assertion Failure with order by and group by expression
> -------------------------------------------------------
>
> Key: DERBY-2352
> URL: https://issues.apache.org/jira/browse/DERBY-2352
> Project: Derby
> Issue Type: Bug
> Components: SQL
> Affects Versions: 10.2.2.0, 10.3.1.4
> Environment: Any
> Reporter: Yip Ng
> Assignee: Bryan Pendleton
> Attachments: substringReturnsChar.diff
>
>
> Assertion failure with order by expression:
> ij> select substr('abc', 1) from t1 order by substr('abc', 1);
> ERROR XJ001: Java exception: 'ASSERT FAILED col1.getClass() (class org.apache.derby.iapi.types.SQLVarchar) expected to be the same as col2.getClass() (class org.apache.derby.iapi.types.SQLChar): org.apache.derby.shared.common.sanity.AssertFailure'.
> Stacktrace:
> org.apache.derby.shared.common.sanity.AssertFailure: ASSERT FAILED col1.getClass() (class org.apache.derby.iapi.types.SQLVarchar) expected to be the same as col2.getClass() (class org.apache.derby.iapi.types.SQLChar)
> at org.apache.derby.shared.common.sanity.SanityManager.THROWASSERT(SanityManager.java:149)
> at org.apache.derby.impl.store.access.sort.MergeSort.checkColumnTypes(MergeSort.java:472)
> at org.apache.derby.impl.store.access.sort.MergeInserter.insert(MergeInserter.java:106)
> at org.apache.derby.impl.sql.execute.SortResultSet.loadSorter(SortResultSet.java:318)
> at org.apache.derby.impl.sql.execute.SortResultSet.openCore(SortResultSet.java:269)
> at org.apache.derby.impl.sql.execute.ProjectRestrictResultSet.openCore(ProjectRestrictResultSet.java:169)
> at org.apache.derby.impl.sql.execute.BasicNoPutResultSetImpl.open(BasicNoPutResultSetImpl.java:260)
> at org.apache.derby.impl.sql.GenericPreparedStatement.execute(GenericPreparedStatement.java:358)
> at org.apache.derby.impl.jdbc.EmbedStatement.executeStatement(EmbedStatement.java:1182)
> at org.apache.derby.impl.jdbc.EmbedStatement.execute(EmbedStatement.java:585)
> at org.apache.derby.impl.jdbc.EmbedStatement.execute(EmbedStatement.java:517)
> at org.apache.derby.impl.tools.ij.ij.executeImmediate(ij.java:321)
> at org.apache.derby.impl.tools.ij.utilMain.doCatch(utilMain.java:517)
> at org.apache.derby.impl.tools.ij.utilMain.runScriptGuts(utilMain.java:370)
> at org.apache.derby.impl.tools.ij.utilMain.go(utilMain.java:268)
> at org.apache.derby.impl.tools.ij.Main.go(Main.java:204)
> at org.apache.derby.impl.tools.ij.Main.mainCore(Main.java:170)
> at org.apache.derby.impl.tools.ij.Main14.main(Main14.java:56)
> at org.apache.derby.tools.ij.main(ij.java:71)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2352) Assertion Failure with order by and
group by expression
Posted by "Bryan Pendleton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12533932 ]
Bryan Pendleton commented on DERBY-2352:
----------------------------------------
My first attempt to reproduce this failed:
ij version 10.4
ij> connect 'jdbc:derby:brydb;create=true';
ij> run 'd2352.sql';
ij> drop table d2352;
ERROR 42Y55: 'DROP TABLE' cannot be performed on 'D2352' because it does not exi
st.
ij> create table d2352 (c int);
0 rows inserted/updated/deleted
ij> select substr('abc', 1) from d2352 order by substr('abc', 1);
1
----
0 rows selected
> Assertion Failure with order by and group by expression
> -------------------------------------------------------
>
> Key: DERBY-2352
> URL: https://issues.apache.org/jira/browse/DERBY-2352
> Project: Derby
> Issue Type: Bug
> Components: SQL
> Affects Versions: 10.2.2.0, 10.3.1.4
> Environment: Any
> Reporter: Yip Ng
> Assignee: Bryan Pendleton
>
> Assertion failure with order by expression:
> ij> select substr('abc', 1) from t1 order by substr('abc', 1);
> ERROR XJ001: Java exception: 'ASSERT FAILED col1.getClass() (class org.apache.derby.iapi.types.SQLVarchar) expected to be the same as col2.getClass() (class org.apache.derby.iapi.types.SQLChar): org.apache.derby.shared.common.sanity.AssertFailure'.
> Stacktrace:
> org.apache.derby.shared.common.sanity.AssertFailure: ASSERT FAILED col1.getClass() (class org.apache.derby.iapi.types.SQLVarchar) expected to be the same as col2.getClass() (class org.apache.derby.iapi.types.SQLChar)
> at org.apache.derby.shared.common.sanity.SanityManager.THROWASSERT(SanityManager.java:149)
> at org.apache.derby.impl.store.access.sort.MergeSort.checkColumnTypes(MergeSort.java:472)
> at org.apache.derby.impl.store.access.sort.MergeInserter.insert(MergeInserter.java:106)
> at org.apache.derby.impl.sql.execute.SortResultSet.loadSorter(SortResultSet.java:318)
> at org.apache.derby.impl.sql.execute.SortResultSet.openCore(SortResultSet.java:269)
> at org.apache.derby.impl.sql.execute.ProjectRestrictResultSet.openCore(ProjectRestrictResultSet.java:169)
> at org.apache.derby.impl.sql.execute.BasicNoPutResultSetImpl.open(BasicNoPutResultSetImpl.java:260)
> at org.apache.derby.impl.sql.GenericPreparedStatement.execute(GenericPreparedStatement.java:358)
> at org.apache.derby.impl.jdbc.EmbedStatement.executeStatement(EmbedStatement.java:1182)
> at org.apache.derby.impl.jdbc.EmbedStatement.execute(EmbedStatement.java:585)
> at org.apache.derby.impl.jdbc.EmbedStatement.execute(EmbedStatement.java:517)
> at org.apache.derby.impl.tools.ij.ij.executeImmediate(ij.java:321)
> at org.apache.derby.impl.tools.ij.utilMain.doCatch(utilMain.java:517)
> at org.apache.derby.impl.tools.ij.utilMain.runScriptGuts(utilMain.java:370)
> at org.apache.derby.impl.tools.ij.utilMain.go(utilMain.java:268)
> at org.apache.derby.impl.tools.ij.Main.go(Main.java:204)
> at org.apache.derby.impl.tools.ij.Main.mainCore(Main.java:170)
> at org.apache.derby.impl.tools.ij.Main14.main(Main14.java:56)
> at org.apache.derby.tools.ij.main(ij.java:71)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (DERBY-2352) Assertion Failure with order by and
group by expression
Posted by "Bryan Pendleton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12534932 ]
Bryan Pendleton commented on DERBY-2352:
----------------------------------------
Seems like there are 3 alternatives worth pursuing:
1) Turn the SQLVarchar into a SQLChar
2) Turn the SQLChar into a SQLVarchar
3) Teach the sorter that it should tolerate a mixture of SQLVarchar/SQLChar
The first alternative involves modifying SQLChar.substring() so that
instead of returning a Varchar, it returns a Char. Perhaps the algorithm
could be something like: substring of a Char returns a Char; substring
of a Varchar returns a Varchar.
The second alternative involves modifying the code that generates the
projection and rowAllocator methods so that the code can more accurately
track the datatype of the ResultColumn in the presence of expression such
as substring, and ensure that the proper actual data type (Varchar in this case)
is used when generating the template row in the rowAllocator method. It
looks like TernaryNode.substrBind() makes some attempts to compute the
resulting data type; perhaps this data type computation just isn't making it
properly into the REsultColumn's data type ID.
The third alternative involves figuring out why MergeSort is complaining when
SQLVarchar != SQLChar, and whether MergeSort could be enhanced to
be more tolerant of mismatching types. As a start, I could try removing the
sanity assertion and see what problems occur farther down the road.
I don't immediately see any reason to prefer one of these solutions over any other;
if anybody has any suggestions about which course of action seems best, please
let me know. Otherwise I'll probably try them each and see how much progress I make.
> Assertion Failure with order by and group by expression
> -------------------------------------------------------
>
> Key: DERBY-2352
> URL: https://issues.apache.org/jira/browse/DERBY-2352
> Project: Derby
> Issue Type: Bug
> Components: SQL
> Affects Versions: 10.2.2.0, 10.3.1.4
> Environment: Any
> Reporter: Yip Ng
> Assignee: Bryan Pendleton
>
> Assertion failure with order by expression:
> ij> select substr('abc', 1) from t1 order by substr('abc', 1);
> ERROR XJ001: Java exception: 'ASSERT FAILED col1.getClass() (class org.apache.derby.iapi.types.SQLVarchar) expected to be the same as col2.getClass() (class org.apache.derby.iapi.types.SQLChar): org.apache.derby.shared.common.sanity.AssertFailure'.
> Stacktrace:
> org.apache.derby.shared.common.sanity.AssertFailure: ASSERT FAILED col1.getClass() (class org.apache.derby.iapi.types.SQLVarchar) expected to be the same as col2.getClass() (class org.apache.derby.iapi.types.SQLChar)
> at org.apache.derby.shared.common.sanity.SanityManager.THROWASSERT(SanityManager.java:149)
> at org.apache.derby.impl.store.access.sort.MergeSort.checkColumnTypes(MergeSort.java:472)
> at org.apache.derby.impl.store.access.sort.MergeInserter.insert(MergeInserter.java:106)
> at org.apache.derby.impl.sql.execute.SortResultSet.loadSorter(SortResultSet.java:318)
> at org.apache.derby.impl.sql.execute.SortResultSet.openCore(SortResultSet.java:269)
> at org.apache.derby.impl.sql.execute.ProjectRestrictResultSet.openCore(ProjectRestrictResultSet.java:169)
> at org.apache.derby.impl.sql.execute.BasicNoPutResultSetImpl.open(BasicNoPutResultSetImpl.java:260)
> at org.apache.derby.impl.sql.GenericPreparedStatement.execute(GenericPreparedStatement.java:358)
> at org.apache.derby.impl.jdbc.EmbedStatement.executeStatement(EmbedStatement.java:1182)
> at org.apache.derby.impl.jdbc.EmbedStatement.execute(EmbedStatement.java:585)
> at org.apache.derby.impl.jdbc.EmbedStatement.execute(EmbedStatement.java:517)
> at org.apache.derby.impl.tools.ij.ij.executeImmediate(ij.java:321)
> at org.apache.derby.impl.tools.ij.utilMain.doCatch(utilMain.java:517)
> at org.apache.derby.impl.tools.ij.utilMain.runScriptGuts(utilMain.java:370)
> at org.apache.derby.impl.tools.ij.utilMain.go(utilMain.java:268)
> at org.apache.derby.impl.tools.ij.Main.go(Main.java:204)
> at org.apache.derby.impl.tools.ij.Main.mainCore(Main.java:170)
> at org.apache.derby.impl.tools.ij.Main14.main(Main14.java:56)
> at org.apache.derby.tools.ij.main(ij.java:71)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (DERBY-2352) Assertion Failure with order by and
group by expression
Posted by "Bryan Pendleton (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DERBY-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Pendleton updated DERBY-2352:
-----------------------------------
Attachment: substrBindWithTestsUpdated.diff
Attached 'substrBindWithTestsUpdated.diff' incorporates the feedback
from Thomas. Re-testing was uneventful.
I intend to commit this change to the trunk fairly soon.
> Assertion Failure with order by and group by expression
> -------------------------------------------------------
>
> Key: DERBY-2352
> URL: https://issues.apache.org/jira/browse/DERBY-2352
> Project: Derby
> Issue Type: Bug
> Components: SQL
> Affects Versions: 10.2.2.0, 10.3.1.4
> Environment: Any
> Reporter: Yip Ng
> Assignee: Bryan Pendleton
> Attachments: substrBind.diff, substrBindWithTests.diff, substrBindWithTestsUpdated.diff, substringReturnsChar.diff
>
>
> Assertion failure with order by expression:
> ij> select substr('abc', 1) from t1 order by substr('abc', 1);
> ERROR XJ001: Java exception: 'ASSERT FAILED col1.getClass() (class org.apache.derby.iapi.types.SQLVarchar) expected to be the same as col2.getClass() (class org.apache.derby.iapi.types.SQLChar): org.apache.derby.shared.common.sanity.AssertFailure'.
> Stacktrace:
> org.apache.derby.shared.common.sanity.AssertFailure: ASSERT FAILED col1.getClass() (class org.apache.derby.iapi.types.SQLVarchar) expected to be the same as col2.getClass() (class org.apache.derby.iapi.types.SQLChar)
> at org.apache.derby.shared.common.sanity.SanityManager.THROWASSERT(SanityManager.java:149)
> at org.apache.derby.impl.store.access.sort.MergeSort.checkColumnTypes(MergeSort.java:472)
> at org.apache.derby.impl.store.access.sort.MergeInserter.insert(MergeInserter.java:106)
> at org.apache.derby.impl.sql.execute.SortResultSet.loadSorter(SortResultSet.java:318)
> at org.apache.derby.impl.sql.execute.SortResultSet.openCore(SortResultSet.java:269)
> at org.apache.derby.impl.sql.execute.ProjectRestrictResultSet.openCore(ProjectRestrictResultSet.java:169)
> at org.apache.derby.impl.sql.execute.BasicNoPutResultSetImpl.open(BasicNoPutResultSetImpl.java:260)
> at org.apache.derby.impl.sql.GenericPreparedStatement.execute(GenericPreparedStatement.java:358)
> at org.apache.derby.impl.jdbc.EmbedStatement.executeStatement(EmbedStatement.java:1182)
> at org.apache.derby.impl.jdbc.EmbedStatement.execute(EmbedStatement.java:585)
> at org.apache.derby.impl.jdbc.EmbedStatement.execute(EmbedStatement.java:517)
> at org.apache.derby.impl.tools.ij.ij.executeImmediate(ij.java:321)
> at org.apache.derby.impl.tools.ij.utilMain.doCatch(utilMain.java:517)
> at org.apache.derby.impl.tools.ij.utilMain.runScriptGuts(utilMain.java:370)
> at org.apache.derby.impl.tools.ij.utilMain.go(utilMain.java:268)
> at org.apache.derby.impl.tools.ij.Main.go(Main.java:204)
> at org.apache.derby.impl.tools.ij.Main.mainCore(Main.java:170)
> at org.apache.derby.impl.tools.ij.Main14.main(Main14.java:56)
> at org.apache.derby.tools.ij.main(ij.java:71)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.