You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Raymie Stata (Created) (JIRA)" <ji...@apache.org> on 2012/02/08 07:32:59 UTC
[jira] [Created] (AVRO-1023) Saved state should be restored in
finally clause
Saved state should be restored in finally clause
------------------------------------------------
Key: AVRO-1023
URL: https://issues.apache.org/jira/browse/AVRO-1023
Project: Avro
Issue Type: Bug
Components: java
Reporter: Raymie Stata
Priority: Minor
Schema.parse(JsonParse) and Schema.parse(JsonNode,Names) save global state in a local variable; they should restore that state in a finally clause but they don't.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AVRO-1023) Saved state should be restored in
finally clause
Posted by "Raymie Stata (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-1023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raymie Stata updated AVRO-1023:
-------------------------------
Attachment: AVRO-1023.patch
This patch looks big because I put fairly long stretches of code into a try/finally block, and had to re-indent it. Except for the reindenting, none of the code moved inside the try/finally has been changed.
> Saved state should be restored in finally clause
> ------------------------------------------------
>
> Key: AVRO-1023
> URL: https://issues.apache.org/jira/browse/AVRO-1023
> Project: Avro
> Issue Type: Bug
> Components: java
> Reporter: Raymie Stata
> Assignee: Raymie Stata
> Priority: Minor
> Attachments: AVRO-1023.patch
>
>
> Schema.parse(JsonParse) and Schema.parse(JsonNode,Names) save global state in a local variable; they should restore that state in a finally clause but they don't.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AVRO-1023) Saved state should be restored in
finally clause
Posted by "Scott Carey (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-1023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203330#comment-13203330 ]
Scott Carey commented on AVRO-1023:
-----------------------------------
We should also add a unit test that fails if this is not applied.
> Saved state should be restored in finally clause
> ------------------------------------------------
>
> Key: AVRO-1023
> URL: https://issues.apache.org/jira/browse/AVRO-1023
> Project: Avro
> Issue Type: Bug
> Components: java
> Reporter: Raymie Stata
> Assignee: Raymie Stata
> Priority: Minor
> Attachments: AVRO-1023.patch
>
>
> Schema.parse(JsonParse) and Schema.parse(JsonNode,Names) save global state in a local variable; they should restore that state in a finally clause but they don't.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AVRO-1023) Saved state should be restored in
finally clause
Posted by "Doug Cutting (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-1023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214094#comment-13214094 ]
Doug Cutting commented on AVRO-1023:
------------------------------------
The way this might be triggered is if a Schema.Parser is reused after a SchemaParseException is thrown. Currently the default namespace is that of the preceding schema parsed. If a SchemaParseException is thrown and the parser is reused then the default namespace could be that of a schema nested within the previous schema.
> Saved state should be restored in finally clause
> ------------------------------------------------
>
> Key: AVRO-1023
> URL: https://issues.apache.org/jira/browse/AVRO-1023
> Project: Avro
> Issue Type: Bug
> Components: java
> Reporter: Raymie Stata
> Assignee: Raymie Stata
> Priority: Minor
> Attachments: AVRO-1023.patch
>
>
> Schema.parse(JsonParse) and Schema.parse(JsonNode,Names) save global state in a local variable; they should restore that state in a finally clause but they don't.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AVRO-1023) Saved state should be restored in
finally clause
Posted by "Raymie Stata (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-1023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raymie Stata updated AVRO-1023:
-------------------------------
Status: Patch Available (was: Open)
> Saved state should be restored in finally clause
> ------------------------------------------------
>
> Key: AVRO-1023
> URL: https://issues.apache.org/jira/browse/AVRO-1023
> Project: Avro
> Issue Type: Bug
> Components: java
> Reporter: Raymie Stata
> Assignee: Raymie Stata
> Priority: Minor
> Attachments: AVRO-1023.patch
>
>
> Schema.parse(JsonParse) and Schema.parse(JsonNode,Names) save global state in a local variable; they should restore that state in a finally clause but they don't.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (AVRO-1023) Saved state should be restored in
finally clause
Posted by "Raymie Stata (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-1023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Raymie Stata reassigned AVRO-1023:
----------------------------------
Assignee: Raymie Stata
> Saved state should be restored in finally clause
> ------------------------------------------------
>
> Key: AVRO-1023
> URL: https://issues.apache.org/jira/browse/AVRO-1023
> Project: Avro
> Issue Type: Bug
> Components: java
> Reporter: Raymie Stata
> Assignee: Raymie Stata
> Priority: Minor
>
> Schema.parse(JsonParse) and Schema.parse(JsonNode,Names) save global state in a local variable; they should restore that state in a finally clause but they don't.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira