You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/05/09 17:47:54 UTC

[GitHub] [iceberg] rdblue commented on a diff in pull request #4685: Python: First version of the Accessor

rdblue commented on code in PR #4685:
URL: https://github.com/apache/iceberg/pull/4685#discussion_r868264489


##########
python/tests/conftest.py:
##########
@@ -19,7 +19,7 @@
 
 import pytest
 
-from iceberg import schema
+from iceberg.schema import Schema

Review Comment:
   I think that the module name was used on purpose. @samredai, didn't you say that using the module name as a prefix was recommended for readability?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org