[GitHub] [accumulo] milleruntime commented on a change in pull request #2569: Single node prop store refactor

[GitBox <gi...@apache.org>]

milleruntime commented on a change in pull request #2569:
URL: https://github.com/apache/accumulo/pull/2569#discussion_r829059364



##########
File path: core/src/main/java/org/apache/accumulo/core/conf/AccumuloConfiguration.java
##########
@@ -597,4 +599,13 @@ public T derive() {
    * this configuration.
    */
   public void invalidateCache() {}
+
+  /**
+   * get a parent configuration or null if it does not exist.
+   *
+   * @since 2.1.0
+   */
+  public AccumuloConfiguration getParent() {
+    return null;

Review comment:
       Ok. I think this should probably throw an exception then. If the class doesn't have a parent, do we want `getParent()` to return null?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org