You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "simicd (via GitHub)" <gi...@apache.org> on 2023/02/15 21:27:00 UTC

[GitHub] [arrow-datafusion-python] simicd opened a new pull request, #182: test: Window functions

simicd opened a new pull request, #182:
URL: https://github.com/apache/arrow-datafusion-python/pull/182

   # Which issue does this PR close?
   Closes #72
   Closes #135
   
    # Rationale for this change
   Confirm window functions work by adding unit tests.
   
   # What changes are included in this PR?
   - Test all window functions
   - Fix non-deterministic unit test by sorting results before assertion
   
   # Are there any user-facing changes?
   n/a


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion-python] simicd commented on pull request #182: test: Window functions

Posted by "simicd (via GitHub)" <gi...@apache.org>.
simicd commented on PR #182:
URL: https://github.com/apache/arrow-datafusion-python/pull/182#issuecomment-1432190670

   Thanks for the review @andygrove!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion-python] andygrove merged pull request #182: test: Window functions

Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove merged PR #182:
URL: https://github.com/apache/arrow-datafusion-python/pull/182


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org