[GitHub] maropu commented on a change in pull request #23551: [SPARK-26622][SQL] Revise SQL Metrics labels

[GitBox <gi...@apache.org>]

maropu commented on a change in pull request #23551: [SPARK-26622][SQL] Revise SQL Metrics labels
URL: https://github.com/apache/spark/pull/23551#discussion_r247876262
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/BasicWriteStatsTracker.scala
 ##########
 @@ -173,7 +173,7 @@ object BasicWriteJobStatsTracker {
     val sparkContext = SparkContext.getActive.get
     Map(
       NUM_FILES_KEY -> SQLMetrics.createMetric(sparkContext, "number of written files"),
-      NUM_OUTPUT_BYTES_KEY -> SQLMetrics.createMetric(sparkContext, "bytes of written output"),
+      NUM_OUTPUT_BYTES_KEY -> SQLMetrics.createSizeMetric(sparkContext, "written output"),
 
 Review comment:
   This change looks reasonable to me, but it seems there are other places having the same issue?, e.g.,
   https://github.com/apache/spark/blob/a77505d4d3e5db4413d7fa76610265792d949c64/sql/core/src/main/scala/org/apache/spark/sql/execution/basicPhysicalOperators.scala#L666

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org